Re: [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

Paulo Zanoni
2014-08-12T19:33:14Z

2014-08-12 16:28 GMT-03:00 Chris Wilson <chris@chris-wilson.co.uk>:
> On Tue, Aug 12, 2014 at 04:12:38PM -0300, Paulo Zanoni wrote:
>> But we just get/put RPM around this function, not for the whole time
>> while the object is pinned.
>
> Ah misread, saw pin->get, unpin->put and assumed the symmetry. But why
> unpin then? It doesn't touch any hardware registers.

Only because Daniel asked it on a conversation we had on IRC, and I
automatically assumed the patch would be rejected if I didn't include
it :)

Since both you and VIlle pointed that out, I should probably submit
yet another version, without the unpin part, and let Daniel choose
which one to merge...

> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre

--
Paulo Zanoni