From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH] drm/i915: fix suspend/resume for GENs w/o runtime PM support Date: Tue, 26 Aug 2014 12:01:33 +0300 Message-ID: <1409043693.2960.7.camel@intelbox> References: <1408357206-19511-1-git-send-email-imre.deak@intel.com> <20140826074442.GA15520@phenom.ffwll.local> <20140826074538.GB15520@phenom.ffwll.local> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1940636757==" Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 42CD26E488 for ; Tue, 26 Aug 2014 02:02:29 -0700 (PDT) In-Reply-To: <20140826074538.GB15520@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, Sagar Kamble List-Id: intel-gfx@lists.freedesktop.org --===============1940636757== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-Ny6bFoz2g+ze2oR7Bw09" --=-Ny6bFoz2g+ze2oR7Bw09 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2014-08-26 at 09:45 +0200, Daniel Vetter wrote: > On Tue, Aug 26, 2014 at 09:44:42AM +0200, Daniel Vetter wrote: > > On Mon, Aug 18, 2014 at 01:20:06PM +0300, Imre Deak wrote: > > > Before sharing common parts between the system and runtime s/r > > > handlers we WARNed if the runtime s/r handlers were called on GENs th= at > > > didn't support RPM. But this WARN is not correct if the same handler = is > > > called from the system s/r path, since that can happen on any platfor= m. > > > This also broke system s/r on old platforms. > > >=20 > > > The issue was introduced in > > >=20 > > > commit 016970beb05da6285c2f3ed2bee1c676cb75972e > > > Author: Sagar Kamble > > > Date: Wed Aug 13 23:07:06 2014 +0530 > > >=20 > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D82751 > > > Signed-off-by: Imre Deak > >=20 > > Adding boolean arguments to control warnings always feels a bit too muc= h > > like just shutting up the warnings. Can't we instead wrap the relevant > > calls into HAS_RUNTIME_PM checks? I could instead remove the WARN from intel_suspend_complete/resume, and do an early return from intel_runtime_suspend/resume for !HAS_RUNTIME_PM(). Atm we only WARN there. > > Imo that would also lead to clearer code > > by making the intention clear - with this you essentially have to git > > blame to figure out why we sometimes disable the warning. >=20 > Also the patch subject is a bit misleading - we only shut up a wrong > warning, it's not a code fix. We return -ENODEV for old GENs which breaks system suspend for them. --Imre --=-Ny6bFoz2g+ze2oR7Bw09 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJT/EztAAoJEORIIAnNuWDF+3oIAIofKCKWkVnfjQ63hpI1pAAm ryVfDrCInT5PjAsH3AThB2W1yC95bZ5OYEI/Gubs6HEqS3ZONFCluFZMU58CftxO /ipkBveomf7ujby2Ju/eHi6W1DcOS1O2PDddZLeAQXBKHL+94GT/M5EB4SQX9lsC STHMSliwaCLKdW2q942PyEmoiav+dbDxG7dNRZ8SubQHGSNfh6XNXvWxzgXGNU6E PM4dpms2VSogi97xw85D7vrJT8mYxOqO/XrZfVcS844H3bLMnmdoOcWKPGmmGXL1 +mqaxkaT814lVG+ySkus2XzauVnJ4CPxddTHHJyqHVtDCL/hHr0H2EfYK/5zruo= =9P0A -----END PGP SIGNATURE----- --=-Ny6bFoz2g+ze2oR7Bw09-- --===============1940636757== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1940636757==--