From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 09/16] drm/i915: check for GT faults during S3 resume and S4 restore too Date: Thu, 11 Sep 2014 14:53:10 +0300 Message-ID: <1410436390.4879.1.camel@intelbox> References: <1410362229-814-1-git-send-email-imre.deak@intel.com> <1410362229-814-10-git-send-email-imre.deak@intel.com> <20140911074732.GE28332@nuc-i3427.alporthouse.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0976614559==" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 96FE16E578 for ; Thu, 11 Sep 2014 04:54:13 -0700 (PDT) In-Reply-To: <20140911074732.GE28332@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0976614559== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-3CNEpRlNpGJ8cmgXddWj" --=-3CNEpRlNpGJ8cmgXddWj Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2014-09-11 at 08:47 +0100, Chris Wilson wrote: > On Wed, Sep 10, 2014 at 06:17:02PM +0300, Imre Deak wrote: > > Checking for GT faults is not specific in any way to S4 thaw, so do it > > also during S3 resume and S4 restore. This allows us to unify the > > handlers for these events in an upcoming patch. >=20 > So why not just move i915_check_and_clear_faults() to > intel_uncore_early_santize()? That would seem to be the right BIOS > scrubbing function that should also be doing this task. Ok, haven't consider moving the check, but it makes sense. --Imre --=-3CNEpRlNpGJ8cmgXddWj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJUEY0mAAoJEORIIAnNuWDFwe0H/ibCONSvtiKb2neZEWDqEd9R 5PpqorDBVRrEx1zmvFbwkLSRkuysf3puRbBGcoom4AXwLK0Rxed0aiuLKn+Bci+z YdOow6f8gN4dV5Ph+/IiEKqba47uVln3FQhfQ9w6vssRjVXOXK3qoau5q0FqEhkA qEJMeODApfwSrao9iSrXbzrddShvbCoiAKaBBjFxhhup/sIsBEB3d3ZjvrOq846k 5AMQ0noj0fhluBCS1sWIH1/S7LeB8aXkPMdkaZzFnUeOnsLdkZD9HtWPah8j1kHW ZF2oM3nr/1mtVt3vaFyc9Muyf3VQGj7/3QWYm25NO/GXJzk0sWHjks3B1KK82v8= =jh1f -----END PGP SIGNATURE----- --=-3CNEpRlNpGJ8cmgXddWj-- --===============0976614559== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0976614559==--