From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 08/16] drm/i915: remove unused restore_gtt_mappings optimization during suspend Date: Thu, 11 Sep 2014 14:59:35 +0300 Message-ID: <1410436775.4879.8.camel@intelbox> References: <1410362229-814-1-git-send-email-imre.deak@intel.com> <1410362229-814-9-git-send-email-imre.deak@intel.com> <20140911074903.GF28332@nuc-i3427.alporthouse.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1570168745==" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 2DE5C6E07E for ; Thu, 11 Sep 2014 04:59:38 -0700 (PDT) In-Reply-To: <20140911074903.GF28332@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Jesse Barnes List-Id: intel-gfx@lists.freedesktop.org --===============1570168745== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-xJtd+qFAS4Sc04tn/sjS" --=-xJtd+qFAS4Sc04tn/sjS Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2014-09-11 at 08:49 +0100, Chris Wilson wrote: > On Wed, Sep 10, 2014 at 06:17:01PM +0300, Imre Deak wrote: > > Since correctness wins over optimal code and since the optimization >=20 > Optimal code is also correct ;-) s/optimal/just plain broken/ Yes, bad wording. To clarify, since the optimization is now always off anyway (and it's also broken), I would hope that we could remove it for now and concentrate on fixing the existing s/r issues. Once we find that things are stable enough we could add back this optimization. --Imre --=-xJtd+qFAS4Sc04tn/sjS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJUEY6nAAoJEORIIAnNuWDFq10H/1M00A4+DvTvNJlxWBOrXhC/ QrkZiB8UUxk9kR3sHF361ZBqFgqtCVtm6iJi7YMdSYacGYDNeUfVwXH2AbVwzLVK y8gKJTU6yUvb7vvrbd0QD+sGtrZ/39itlvztxzkGtOQhZ3uN94tsQfCTxilB4LfX hOXhJE/TnOtGGUDsPidVhZ7/4PS2A76gmz+ZSJ3HBSe8NOQvW9RWNjKaV0F6NKb6 Tik7BprZ0qdKhv4D4ap28MHEJRhXh4Qdm2chsUWQCM4aOwnrJxFrzXTR6idwHGOU TeCsKkHPnawydOuAZQluSsdqu1EQY6UeY87WSEBnEKXn+Yav+VuXFZeYCK281jM= =akHa -----END PGP SIGNATURE----- --=-xJtd+qFAS4Sc04tn/sjS-- --===============1570168745== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1570168745==--