From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 00/16] fix VLV S4 suspend/resume, unify S3/S4 handlers Date: Thu, 11 Sep 2014 16:48:54 +0300 Message-ID: <1410443334.4879.42.camel@intelbox> References: <1410362229-814-1-git-send-email-imre.deak@intel.com> <20140910155208.GV15520@phenom.ffwll.local> <1410374330.8230.8.camel@ideak-mobl> <20140911090222.GH15520@phenom.ffwll.local> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1599009959==" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id CA1B46E58E for ; Thu, 11 Sep 2014 06:49:56 -0700 (PDT) In-Reply-To: <20140911090222.GH15520@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1599009959== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-0dtiEVKeW5/wwdVQkgWF" --=-0dtiEVKeW5/wwdVQkgWF Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2014-09-11 at 11:02 +0200, Daniel Vetter wrote: > On Wed, Sep 10, 2014 at 09:38:50PM +0300, Imre Deak wrote: > > On Wed, 2014-09-10 at 17:52 +0200, Daniel Vetter wrote: > > > On Wed, Sep 10, 2014 at 06:16:53PM +0300, Imre Deak wrote: > > > > The first part of the patchset (1-6) fixes an S4 bug on VLV introdu= ced > > > > recently. The rest unifies the various S3/S4 handlers, which are in > > > > practice the same. The only real difference - besides some unused c= ode - > > > > is that during S3 suspend we disable the PCI device whereas across = an S4 > > > > freeze/thaw we keep it enabled. Given that we disable everything el= se > > > > anyway, we can just as well disable the PCI device there too. Doing= so > > > > allows us to handle S3 suspend/resume and S4 freeze/thaw/restore/ > > > > power-off the same way, simplifying/clarifying things quite a bit. > > >=20 > > > Hm, this might explain why we've seen random corruption on S4 on rece= nt > > > platforms. > > >=20 > > > https://bugzilla.kernel.org/show_bug.cgi?id=3D59321 > > >=20 > > > Can you please ask for retesting from reporters? > >=20 > > Ok, can do, I also forgot to add > >=20 > > https://bugs.freedesktop.org/show_bug.cgi?id=3D82842 > >=20 > > which it fixes. I can't see immediately how platforms other than VLV > > would be fixed with these, but maybe I missed something. >=20 > drm/i915: disable/re-enable PCI device around S4 freeze/thaw >=20 > looks rather generic and not vlv specific, and could very well fix the > kernel bz I've pasted. Or am I horribly blind? Yea it's generic, so possibly fixes something. Although by the time we disable the PCI device in freeze everything should be idle, so if simply disabling/re-enabling makes a difference then we failed to idle something. Or we depend on a HW reset (implicit in the disable/re-enable) before reinitializing things in thaw. Anyway we can clarify this more once we get feedback from the retesting. --Imre --=-0dtiEVKeW5/wwdVQkgWF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJUEahGAAoJEORIIAnNuWDFbuMIAO44XzHrZG6KMBFmbrB/C+CM nqHms6Ih9PI7BHxN3t1yk57tkFYBw7BfP9HrYS6C8qMZgcbRbdVnCAd/nzxR3lo4 +R9Abg+eKIy0q4WIIKhtobTg1JSH+lmwPTAnlBjo1CcRuqf8o7F5i7oOzMF7V8US 7athXzsIDsrd0Q44SqoqI+ZFuG8rMAm0A0pKFwWIz+lgvLdXR6nDr9w4OKW+s+nY CAZRIyjj9Rlbw6dsjnVn6hFiipVeUpei9jG7N9b64ZN8uSg5iSaVRkfDmmtBuFFi 4zl8qGrjhm9hjBARy/DgiwB9MCMR24m19cdXT/dsTH8l4S2eDuy5Hs/X/tSLvVY= =2wD9 -----END PGP SIGNATURE----- --=-0dtiEVKeW5/wwdVQkgWF-- --===============1599009959== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1599009959==--