Re: [PATCH v2 0/2] Disable Android low memory killer

Daniel Vetter
2014-09-29T13:34:49Z

On Mon, Sep 29, 2014 at 01:34:29PM +0100, tim.gore@intel.com wrote:
> From: Tim Gore <tim.gore@intel.com>
>
> For some tests that put pressure on memory, the Android
> lowmemorykiller needs to be disabled for the test to run to
> completion. The first patch is a simple bit of preparation
> to ensure that all (well written) "simple" tests exit via a
> call to igt_exit, in the same way as tests with subtests do.
> This is to make sure we can clean up by re-enabling the
> lowmemorykiller.
> The second patch is to disable the Android lowmemorykiller
> during the common initialisation code (in oom_adjust_for_doom
> to be exact) and to re-enstate it in igt_exit.
>
> v1: As above
>
> v2: Remove the call to disable the lowmemorykiller from
> oom_adjust_for_doom. lowmemorykiller is not disabled
> by default now; it is up to each individual test to
> call low_mem_killer_disable() if it needs to.

See my late replies (I was off for an extended w/e). Summary:
- I think we should just do this unconditionally since it's a hack and
pointless to burden tests with it.
- proper exit handler and you can gc patch 1.

Cheers, Daniel
>
> Tim Gore (2):
> lib/igt_core: make single/simple tests use igt_exit
> lib/igt_core.c: add function to disable lowmemorykiller
>
> lib/igt_core.c | 79 +++++++++++++++++++++++++++++++++++++++++++++++---
> lib/igt_core.h | 2 +-
> tests/igt_simulation.c | 2 +-
> 3 files changed, 77 insertions(+), 6 deletions(-)
>
> --
> 2.1.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch