Re: [PATCH 00/14] i915 kerneldocs part 1

[Imre Deak <imre.deak@intel.com>]

On Tue, 2014-09-30 at 10:56 +0200, Daniel Vetter wrote:
> Hi all,
> 
> So I've decided that it's really time to (slowly) crawl through i915 and
> document everything. It's going to take years, but here's a start at least.
> 
> I realize that this has good chances to create a constant stream of little
> conflicts all over. Well, so be it, I really think we need this.
> 
> Overall approach is fairly simple:
> 1. Clean up interfaces for a set of functions.
> 2. Extract them into a new file grouped nicely together.
> 3. Write kerneldoc including short overview section.
> 4. Repeat.
> 
> So here's the first batch. Comments & flames highly welcome. Review assignments
> below (counts for all the patches above the block).
> 
> Cheers, Daniel
> 
> Daniel Vetter (14):
>   drm/i915: Remove intel_modeset_suspend_hw
>   drm/i915: Extract intel_runtime_pm.c
>   drm/i915: Bikeshed rpm functions name a bit.
>   drm/i915: Move intel_display_set_init_power to intel_runtime_pm.c
>   drm/i915: Call runtime_pm_disable directly
>   drm/i915: Kerneldoc for intel_runtime_pm.c
> 
> Reviewer: Imre

With the optional nitpicks I sent separately for the above 6 patches:
Reviewed-by: Imre Deak <imre.deak@intel.com>

> 
>   drm/i915: s/pm._irqs_disabled/pm.irqs_enabled/
>   drm/i915: Use dev_priv instead of dev in irq setup functions
>   drm/i915: kerneldoc for interrupt enable/disable functions
>   drm/i915: Extract intel_fifo_underrun.c
>   drm/i915: Use dev_priv in public intel_fifo_underrun.c functions
>   drm/i915: Add wrappers to handle fifo underrun interrupts
>   drm/i915: Filter gmch fifo underruns in the shared handler
>   drm/i915: kerneldoc for intel_fifo_underrun.c
> 
> Reviewer: Paulo
> 
>  Documentation/DocBook/drm.tmpl             |   26 +
>  drivers/gpu/drm/i915/Makefile              |    5 +-
>  drivers/gpu/drm/i915/i915_debugfs.c        |    2 +-
>  drivers/gpu/drm/i915/i915_dma.c            |   25 +-
>  drivers/gpu/drm/i915/i915_drv.c            |   14 +-
>  drivers/gpu/drm/i915/i915_drv.h            |   22 +-
>  drivers/gpu/drm/i915/i915_irq.c            |  491 +++-------
>  drivers/gpu/drm/i915/intel_crt.c           |    2 +-
>  drivers/gpu/drm/i915/intel_ddi.c           |    8 +-
>  drivers/gpu/drm/i915/intel_display.c       |   84 +-
>  drivers/gpu/drm/i915/intel_dp.c            |    2 +-
>  drivers/gpu/drm/i915/intel_drv.h           |   62 +-
>  drivers/gpu/drm/i915/intel_dsi.c           |    2 +-
>  drivers/gpu/drm/i915/intel_fifo_underrun.c |  380 ++++++++
>  drivers/gpu/drm/i915/intel_hdmi.c          |    2 +-
>  drivers/gpu/drm/i915/intel_lvds.c          |    2 +-
>  drivers/gpu/drm/i915/intel_pm.c            | 1159 -----------------------
>  drivers/gpu/drm/i915/intel_runtime_pm.c    | 1372 ++++++++++++++++++++++++++++
>  18 files changed, 2016 insertions(+), 1644 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/intel_fifo_underrun.c
>  create mode 100644 drivers/gpu/drm/i915/intel_runtime_pm.c
>