From mboxrd@z Thu Jan 1 00:00:00 1970 From: John.C.Harrison@Intel.com Subject: [RFC 01/21] Bug: missing i915_seqno_passed() call? Date: Mon, 6 Oct 2014 15:15:05 +0100 Message-ID: <1412604925-11290-2-git-send-email-John.C.Harrison@Intel.com> References: <1412604925-11290-1-git-send-email-John.C.Harrison@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 179CD89939 for ; Mon, 6 Oct 2014 07:15:37 -0700 (PDT) In-Reply-To: <1412604925-11290-1-git-send-email-John.C.Harrison@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org From: John Harrison --- drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 2a5351d..8c68219 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -2886,7 +2886,7 @@ i915_gem_object_sync(struct drm_i915_gem_object *obj, seqno = obj->last_read_seqno; /* Optimization: Avoid semaphore sync when we are sure we already * waited for an object with higher seqno */ - if (seqno <= from->semaphore.sync_seqno[idx]) + if (seqno <= from->semaphore.sync_seqno[idx]) /* <--- broken?! needs to use i915_seqno_passed()??? */ return 0; ret = i915_gem_check_olr(obj->ring, seqno); -- 1.7.9.5