public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Ander Conselvan de Oliveira <conselvan2@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Subject: [PATCH 0/4] [RFC] Stage shared dpll configs
Date: Wed,  8 Oct 2014 18:32:19 +0300	[thread overview]
Message-ID: <1412782343-28836-1-git-send-email-conselvan2@gmail.com> (raw)

From: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>

Hi,

This series changes the mode set sequence so that the clock and PLL
logic that was done in the *_crtc_mode_set() hooks is done before
disabling crtcs. This avoids having to restore the old configuration
in the case of failure, since the hardware was never touched.

The changes went through only light testing in a single platform. But I'd
like to get comments on the general approach sooner rather than later,
hence this RFC.

Thanks,
Ander

Ander Conselvan de Oliveira (4):
  drm/i915: Replace some loop through encoders with
    intel_pipe_has_type()
  drm/i915: Make *_crtc_mode_set work on new_config
  drm/i915: Convert shared dpll reference count to a crtc mask
  drm/i915: Compute clocks and choose DPLLs before disabling crtcs

 drivers/gpu/drm/i915/i915_debugfs.c  |   4 +-
 drivers/gpu/drm/i915/i915_drv.h      |  11 +-
 drivers/gpu/drm/i915/intel_ddi.c     |   6 +-
 drivers/gpu/drm/i915/intel_display.c | 346 ++++++++++++++++++++++-------------
 4 files changed, 230 insertions(+), 137 deletions(-)

-- 
1.8.3.2

             reply	other threads:[~2014-10-08 15:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08 15:32 Ander Conselvan de Oliveira [this message]
2014-10-08 15:32 ` [PATCH 1/4] drm/i915: Replace some loop through encoders with intel_pipe_has_type() Ander Conselvan de Oliveira
2014-10-08 15:32 ` [PATCH 2/4] drm/i915: Make *_crtc_mode_set work on new_config Ander Conselvan de Oliveira
2014-10-09  8:28   ` Daniel Vetter
2014-10-09  9:11   ` Daniel Vetter
2014-10-09 12:18     ` Ander Conselvan de Oliveira
2014-10-19 14:28       ` Daniel Vetter
2014-10-19 14:30         ` Daniel Vetter
2014-10-20 10:49           ` Ander Conselvan de Oliveira
2014-10-08 15:32 ` [PATCH 3/4] drm/i915: Convert shared dpll reference count to a crtc mask Ander Conselvan de Oliveira
2014-10-08 15:32 ` [PATCH 4/4] drm/i915: Compute clocks and choose DPLLs before disabling crtcs Ander Conselvan de Oliveira
2014-10-09  8:34   ` Daniel Vetter
2014-10-09  8:52     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412782343-28836-1-git-send-email-conselvan2@gmail.com \
    --to=conselvan2@gmail.com \
    --cc=ander.conselvan.de.oliveira@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox