From: Imre Deak <imre.deak@intel.com>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Initialize PPS timetamps on vlv/chv
Date: Tue, 28 Oct 2014 17:48:34 +0200 [thread overview]
Message-ID: <1414511314.8635.47.camel@intelbox> (raw)
In-Reply-To: <1414505752-7800-1-git-send-email-ville.syrjala@linux.intel.com>
On Tue, 2014-10-28 at 16:15 +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The pps timestamp initialization was accidentally lost on vlv/chv in
>
> commit a4a5d2f8a96e09844a91469e889f15bd5e927399
> Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Date: Thu Sep 4 14:54:20 2014 +0300
>
> drm/i915: Track which port is using which pipe's power sequencer
>
> Restore it so that we avoid introducing random delays into the pps operations
> during/after driver init time.
>
> Cc: Imre Deak <imre.deak@intel.com>
> Reported-by: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Both patches look good to me:
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 82e47da..25fe260 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -5383,12 +5383,11 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port,
>
> if (is_edp(intel_dp)) {
> pps_lock(intel_dp);
> - if (IS_VALLEYVIEW(dev)) {
> + intel_dp_init_panel_power_timestamps(intel_dp);
> + if (IS_VALLEYVIEW(dev))
> vlv_initial_power_sequencer_setup(intel_dp);
> - } else {
> - intel_dp_init_panel_power_timestamps(intel_dp);
> + else
> intel_dp_init_panel_power_sequencer(dev, intel_dp);
> - }
> pps_unlock(intel_dp);
> }
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-10-28 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 14:15 [PATCH 1/2] drm/i915: Initialize PPS timetamps on vlv/chv ville.syrjala
2014-10-28 14:15 ` [PATCH 2/2] drm/i915: Read out the power sequencer port assignment on resume " ville.syrjala
2014-10-28 15:48 ` Imre Deak [this message]
2014-11-03 12:20 ` [PATCH 1/2] drm/i915: Initialize PPS timetamps " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414511314.8635.47.camel@intelbox \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox