Re: [PATCH] drm/i915: fix RPS on runtime suspend

Daniel Vetter
2014-11-03T16:42:53Z

On Thu, Oct 30, 2014 at 10:36:23PM +0200, Imre Deak wrote:
> On Thu, 2014-10-30 at 15:59 -0200, Paulo Zanoni wrote:
> > From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > With this patch, the RPS sequence for runtime suspend/resume is
> > exactly like the sequence for S3 suspend/resume:
> > - flush_delayed_work(&dev_priv->rps.delayed_resume_work)
> > - intel_runtime_pm_disable_interrupts()
> > - intel_suspend_gt_powersave()
> > (suspended)
> > - intel_runtime_pm_enable_interrupts()
> > - intel_enable_gt_powersave()
> >
> > With this, we get rid of WARNs that are currently intermittently
> > triggered by the system-suspend-execbuf subtest of runtime PM. Notice
> > that these WARNs could also be triggered in other ways that involved
> > doing lots of RPM suspend/resume cycles just after a system S3 resume.
> >
> > Testcase: igt/pm_rpm/system-suspend-execbuf
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> This also fixes some parts of pm_rpm subtest failures on VLV so you
> could add:
> Reference: https://bugs.freedesktop.org/show_bug.cgi?id=82939
> and
> Reviewed-by: Imre Deak <imre.deak@intel.com>

Queued for -next, thanks for the patch.

> While fixing the same WARN in the above bug I also cleaned up the rps
> code a bit and made the disabling part more robust against rearming the
> rps work. But that's a separate issue which can't normally happen here,
> so I can send a version rebased on top of your changes.

Yes, please!

Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch