From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Menzel Subject: Re: [PATCH] drm/i915: Mark fastboot as unsafe Date: Wed, 05 Nov 2014 00:03:47 +0100 Message-ID: <1415142227.3601.84.camel@users.sourceforge.net> References: <1415111397-6604-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0923310447==" Return-path: Received: from mail.gw90.de (mail.gw90.de [188.40.100.199]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D4C46E5E3 for ; Tue, 4 Nov 2014 15:28:03 -0800 (PST) In-Reply-To: <1415111397-6604-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org --===============0923310447== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-YO8iNSgX6Q34LUjho9Zd" --=-YO8iNSgX6Q34LUjho9Zd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dear Daniel, thank you for the support in #intel-gfx@irc.freenode.net and the patch. As already commented in the bug report #84682, there are some typos. Am Dienstag, den 04.11.2014, 15:29 +0100 schrieb Daniel Vetter: > Fastboot in its current incarnation assumes that the pfit isn't > relevatn for the state and that it can be disabled without restarting releva*nt* > the crtc. Unfortunately that's not the case on gen2/3 - it upsets the > hw and results in a black screen. >=20 > Worse, the way the current fastboot hack is structure we can't detect structure*d* > and work around this in the code, since the fastboot smashes the > adjusted mode into crtc->mode. Which means the higher levels can't > correctly figure out that this is a lie and act accordingly. >=20 > Since fastboot is just a tech demo let's mark the module option as > experimental and close the coresponding reports as wontfix. cor*r*esponding > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D84682 > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_params.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i9= 15_params.c > index c91cb2033cc5..93d792349668 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -138,7 +138,7 @@ MODULE_PARM_DESC(disable_power_well, > module_param_named(enable_ips, i915.enable_ips, int, 0600); > MODULE_PARM_DESC(enable_ips, "Enable IPS (default: true)"); > =20 > -module_param_named(fastboot, i915.fastboot, bool, 0600); > +module_param_named_unsafe(fastboot, i915.fastboot, bool, 0600); > MODULE_PARM_DESC(fastboot, > "Try to skip unnecessary mode sets at boot time (default: false)"); Thanks, Paul --=-YO8iNSgX6Q34LUjho9Zd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlRZW1sACgkQPX1aK2wOHVjcDgCdFbmBmo7gy47Xpo1xowN9bmH2 kNkAn1qXzxSN6TGefrFT3Y76AVbD879h =OsM5 -----END PGP SIGNATURE----- --=-YO8iNSgX6Q34LUjho9Zd-- --===============0923310447== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============0923310447==--