Re: [PATCH 38/89] drm/i915/skl: Implement drm_plane vfuncs

Damien Lespiau
2014-09-16T13:20:43Z

On Thu, Sep 04, 2014 at 03:21:16PM +0200, Daniel Vetter wrote:
> On Thu, Sep 04, 2014 at 12:27:04PM +0100, Damien Lespiau wrote:
> > SKL Uses the same hardware for all planes now, so called "universal"
> > planes. Ie both the primary planes and sprite planes share the same
> > logic. This patch implements the drm_plane vfuncs for "sprites" ie
> > planes that aren't the primary plane.
> >
> > v2: Couple of fixes:
> > - Actually enabled the planes and fix the plane number
> >
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
>
> This needs to be de-duped I think ...

I was hoping to do that in a separate task on top. Right now the two
code paths are not quite ready to be merged together, close though.

> especially since it will conflict quite badly with Padovan's ongoing
> work to introduce a struct intel_plane_config.
>
> Not sure yet how we can shuffle the merge here, I guess it'll be a
> case of who's first wins ;-)

mine mine mine :) well, we shall see, so far, so good.

--
Damien