Re: [PATCH 77/89] drm/i915: Introduce a for_each_plane() macro

Daniel Vetter
2014-09-04T14:15:49Z

On Thu, Sep 04, 2014 at 03:05:11PM +0100, Damien Lespiau wrote:
> On Thu, Sep 04, 2014 at 04:00:32PM +0200, Daniel Vetter wrote:
> > On Thu, Sep 04, 2014 at 02:32:47PM +0100, Chris Wilson wrote:
> > > On Thu, Sep 04, 2014 at 12:27:43PM +0100, Damien Lespiau wrote:
> > > > Tired of copy/pasting things around.
> > > >
> > > > v2: Rebase on top of the for_each_pipe() change adding dev_priv as first
> > > > argument.
> > > >
> > > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> > > > ---
> > > > drivers/gpu/drm/i915/i915_drv.h | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> > > > index 91ea2b7..95e57dc 100644
> > > > --- a/drivers/gpu/drm/i915/i915_drv.h
> > > > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > > > @@ -176,6 +176,8 @@ enum hpd_pin {
> > > >
> > > > #define for_each_pipe(__dev_priv, __p) \
> > > > for ((__p) = 0; (__p) < INTEL_INFO(__dev_priv)->num_pipes; (__p)++)
> > > > +#define for_each_plane(pipe, p) \
> > > > + for ((p) = 0; (p) < INTEL_INFO(dev)->num_sprites[(pipe)] + 1; (p)++)
> > >
> > > We are adding new magic macros taking dev...
> > >
> > > > #define for_each_sprite(p, s) for ((s) = 0; (s) < INTEL_INFO(dev)->num_sprites[(p)]; (s)++)
> > > I haven't asked you to fix this one yet either.
> >
> > Ok, dropping again for now ...
>
> The problem is that I then need to touch the patches that depend on it,
> some not very interesting manipulations. Can't we have this as is and
> I'll fix later?

Ok.

Queued for -next again, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch