Re: [PATCH 72/89] drm/i915/skl: Enable/disable power well for aux transaction

Daniel Vetter
2014-09-16T16:13:02Z

On Tue, Sep 16, 2014 at 04:19:07PM +0300, Imre Deak wrote:
> On Thu, 2014-09-04 at 12:27 +0100, Damien Lespiau wrote:
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> > index 93bd9bf..a983b40 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -1233,6 +1233,9 @@ static bool edp_panel_vdd_on(struct intel_dp *intel_dp)
> > power_domain = intel_display_port_power_domain(intel_encoder);
> > intel_display_power_get(dev_priv, power_domain);
> >
> > + power_domain = intel_display_aux_power_domain(intel_encoder);
> > + intel_display_power_get(dev_priv, power_domain);
> > +
>
> The AUX power domains were added to save power when only AUX
> functionality is needed, since then we don't need to power on the power
> domain needed for full port functionality. With the above change and
> everywhere else below we'll end up enabling both power domains, though
> we only need AUX functionality.
>
> The power wells needed for AUX are a subset of those needed for full
> port functionality on all platforms (at least atm), so this patch won't
> change anything. The patch would make sense, if you requested only the
> AUX domains.

Also this changes shared code so should be split out from the stage 1
enabling. At least if we want to push it to 3.18 since drm-next already
closed feature-wise for that kernel.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch