Re: [PATCH 50/89] drm/i915/skl: Read the pipe WM HW state

Damien Lespiau
2014-10-30T12:04:08Z

On Wed, Oct 29, 2014 at 09:02:58PM +0200, Ville Syrjälä wrote:
> Am I imagining it or could this function be reduced to four lines if you
> would just pass the target struct as a parameter instead of the
> (is_transwm,is_cursor,i,level) tuple? Ah no, crap, SoA strikes back. So I
> think I mentioned it already during my first round of reviews that I'd
> like make a bunch of this stuff AoS instead. But that's a recipe for
> massive conflicts so let's get the current stuff in first before we go
> tearing into those structures.

I have to concur, it looks ugly. I also like the pragmatic r-b + list of
improvements, thanks or that. We even have a Jira task for the rework
now, things need to settle down a bit before I can address this (or we
find someone else to do it).

--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org