Re: [PATCH 47/89] drm/i915/skl: SKL Watermark Computation

Damien Lespiau
2014-09-22T22:36:42Z

Hi Satheesh,

On Wed, Sep 17, 2014 at 03:07:51PM +0300, Ville Syrjälä wrote:
> > +static bool skl_compute_plane_wm(struct skl_pipe_wm_parameters *p,
> > + struct intel_plane_wm_parameters *p_params,
> > + uint16_t max_page_buff_alloc,
> > + uint32_t mem_value,
> > + uint16_t *res_blocks, /* out */
> > + uint8_t *res_lines /* out */)
> > +{
> > + uint32_t method1, method2, plane_bytes_per_line;
> > + uint32_t result_bytes;
> > +
> > + if (!p->active || !p_params->enabled) {
> > + *res_blocks = PLANE_WM_BLOCKS_DEFAULT;
> > + *res_lines = PLANE_WM_LINES_DEFAULT;
>
> Why do we need to set !=0 values for disabled planes?
>
> > + return false;
> > + }

Do you remember why we would program some default numbers of blocks/lines
for disabled planes? Can't find a reason to do so now.

Thanks,

--
Damien