From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH v2 6/8] drm/i915: sanitize rps irq enabling Date: Mon, 17 Nov 2014 21:05:13 +0200 Message-ID: <1416251113.29781.50.camel@intelbox> References: <1415213339-17069-1-git-send-email-imre.deak@intel.com> <1415626865-1828-1-git-send-email-imre.deak@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 7FFB96E204 for ; Mon, 17 Nov 2014 11:05:15 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: Intel Graphics Development , Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMDE0LTExLTE3IGF0IDE2OjQ5IC0wMjAwLCBQYXVsbyBaYW5vbmkgd3JvdGU6Cj4g MjAxNC0xMS0xMCAxMTo0MSBHTVQtMDI6MDAgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29t PjoKPiA+IEF0bSB3ZSBmaXJzdCBlbmFibGUgdGhlIFJQUyBpbnRlcnJ1cHRzIHRoZW4gd2UgY2xl YXIgYW55IHBlbmRpbmcgb25lcy4KPiA+IEJ5IHRoaXMgd2UgY291bGQgbG9zZSBhbiBpbnRlcnJ1 cHQgYXJyaXZpbmcgYWZ0ZXIgd2UgdW5tYXNrZWQgaXQuIFRoaXMKPiA+IG1heSBub3QgYmUgYSBw cm9ibGVtIGFzIHRoZSBjYWxsZXIgc2hvdWxkIGhhbmRsZSBzdWNoIGEgcmFjZSwgYnV0IGxvZ2lj Cj4gPiBzdGlsbCBjYWxscyBmb3IgdGhlIG9wcG9zaXRlIG9yZGVyLiBBbHNvIHdlIGNhbiBkZWxh eSBlbmFibGluZyB0aGUKPiA+IGludGVycnVwdHMgdW50aWwgYWZ0ZXIgYWxsIHRoZSBSUFMgaW5p dGlhbGl6YXRpb24gaXMgcmVhZHkgd2l0aCB0aGUKPiA+IGZvbGxvd2luZyBvcmRlcjoKPiA+Cj4g PiAxLiBjbGVhciBhbnkgcGVuZGluZyBSUFMgaW50ZXJydXB0cwo+ID4gMi4gaW5pdGlhbGl6ZSBS UFMKPiA+IDMuIGVuYWJsZSBSUFMgaW50ZXJydXB0cwo+ID4KPiA+IFRoaXMgYWxzbyBhbGxvd3Mg dXMgdG8gZG8gdGhlIDEuIGFuZCAzLiBzdGVwIHRoZSBzYW1lIHdheSBmb3IgYWxsCj4gPiBwbGF0 Zm9ybXMsIHNvIGxldCdzIGZvbGxvdyB0aGlzIG9yZGVyIHRvIHNpbXBsaWZ5aW5nIHRoaW5ncy4K PiA+Cj4gPiBBbHNvIG1ha2Ugc3VyZSBhbnkgcXVldWVkIGludGVycnVwdHMgYXJlIGFsc28gY2xl YXJlZC4KPiA+Cj4gPiB2MjoKPiA+IC0gcmViYXNlIG9uIHRoZSBHRU45IHBhdGNoZXMgd2hlcmUg d2UgZG9uJ3Qgc3VwcG9ydCBSUFMgeWV0LCBzbyB3ZQo+ID4gICBtdXNuJ3QgZW5hYmxlIFJQUyBp bnRlcnJ1cHRzIG9uIGl0IChQYXVsbykKPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBJbXJlIERlYWsg PGltcmUuZGVha0BpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2lycS5jICB8IDExICsrKysrKysrKystCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHJ2LmggfCAgMSArCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyAgfCAx OSArKysrKysrKysrKy0tLS0tLS0tCj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25z KCspLCA5IGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2lycS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ID4gaW5k ZXggNzI5ZTlhMy4uODlhN2JlMSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfaXJxLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiA+ IEBAIC0yNTUsNiArMjU1LDE2IEBAIHZvaWQgZ2VuNl9kaXNhYmxlX3BtX2lycShzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHVpbnQzMl90IG1hc2spCj4gPiAgICAgICAgIHNuYl91 cGRhdGVfcG1faXJxKGRldl9wcml2LCBtYXNrLCAwKTsKPiA+ICB9Cj4gPgo+ID4gK3ZvaWQgZ2Vu Nl9yZXNldF9ycHNfaW50ZXJydXB0cyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4gK3sKPiA+ ICsgICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJp dmF0ZTsKPiA+ICsKPiA+ICsgICAgICAgc3Bpbl9sb2NrX2lycSgmZGV2X3ByaXYtPmlycV9sb2Nr KTsKPiA+ICsgICAgICAgSTkxNV9XUklURShnZW42X3BtX2lpcihkZXZfcHJpdiksIGRldl9wcml2 LT5wbV9ycHNfZXZlbnRzKTsKPiA+ICsgICAgICAgSTkxNV9XUklURShnZW42X3BtX2lpcihkZXZf cHJpdiksIGRldl9wcml2LT5wbV9ycHNfZXZlbnRzKTsKPiAKPiBXaGF0IGFib3V0IGFkZGluZyBQ T1NUSU5HX1JFQUQoZ2VuNl9wbV9paXIoZGV2X3ByaXYpKSA/Cj4gCj4gKGFsc28gbWF5YmUgdWlu dDMyX3QgcmVnID0gZ2VuNl9wbV9paXIoZGV2X3ByaXYpKQoKT2ssIHdpbGwgZG8uCgo+IAo+ID4g KyAgICAgICBzcGluX3VubG9ja19pcnEoJmRldl9wcml2LT5pcnFfbG9jayk7Cj4gPiArfQo+ID4g Kwo+ID4gIHZvaWQgZ2VuNl9lbmFibGVfcnBzX2ludGVycnVwdHMoc3RydWN0IGRybV9kZXZpY2Ug KmRldikKPiA+ICB7Cj4gPiAgICAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gPiBAQCAtMjYyLDcgKzI3Miw2IEBAIHZvaWQgZ2VuNl9l bmFibGVfcnBzX2ludGVycnVwdHMoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ICAgICAgICAg c3Bpbl9sb2NrX2lycSgmZGV2X3ByaXYtPmlycV9sb2NrKTsKPiA+ICAgICAgICAgV0FSTl9PTihk ZXZfcHJpdi0+cnBzLnBtX2lpcik7Cj4gPiAgICAgICAgIGdlbjZfZW5hYmxlX3BtX2lycShkZXZf cHJpdiwgZGV2X3ByaXYtPnBtX3Jwc19ldmVudHMpOwo+ID4gLSAgICAgICBJOTE1X1dSSVRFKGdl bjZfcG1faWlyKGRldl9wcml2KSwgZGV2X3ByaXYtPnBtX3Jwc19ldmVudHMpOwo+IAo+IFdoYXQg YWJvdXQgYWRkaW5nIFdBUk5fT04oSTkxNV9SRUFEKGdlbjZfcG1faWlyKGRldl9wcml2KSkpID8K ClRoaXMgaXMgbW9yZSBjb21wbGljYXRlZCwgc2luY2UgdGhlIFBNX0lJUiByZWdpc3RlciBoYXMg Yml0cyBvdGhlciB0aGFuClJQUy4gU28gdGhlIFdBUk4gd291bGQgbWFrZXMgc2Vuc2UsIGJ1dCB3 ZSdkIGhhdmUgdG8gY2FsY3VsYXRlIGEgZ2VuCnNwZWNpZmljIG1hc2suIEkgY291bGQgZG8gdGhp cyBhcyBhIGZvbGxvdy11cC4KCj4gCj4gPiAgICAgICAgIHNwaW5fdW5sb2NrX2lycSgmZGV2X3By aXYtPmlycV9sb2NrKTsKPiA+ICB9Cj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+ IGluZGV4IDI0OTkzNDguLmZiMmNmMjcgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcnYuaAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2 LmgKPiA+IEBAIC03ODQsNiArNzg0LDcgQEAgdm9pZCBnZW41X2VuYWJsZV9ndF9pcnEoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1aW50MzJfdCBtYXNrKTsKPiA+ICB2b2lkIGdl bjVfZGlzYWJsZV9ndF9pcnEoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1aW50 MzJfdCBtYXNrKTsKPiA+ICB2b2lkIGdlbjZfZW5hYmxlX3BtX2lycShzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsIHVpbnQzMl90IG1hc2spOwo+ID4gIHZvaWQgZ2VuNl9kaXNhYmxl X3BtX2lycShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHVpbnQzMl90IG1hc2sp Owo+ID4gK3ZvaWQgZ2VuNl9yZXNldF9ycHNfaW50ZXJydXB0cyhzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2KTsKPiA+ICB2b2lkIGdlbjZfZW5hYmxlX3Jwc19pbnRlcnJ1cHRzKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYpOwo+ID4gIHZvaWQgZ2VuNl9kaXNhYmxlX3Jwc19pbnRlcnJ1cHRzKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYpOwo+ID4gIHZvaWQgaW50ZWxfcnVudGltZV9wbV9kaXNhYmxlX2ludGVy cnVwdHMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiA+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfcG0uYwo+ID4gaW5kZXggOGQxNjRiYy4uZjU1NTgxMCAxMDA2NDQKPiA+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3BtLmMKPiA+IEBAIC00NzUzLDggKzQ3NTMsNiBAQCBzdGF0aWMgdm9pZCBnZW44 X2VuYWJsZV9ycHMoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+Cj4gPiAgICAgICAgIGdlbjZf c2V0X3JwcyhkZXYsIChJOTE1X1JFQUQoR0VONl9HVF9QRVJGX1NUQVRVUykgJiAweGZmMDApID4+ IDgpOwo+ID4KPiA+IC0gICAgICAgZ2VuNl9lbmFibGVfcnBzX2ludGVycnVwdHMoZGV2KTsKPiA+ IC0KPiA+ICAgICAgICAgZ2VuNl9ndF9mb3JjZV93YWtlX3B1dChkZXZfcHJpdiwgRk9SQ0VXQUtF X0FMTCk7Cj4gPiAgfQo+ID4KPiA+IEBAIC00ODUxLDggKzQ4NDksNiBAQCBzdGF0aWMgdm9pZCBn ZW42X2VuYWJsZV9ycHMoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ICAgICAgICAgZGV2X3By aXYtPnJwcy5wb3dlciA9IEhJR0hfUE9XRVI7IC8qIGZvcmNlIGEgcmVzZXQgKi8KPiA+ICAgICAg ICAgZ2VuNl9zZXRfcnBzKGRldl9wcml2LT5kZXYsIGRldl9wcml2LT5ycHMubWluX2ZyZXFfc29m dGxpbWl0KTsKPiA+Cj4gPiAtICAgICAgIGdlbjZfZW5hYmxlX3Jwc19pbnRlcnJ1cHRzKGRldik7 Cj4gPiAtCj4gPiAgICAgICAgIHJjNnZpZHMgPSAwOwo+ID4gICAgICAgICByZXQgPSBzYW5keWJy aWRnZV9wY29kZV9yZWFkKGRldl9wcml2LCBHRU42X1BDT0RFX1JFQURfUkM2VklEUywgJnJjNnZp ZHMpOwo+ID4gICAgICAgICBpZiAoSVNfR0VONihkZXYpICYmIHJldCkgewo+ID4gQEAgLTUzNDQs OCArNTM0MCw2IEBAIHN0YXRpYyB2b2lkIGNoZXJyeXZpZXdfZW5hYmxlX3JwcyhzdHJ1Y3QgZHJt X2RldmljZSAqZGV2KQo+ID4KPiA+ICAgICAgICAgdmFsbGV5dmlld19zZXRfcnBzKGRldl9wcml2 LT5kZXYsIGRldl9wcml2LT5ycHMuZWZmaWNpZW50X2ZyZXEpOwo+ID4KPiA+IC0gICAgICAgZ2Vu Nl9lbmFibGVfcnBzX2ludGVycnVwdHMoZGV2KTsKPiA+IC0KPiA+ICAgICAgICAgZ2VuNl9ndF9m b3JjZV93YWtlX3B1dChkZXZfcHJpdiwgRk9SQ0VXQUtFX0FMTCk7Cj4gPiAgfQo+ID4KPiA+IEBA IC01NDI0LDggKzU0MTgsNiBAQCBzdGF0aWMgdm9pZCB2YWxsZXl2aWV3X2VuYWJsZV9ycHMoc3Ry dWN0IGRybV9kZXZpY2UgKmRldikKPiA+Cj4gPiAgICAgICAgIHZhbGxleXZpZXdfc2V0X3Jwcyhk ZXZfcHJpdi0+ZGV2LCBkZXZfcHJpdi0+cnBzLmVmZmljaWVudF9mcmVxKTsKPiA+Cj4gPiAtICAg ICAgIGdlbjZfZW5hYmxlX3Jwc19pbnRlcnJ1cHRzKGRldik7Cj4gPiAtCj4gPiAgICAgICAgIGdl bjZfZ3RfZm9yY2Vfd2FrZV9wdXQoZGV2X3ByaXYsIEZPUkNFV0FLRV9BTEwpOwo+ID4gIH0KPiA+ Cj4gPiBAQCAtNjIzOSw2ICs2MjMxLDEzIEBAIHN0YXRpYyB2b2lkIGludGVsX2dlbjZfcG93ZXJz YXZlX3dvcmsoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ID4KPiA+ICAgICAgICAgbXV0ZXhf bG9jaygmZGV2X3ByaXYtPnJwcy5od19sb2NrKTsKPiA+Cj4gPiArICAgICAgIC8qCj4gPiArICAg ICAgICAqIFRPRE86IHJlc2V0L2VuYWJsZSBSUFMgaW50ZXJydXB0cyBvbiBHRU45IHRvbywgb25j ZSBSUFMgc3VwcG9ydCBpcwo+ID4gKyAgICAgICAgKiBhZGRlZCBmb3IgaXQuCj4gPiArICAgICAg ICAqLwo+ID4gKyAgICAgICBpZiAoSU5URUxfSU5GTyhkZXYpLT5nZW4gIT0gOSkKPiA+ICsgICAg ICAgICAgICAgICBnZW42X3Jlc2V0X3Jwc19pbnRlcnJ1cHRzKGRldik7Cj4gCj4gSSBzZWUgdGhh dCBpbiB0aGlzIHNlcmllcyB5b3UncmUgdXNpbmcgImdlbiAhPSA5IiBjaGVja3MsIGJ1dCBJJ2QK PiBjaGFuZ2UgdGhlbSB0byAiZ2VuIDwgOSIsIGp1c3QgaW4gY2FzZS4uLgoKWWVwLCBtYWtlcyBz ZW5zZS4gSSdsbCB1cGRhdGUgdGhlbiB0aGUgV0FSTiBpbiB0aGUgSVJRIGhhbmRsZXIgdG9vCmFj Y29yZGluZ2x5LgoKPiAKPiA+ICsKPiA+ICAgICAgICAgaWYgKElTX0NIRVJSWVZJRVcoZGV2KSkg ewo+ID4gICAgICAgICAgICAgICAgIGNoZXJyeXZpZXdfZW5hYmxlX3JwcyhkZXYpOwo+ID4gICAg ICAgICB9IGVsc2UgaWYgKElTX1ZBTExFWVZJRVcoZGV2KSkgewo+ID4gQEAgLTYyNTMsNiArNjI1 MiwxMCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9nZW42X3Bvd2Vyc2F2ZV93b3JrKHN0cnVjdCB3b3Jr X3N0cnVjdCAqd29yaykKPiA+ICAgICAgICAgICAgICAgICBfX2dlbjZfdXBkYXRlX3JpbmdfZnJl cShkZXYpOwo+ID4gICAgICAgICB9Cj4gPiAgICAgICAgIGRldl9wcml2LT5ycHMuZW5hYmxlZCA9 IHRydWU7Cj4gPiArCj4gPiArICAgICAgIGlmIChJTlRFTF9JTkZPKGRldiktPmdlbiAhPSA5KQo+ ID4gKyAgICAgICAgICAgICAgIGdlbjZfZW5hYmxlX3Jwc19pbnRlcnJ1cHRzKGRldik7Cj4gPiAr Cj4gPiAgICAgICAgIG11dGV4X3VubG9jaygmZGV2X3ByaXYtPnJwcy5od19sb2NrKTsKPiA+Cj4g PiAgICAgICAgIGludGVsX3J1bnRpbWVfcG1fcHV0KGRldl9wcml2KTsKPiA+IC0tCj4gPiAxLjgu NAo+ID4KPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cj4gCj4gCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK