Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

From: "Xiang, Haihao" <haihao.xiang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Kenneth Graunke <kenneth-xkhwgxqQjnbNLxjTenLetw@public.gmane.org>
Cc: intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	"libva-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<libva-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.
Date: Tue, 06 Jan 2015 15:00:12 +0800	[thread overview]
Message-ID: <1420527612.2355.82.camel@xhh-u64> (raw)
In-Reply-To: <1420526376.2355.77.camel@xhh-u64>

On Tue, 2015-01-06 at 14:39 +0800, Xiang, Haihao wrote:
> On Mon, 2015-01-05 at 21:54 -0800, Kenneth Graunke wrote:
> > On Tuesday, January 06, 2015 01:11:53 PM Xiang, Haihao wrote:
> > > 
> > > Hi Kenneth,
> > > 
> > > How did you test OSD ? I can't reproduce the issue you mentioned, OSD
> > > works well for me when using mplayer-vaapi with the latest
> > > libva/libva-intel-driver master branch.
> > > 
> > > I tried your patch, what surprised me is OSD still works well after
> > > applying your patch. It seems your patch didn't disable the palette.
> > > 
> > > Thanks
> > > Haihao
> > 
> > I ran:
> > 
> > mplayer -osdlevel 3 -vo vaapi big_buck_bunny_720p_stereo.ogg
> > 
> > For me, the OSD text is solid green, with hard edges.
> 
> The OSD text is white for me when using mplayer -osdlevel 3 -vo vaapi
> xxx. If possible, could you update your mplayer ?
> 
> > 
> > If you use "-vo gl" or "-vo xv", the OSD is solid white text with a black
> > border around it.  I presume that it's supposed to be white with vaapi as
> > well, but I guess I'm not entirely sure.
> > 
> > It's possible that the optimization doesn't affect the palette as long as
> > you never use sample_c with the paletted textures.
> 
> 
> I verified the palette takes effect in the following way:
> 
> 1. Only support P8A8 format in the driver
> 
> 2. ran the above command and I saw white OSD text
> 
> 3. Only support P4A4 format in the driver and don't use
> 3DSTATE_SAMPLER_PALETTE_LOAD0 to load the value to the texture palette,
> so the palette keeps unchanged. 
> 
> 4. ran the above command and I saw black OSD text.
> 
> 5. Load the right value to the texture palette and ran the above command
> again, I saw white OSD text.
> 
> Hence I think sample_c with the paletted textures is used in the driver.

Sorry, libva driver doesn't use sample_c message, I mean the paletted
texture is used.  However corroding to the doc, Palette is disabled for
fast mode.

> 
> > 
> > --Ken
> 
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Libva mailing list
Libva@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libva