From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 5/5] drm/irq: Don't call ->get_vblank_counter directly from irq_uninstall/cleanup Date: Tue, 17 Feb 2015 15:42:07 +0200 Message-ID: <1424180527.6914.6.camel@intel.com> References: <1423857826-11048-1-git-send-email-daniel.vetter@ffwll.ch> <1423857826-11048-5-git-send-email-daniel.vetter@ffwll.ch> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1423857826-11048-5-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: intel-gfx@lists.freedesktop.org T24gcGUsIDIwMTUtMDItMTMgYXQgMjE6MDMgKzAxMDAsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4g VGhlIHBpcGUgbWlnaHQgYWxyZWFkeSBoYXZlIGJlZW4gc2h1dCBkb3duLCBhbmQgdGhlbiBpdCdz IG5vdCBhIGdvb2QKPiBpZGVhIHRvIGNhbGwgaHcgYWNjZXNzb3IgZnVuY3Rpb25zLiBJbnN0ZWFk IHVzZSB0aGUgc2FtZSBsb2dpYyBhcwo+IGRybV92Ymxhbmtfb2ZmIHdoaWNoIGhhcyBhbGwgdGhl IG5lY2Vzc2FyeSBjaGVja3MgdG8gYXZvaWQgdHJvdWJsZXMgb3IKPiBpbmNvbnNpc3RlbmN5Lgo+ IAo+IE5vdGljZWQgYnkgSW1yZSB3aGlsZSByZXZpZXdpbmcgbXkgcGF0Y2hlcyB0byByZW1vdmUg c29tZSBzYW5pdHkKPiBjaGVja3MgZnJvbSAtPmdldF92YmxhbmtfY291bnRlci4KPiAKPiB2Mjog VHJ5IGhhcmRlci4gZGlzYWJsZV9hbmRfc2F2ZSBjYW4gc3RpbGwgYWNjZXNzIHRoZSB2Ymxhbmsg c3R1ZmYKPiB3aGVuIHZibGFuay0+ZW5hYmxlZCBpc24ndCBzZXQuIEl0IGhhcyB0bywgc2luY2Ug dmxiYW5rIGlycSBjb3VsZCBiZQo+IGRpc2FibGUgYnV0IHRoZSBwaXBlIGlzIHN0aWxsIG9uIHdo ZW4gYmVpbmcgY2FsbGVkIGZyb20KPiBkcm1fdmJsYW5rX29mZi4gQnV0IHdlIHN0aWxsIHdhbnQg dG8gdXNlIHRoYXQgY29kZSBmb3IgbW9yZSBjb2RlCj4gc2hhcmluZy4gU28gYWRkIGEgY2hlY2sg Zm9yIHZibGFuay0+ZW5hYmxlZCBvbiB0b3AgLSBpZiB0aGF0J3Mgbm90IHNldAo+IHdlIHNob3Vs ZG4ndCBoYXZlIGFueW9uZSB3YWl0aW5nIGZvciB0aGUgdmJsYW5rLiBJZiB3ZSBoYXZlIHRoYXQn cyBhCj4gcHJldHR5IHNlcmlvdXMgYnVnLgo+IAo+IFRoZSBvdGhlciBpc3N1ZSB0aGF0IEltcmUg c3BvdHRlZCBpcyBkcm1fdmJsYW5rX2NsZWFudXAuIFRoYXQgY29kZQo+IGFnYWluIGNhbGxzIGRp c2FibGVfYW5kX3NhdmUgYW5kIHNvIHN1ZmZlcnMgZnJvbSB0aGUgc2FtZSBpc3N1ZXMuIEJ1dAo+ IHJlYWxseSBkcm1faXJxX3VuaW5zdGFsbCBzaG91bGQgaGF2ZSBjbGVhbmVkIHRoYXQgYWxsIHVw LCBzbyByZXBsYWNlCj4gdGhlIGNvZGUgd2l0aCBXQVJOX09OLiBOb3RlIHRoYXQgd2UgY2FuJ3Qg ZGVsZXRlIHRoZSB0aW1lciBjbGVhbnVwCj4gc2luY2UgZHJpdmVycyBhcmVuJ3QgcmVxdWlyZWQg dG8gdXNlIGRybV9pcnFfaW5zdGFsbC91bmluc3RhbGwsIGJ1dAo+IGNhbiBkbyB0aGVpciBvd24g aXJxIGhhbmRsaW5nLgo+IAo+IHYzOiBNYWtlIGl0IGNsZWFyIHRoYXQgYWxsIHRoYXQgZ3VuayBp biBkcm1faXJxX3VuaW5zdGFsbCBpcyByZWFsbHkKPiBqdXN0IGJhbmRhaWRzIGZvciBVTVMgcmFj ZXMgYmV0d2VlbiB0aGUgaXJxL3ZibGFuayBjb2RlLiBJbiBVTVMKPiB1c2Vyc3BhY2UgaXMgaW4g Y29udHJvbCBvZiBlbmFibGluZy9kaXNhYmxpbmcgaW50ZXJydXB0cyBpbiBnZW5lcmFsCj4gYW5k IHZibGFua3Mgc3BlY2lmaWNhbGx5Lgo+IAo+IENjOiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRl bC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRl bC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMgfCAyMSArKysrKysrKysr KystLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDkgZGVsZXRp b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMgYi9kcml2 ZXJzL2dwdS9kcm0vZHJtX2lycS5jCj4gaW5kZXggMWU1ZmIxYjk5NGQ3Li44ODVmYjc1NmZlZDUg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9pcnEuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9kcm1faXJxLmMKPiBAQCAtMjY5LDcgKzI2OSw2IEBAIHN0YXRpYyB2b2lkIHZibGFu a19kaXNhYmxlX2ZuKHVuc2lnbmVkIGxvbmcgYXJnKQo+ICB2b2lkIGRybV92YmxhbmtfY2xlYW51 cChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICB7Cj4gIAlpbnQgY3J0YzsKPiAtCXVuc2lnbmVk IGxvbmcgaXJxZmxhZ3M7Cj4gIAo+ICAJLyogQmFpbCBpZiB0aGUgZHJpdmVyIGRpZG4ndCBjYWxs IGRybV92YmxhbmtfaW5pdCgpICovCj4gIAlpZiAoZGV2LT5udW1fY3J0Y3MgPT0gMCkKPiBAQCAt Mjc4LDExICsyNzcsOSBAQCB2b2lkIGRybV92YmxhbmtfY2xlYW51cChzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2KQo+ICAJZm9yIChjcnRjID0gMDsgY3J0YyA8IGRldi0+bnVtX2NydGNzOyBjcnRjKysp IHsKPiAgCQlzdHJ1Y3QgZHJtX3ZibGFua19jcnRjICp2YmxhbmsgPSAmZGV2LT52YmxhbmtbY3J0 Y107Cj4gIAo+IC0JCWRlbF90aW1lcl9zeW5jKCZ2YmxhbmstPmRpc2FibGVfdGltZXIpOwo+ICsJ CVdBUk5fT04odmJsYW5rLT5lbmFibGVkKTsKPiAgCj4gLQkJc3Bpbl9sb2NrX2lycXNhdmUoJmRl di0+dmJsX2xvY2ssIGlycWZsYWdzKTsKPiAtCQl2YmxhbmtfZGlzYWJsZV9hbmRfc2F2ZShkZXYs IGNydGMpOwo+IC0JCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmRldi0+dmJsX2xvY2ssIGlycWZs YWdzKTsKPiArCQlkZWxfdGltZXJfc3luYygmdmJsYW5rLT5kaXNhYmxlX3RpbWVyKTsKPiAgCX0K Ckxvb2tpbmcgYWxzbyBhdCBub24taTkxNSBkcml2ZXJzLCBkcm1fdmJsYW5rX2NsZWFudXAgaXMg Y2FsbGVkIGFsd2F5cwpiZWZvcmUgZHJtX2lycV91bmluc3RhbGwuIER1ZSB0byAnZGV2LT5udW1f Y3J0Y3MgPSAwJyBpbgpkcm1fdmJsYW5rX2NsZWFudXAgdGhlIGxvb3AgaW4gZHJtX2lycV91bmlu c3RhbGwgd2lsbCBiZSBieXBhc3NlZCBhbmQKdmJsYW5rX2Rpc2FibGVfYW5kX3NhdmUgd29uJ3Qg YmUgY2FsbGVkLiBUaGlzIGlzIG1haW5seSBhIGNvbmNlcm4gZm9yClVNUyBhcyB5b3UgY29tbWVu dGVkIGJlbG93LCBidXQgaWYgd2UgY2FyZSBhYm91dCB0aGF0IEknZCBwcmVmZXIgZG9pbmcKdGhl IHNhbWUgdGhpbmcgYWJvdmUgYXMgeW91IGRpZCBpbiBkcm1faXJxX3VuaW5zdGFsbC4gRG9uJ3Qg ZG8gYW55dGhpbmcKaWYgdmJsYW5rcyBhcmUgZGlzYWJsZWQgb3RoZXJ3aXNlIHdhcm4gb25seSBm b3IgS01TIGFuZCBjYWxsCnZibGFua19kaXNhYmxlX2FuZF9zYXZlIGFuZCB3YWtlX3VwIHRoZSB2 YmxhbmsgcXVldWUuCgpXaXRoIHRoYXQgdGhpcyBzZXJpZXMgbG9va3Mgb2sgdG8gbWUuCgo+ICAK PiAgCWtmcmVlKGRldi0+dmJsYW5rKTsKPiBAQCAtNDY4LDE3ICs0NjUsMjMgQEAgaW50IGRybV9p cnFfdW5pbnN0YWxsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIAlkZXYtPmlycV9lbmFibGVk ID0gZmFsc2U7Cj4gIAo+ICAJLyoKPiAtCSAqIFdha2UgdXAgYW55IHdhaXRlcnMgc28gdGhleSBk b24ndCBoYW5nLgo+ICsJICogV2FrZSB1cCBhbnkgd2FpdGVycyBzbyB0aGV5IGRvbid0IGhhbmcu IFRoaXMgaXMganVzdCB0byBwYXBlciBvdmVyCj4gKwkgKiBpc3NzdWVzIGZvciBVTVMgZHJpdmVy cyB3aGljaCBhcmVuJ3QgaW4gZnVsbCBjb250cm9sIG9mIHRoZWlyCj4gKwkgKiB2YmxhbmsvaXJx IGhhbmRsaW5nLiBLTVMgZHJpdmVycyBtdXN0IGVuc3VyZSB0aGF0IHZibGFua3MgYXJlIGFsbAo+ ICsJICogZGlzYWJsZWQgd2hlbiB1bmluc3RhbGxpbmcgdGhlIGlycSBoYW5kbGVyLgo+ICAJICov Cj4gIAlpZiAoZGV2LT5udW1fY3J0Y3MpIHsKPiAgCQlzcGluX2xvY2tfaXJxc2F2ZSgmZGV2LT52 YmxfbG9jaywgaXJxZmxhZ3MpOwo+ICAJCWZvciAoaSA9IDA7IGkgPCBkZXYtPm51bV9jcnRjczsg aSsrKSB7Cj4gIAkJCXN0cnVjdCBkcm1fdmJsYW5rX2NydGMgKnZibGFuayA9ICZkZXYtPnZibGFu a1tpXTsKPiAgCj4gKwkJCWlmICghdmJsYW5rLT5lbmFibGVkKQo+ICsJCQkJY29udGludWU7Cj4g Kwo+ICsJCQlXQVJOX09OKGRybV9jb3JlX2NoZWNrX2ZlYXR1cmUoZGV2LCBEUklWRVJfTU9ERVNF VCkpOwo+ICsKPiArCQkJdmJsYW5rX2Rpc2FibGVfYW5kX3NhdmUoZGV2LCBpKTsKPiAgCQkJd2Fr ZV91cCgmdmJsYW5rLT5xdWV1ZSk7Cj4gLQkJCXZibGFuay0+ZW5hYmxlZCA9IGZhbHNlOwo+IC0J CQl2YmxhbmstPmxhc3QgPQo+IC0JCQkJZGV2LT5kcml2ZXItPmdldF92YmxhbmtfY291bnRlcihk ZXYsIGkpOwo+ICAJCX0KPiAgCQlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZkZXYtPnZibF9sb2Nr LCBpcnFmbGFncyk7Cj4gIAl9CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK