From: Imre Deak <imre.deak@intel.com>
To: David Weinehall <david.weinehall@intel.com>
Cc: "intel-gf >> Intel Graphics Development"
<intel-gfx@lists.freedesktop.org>
Subject: Re: Hibernation test
Date: Wed, 18 Feb 2015 18:43:55 +0200 [thread overview]
Message-ID: <1424277835.27236.3.camel@intel.com> (raw)
In-Reply-To: <54DB6B2A.3040503@intel.com>
On ke, 2015-02-11 at 16:46 +0200, David Weinehall wrote:
> intel-gpu-tools currently has a bunch of tests for suspend,
> but currently none (that I could find) for hibernate.
>
> Attached is a rudimentary patch to add said test. It does so
> by repurposing the drv_suspend driver to handle both suspend
> and hibernate, since the difference is miniscule.
>
> I decided to split the suspend/autoresume functions in
> igt_aux.c though, to be able to leave the igt_system_uspend_autoresume()
> function unchanged (the other option would be to
> introduce a boolean function argument and have that
> decide what parameters to pass to rtcwake).
>
> The timeout passed to rtcwake probably needs tuning (it might
> even need to be dynamically adjusted, since the time hibernation takes
> varies wildly depending on the amount of non-cache memory in use).
I think in general we should try to keep the existing subtest names, but
I couldn't find any concrete problem changing them in this case. The
patch looks ok to me (please inline the patch next time):
Reviewed-by: Imre Deak <imre.deak@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-18 16:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 14:46 Hibernation test David Weinehall
2015-02-18 16:43 ` Imre Deak [this message]
2015-02-24 16:39 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424277835.27236.3.camel@intel.com \
--to=imre.deak@intel.com \
--cc=david.weinehall@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox