public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Marc Herbert <marc.herbert@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Marc Herbert <marc.herbert@intel.com>
Subject: [PATCH i-g-t] lib/igt_kms.c: igt_require -> igt_require_f("two displays required\n")
Date: Thu, 26 Feb 2015 18:43:43 -0800	[thread overview]
Message-ID: <1425005023-5041-1-git-send-email-marc.herbert@intel.com> (raw)

The bare "Test requirement: modes" message is too cryptic, I had to go and
read the source code to understand the missing requirement.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
---

If there is a different message that you would like to push yourself
then please don't mind me - I think ANY message would do.

 tests/kms_flip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index b843478..cae02e9 100644
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1544,7 +1544,7 @@ static int run_pair(int duration, int flags)
 
 	/* If we have fewer than 2 connected outputs then we won't have any
 	 * configuration at all. So skip in that case. */
-	igt_require(modes);
+	igt_require_f(modes, "At least two displays required\n");
 	duration = duration * 1000 / modes;
 	duration = max(duration, 500);
 
-- 
1.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2015-02-27  2:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-27  2:43 Marc Herbert [this message]
2015-02-27 15:06 ` [PATCH i-g-t] lib/igt_kms.c: igt_require -> igt_require_f("two displays required\n") Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425005023-5041-1-git-send-email-marc.herbert@intel.com \
    --to=marc.herbert@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox