public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Kumar, Shobhit" <shobhit.kumar@intel.com>
To: "linus.walleij@linaro.org" <linus.walleij@linaro.org>
Cc: "Lu, Aaron" <aaron.lu@intel.com>,
	"gnurou@gmail.com" <gnurou@gmail.com>,
	"Nikula, Jani" <jani.nikula@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
	"Vetter, Daniel" <daniel.vetter@intel.com>,
	"lejun.zhu@linux.intel.com" <lejun.zhu@linux.intel.com>
Subject: Re: [PATCH 1/2] gpio/crystalcove: Export Panel and backlight en/disable signals as GPIO
Date: Thu, 12 Mar 2015 15:06:06 +0000	[thread overview]
Message-ID: <1426172763.9077.47.camel@intel.com> (raw)
In-Reply-To: <CACRpkdaqufO7VHTZrNrVvxpqeHQP2aE_e2kQbZkx4Y7jEd-ziQ@mail.gmail.com>

On Mon, 2015-03-09 at 18:15 +0100, Linus Walleij wrote:
> On Fri, Mar 6, 2015 at 5:23 PM, Kumar, Shobhit <shobhit.kumar@intel.com> wrote:
> 
> > There are actually two lines for Panel Power control and Backlight
> > enable/disable. I have already moved towards adding a new Cell device
> > for PWM child device and a new pwm driver for the same. That will take
> > care of backlight thingy. But for the Panel power control, I am at loss
> > for how best to program that.
> 
> Isn't it just a very simple regulator (just on/off of fixed voltage) cell?
> 

It is just behaving as an output GPIO line and for that reason I feel
that rather than adding a new regulator driver, it is better to augment
the gpio-crystalcove driver. I am planning to export as GPIO from PMIC
MFD driver by way of lookup table and use in display side. Will send RFC
patch soon.

Backlight control as I said is a new pwm cell.

Regards
Shobhit

> Yours,
> Linus Walleij

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-03-12 15:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18 12:18 [PATCH 0/2] Crystal Cove PMIC based Panel Control Shobhit Kumar
2015-02-18 12:18 ` [PATCH 1/2] gpio/crystalcove: Export Panel and backlight en/disable signals as GPIO Shobhit Kumar
2015-03-06 11:04   ` Linus Walleij
2015-03-06 16:23     ` Kumar, Shobhit
2015-03-09 17:15       ` Linus Walleij
2015-03-12 15:06         ` Kumar, Shobhit [this message]
2015-03-18 11:50           ` Linus Walleij
2015-03-18 13:27             ` Daniel Vetter
2015-03-24  9:50               ` Linus Walleij
2015-03-25 12:27   ` Linus Walleij
2015-03-25 14:15     ` Kumar, Shobhit
2015-03-25 14:39       ` Linus Walleij
2015-02-18 12:18 ` [PATCH 2/2] drm/i915: Use the CRC gpio_chip for panel enable/disable Shobhit Kumar
2015-02-26 10:13   ` Alexandre Courbot
2015-03-01 13:24     ` Kumar, Shobhit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426172763.9077.47.camel@intel.com \
    --to=shobhit.kumar@intel.com \
    --cc=aaron.lu@intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=gnurou@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=lejun.zhu@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox