From: Ander Conselvan De Oliveira <conselvan2@gmail.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix sink crc connector iteration
Date: Mon, 16 Mar 2015 09:19:41 +0200 [thread overview]
Message-ID: <1426490381.3286.4.camel@gmail.com> (raw)
In-Reply-To: <1426288439-7668-1-git-send-email-rodrigo.vivi@intel.com>
On Fri, 2015-03-13 at 16:13 -0700, Rodrigo Vivi wrote:
> Regressed by this commit:
>
> commit 3455454e18ca3f92c565700539e744c620d8276b
> Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Date: Tue Mar 3 15:21:56 2015 +0200
>
> drm/i915: Add a for_each_intel_connector macro
>
> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 1f7ec06..daf948e 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2305,7 +2305,7 @@ static int i915_sink_crc(struct seq_file *m, void *data)
> u8 crc[6];
>
> drm_modeset_lock_all(dev);
> - for_each_intel_encoder(dev, connector) {
> + for_each_intel_connector(dev, connector) {
>
> if (connector->base.dpms != DRM_MODE_DPMS_ON)
> continue;
Yeah, oops.
Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-16 7:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 23:13 [PATCH] drm/i915: Fix sink crc connector iteration Rodrigo Vivi
2015-03-14 7:08 ` shuang.he
2015-03-16 7:19 ` Ander Conselvan De Oliveira [this message]
2015-03-16 7:21 ` [PATCH] drm/i915: Make for_each_intel_* macros typesafe Ander Conselvan de Oliveira
2015-03-16 9:38 ` shuang.he
2015-03-16 10:00 ` Jani Nikula
2015-03-16 10:42 ` Chris Wilson
2015-03-16 12:51 ` Ander Conselvan de Oliveira
2015-03-16 17:24 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426490381.3286.4.camel@gmail.com \
--to=conselvan2@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox