Re: [PATCH i-g-t 2/3] lib/kms: Add nuclear pageflip commit style

[Ander Conselvan De Oliveira <conselvan2@gmail.com>]

On Mon, 2015-01-19 at 20:05 -0800, Matt Roper wrote:
> This commit style only covers the "nuclear pageflip" subset of the
> atomic API (i.e., single CRTC, plane updates only).  In the future when
> our kernel driver has full atomic modeset support, we'll add another
> commit style 'atomic' which will re-use the same plane commit calls
> added here, but will generate and commit property sets in the display's
> commit handler rather than the output's commit handler.
> 
> Since nuclear pageflip (and full atomic eventually) depend on very new
> (currently unreleased) libdrm, use autoconf to check for support so that
> we can still run with just legacy + universal styles when built with
> older libdrm's.
> 
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>  configure.ac  |   3 ++
>  lib/igt_kms.c | 169 ++++++++++++++++++++++++++++++++++++++++++++++++++++++----
>  lib/igt_kms.h |  19 ++++++-
>  3 files changed, 181 insertions(+), 10 deletions(-)

[...]

> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index a1483a4..2fab30e 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h

[...]

> @@ -216,6 +227,11 @@ typedef struct {
>  	char *name;
>  	bool valid;
>  	unsigned long pending_crtc_idx_mask;
> +
> +#ifdef HAVE_ATOMIC
> +	/* Property set for nuclear pageflip */
> +	drmModePropertySetPtr set;
> +#endif
>  } igt_output_t;

Need to include config.h in the header file, otherwise code that depends
on the size of igt_output_t on the tests might do the wrong thing.

Ander

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx