From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH 2/7] drm/i915: Use GGTT view when (un)pinning objects to planes Date: Wed, 18 Mar 2015 15:52:31 +0200 Message-ID: <1426686751.3473.7.camel@jlahtine-mobl1> References: <1426607117-10626-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1426607117-10626-3-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id ED5586E832 for ; Wed, 18 Mar 2015 06:52:33 -0700 (PDT) In-Reply-To: <1426607117-10626-3-git-send-email-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gdGksIDIwMTUtMDMtMTcgYXQgMTU6NDUgKzAwMDAsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+ IEZyb206IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gCj4gVG8g c3VwcG9ydCBmcmFtZSBidWZmZXIgcm90YXRpb24gd2UgbmVlZCB0byBiZSBhYmxlIHRvIHBhc3Mg b24gdGhlIGluZm9ybWF0aW9uCj4gb24gd2hhdCBraW5kIG9mIEdHVFQgdmlldyBpcyByZXF1aXJl ZCBmb3IgZGlzcGxheS4KPiAKPiBUaGlzIHBhdGNoIGp1c3QgYWRkcyB0aGUgcGFyYW1ldGVyIGFu ZCBtYWtlcyBhbGwgdGhlIGNhbGxlcnMgZGVmYXVsdCB0byB0aGUKPiBub3JtYWwgdmlldy4KPiAK PiB2MjogUmViYXNlZCBmb3IgZ2d0dCB2aWV3IGNoYW5nZXMuCj4gCj4gU2lnbmVkLW9mZi1ieTog VHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiBDYzogSm9vbmFzIExh aHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAgfCAxNCArKysrKysrKysrKy0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICAgfCAyMiArKysrKysrKysrKysrKy0tLS0t LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8ICA3ICsrKystLS0K PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfb3ZlcmxheS5jIHwgIDMgKystCj4gIDQgZmls ZXMgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggODFmNjBiNC4uMTliOWU2OSAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kcnYuaAo+IEBAIC0yNzcyLDggKzI3NzIsMTAgQEAgaTkxNV9nZW1fb2JqZWN0X3Nl dF90b19jcHVfZG9tYWluKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosIGJvb2wgd3Jp dGUpOwo+ICBpbnQgX19tdXN0X2NoZWNrCj4gIGk5MTVfZ2VtX29iamVjdF9waW5fdG9fZGlzcGxh eV9wbGFuZShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+ICAJCQkJICAgICB1MzIg YWxpZ25tZW50LAo+IC0JCQkJICAgICBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpwaXBlbGluZWQp Owo+IC12b2lkIGk5MTVfZ2VtX29iamVjdF91bnBpbl9mcm9tX2Rpc3BsYXlfcGxhbmUoc3RydWN0 IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaik7Cj4gKwkJCQkgICAgIHN0cnVjdCBpbnRlbF9lbmdp bmVfY3MgKnBpcGVsaW5lZCwKPiArCQkJCSAgICAgY29uc3Qgc3RydWN0IGk5MTVfZ2d0dF92aWV3 ICp2aWV3KTsKPiArdm9pZCBpOTE1X2dlbV9vYmplY3RfdW5waW5fZnJvbV9kaXNwbGF5X3BsYW5l KHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gKwkJCQkJICAgICAgY29uc3Qgc3Ry dWN0IGk5MTVfZ2d0dF92aWV3ICp2aWV3KTsKPiAgaW50IGk5MTVfZ2VtX29iamVjdF9hdHRhY2hf cGh5cyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+ICAJCQkJaW50IGFsaWduKTsK PiAgaW50IGk5MTVfZ2VtX29wZW4oc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9m aWxlICpmaWxlKTsKPiBAQCAtMjg4Miw3ICsyODg0LDEzIEBAIGk5MTVfZ2VtX29iamVjdF9nZ3R0 X3VuYmluZChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQo+ICAJcmV0dXJuIGk5MTVf dm1hX3VuYmluZChpOTE1X2dlbV9vYmpfdG9fZ2d0dChvYmopKTsKPiAgfQo+ICAKPiAtdm9pZCBp OTE1X2dlbV9vYmplY3RfZ2d0dF91bnBpbihzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2Jq KTsKPiArdm9pZCBpOTE1X2dlbV9vYmplY3RfZ2d0dF91bnBpbl92aWV3KHN0cnVjdCBkcm1faTkx NV9nZW1fb2JqZWN0ICpvYmosCj4gKwkJCQkgICAgIGNvbnN0IHN0cnVjdCBpOTE1X2dndHRfdmll dyAqdmlldyk7Cj4gK3N0YXRpYyBpbmxpbmUgdm9pZAo+ICtpOTE1X2dlbV9vYmplY3RfZ2d0dF91 bnBpbihzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQo+ICt7Cj4gKwlpOTE1X2dlbV9v YmplY3RfZ2d0dF91bnBpbl92aWV3KG9iaiwgJmk5MTVfZ2d0dF92aWV3X25vcm1hbCk7Cj4gK30K PiAgCj4gIC8qIGk5MTVfZ2VtX2NvbnRleHQuYyAqLwo+ICBpbnQgX19tdXN0X2NoZWNrIGk5MTVf Z2VtX2NvbnRleHRfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtLmMKPiBpbmRleCA1MzNlZjM3Li41ODcyM2EzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jCj4gQEAgLTM5NTcsNyArMzk1Nyw4IEBAIHN0YXRpYyBib29sIGlzX3Bpbl9kaXNwbGF5 KHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmopCj4gIGludAo+ICBpOTE1X2dlbV9vYmpl Y3RfcGluX3RvX2Rpc3BsYXlfcGxhbmUoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwK PiAgCQkJCSAgICAgdTMyIGFsaWdubWVudCwKPiAtCQkJCSAgICAgc3RydWN0IGludGVsX2VuZ2lu ZV9jcyAqcGlwZWxpbmVkKQo+ICsJCQkJICAgICBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpwaXBl bGluZWQsCj4gKwkJCQkgICAgIGNvbnN0IHN0cnVjdCBpOTE1X2dndHRfdmlldyAqdmlldykKPiAg ewo+ICAJdTMyIG9sZF9yZWFkX2RvbWFpbnMsIG9sZF93cml0ZV9kb21haW47Cj4gIAlib29sIHdh c19waW5fZGlzcGxheTsKPiBAQCAtMzk5Myw3ICszOTk0LDkgQEAgaTkxNV9nZW1fb2JqZWN0X3Bp bl90b19kaXNwbGF5X3BsYW5lKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gIAkg KiAoZS5nLiBsaWJrbXMgZm9yIHRoZSBib290dXAgc3BsYXNoKSwgd2UgaGF2ZSB0byBlbnN1cmUg dGhhdCB3ZQo+ICAJICogYWx3YXlzIHVzZSBtYXBfYW5kX2ZlbmNlYWJsZSBmb3IgYWxsIHNjYW5v dXQgYnVmZmVycy4KPiAgCSAqLwo+IC0JcmV0ID0gaTkxNV9nZW1fb2JqX2dndHRfcGluKG9iaiwg YWxpZ25tZW50LCBQSU5fTUFQUEFCTEUpOwo+ICsJcmV0ID0gaTkxNV9nZW1fb2JqZWN0X2dndHRf cGluKG9iaiwgdmlldywgYWxpZ25tZW50LAo+ICsJCQkJICAgICAgIHZpZXctPnR5cGUgPT0gSTkx NV9HR1RUX1ZJRVdfTk9STUFMID8KPiArCQkJCSAgICAgICBQSU5fTUFQUEFCTEUgOiAwKTsKCkkn bSBzbGlnaHRseSBjb25jZXJuZWQgYWJvdXQgbWFraW5nIGFuIGFzc3VtcHRpb24gdGhhdCBvdGhl ciBidXQgbm9ybWFsCnZpZXdzIG5lZWQgbm90IHRvIGJlIG1hcHBhYmxlICh3aGVuIG5vbmUgYXJl IGRlZmluZWQpLiBBcyBkaXNjdXNzZWQgaW4KSVJDLCB0aGlzIHNob3VsZCBiZSBtb3ZlZCBsYXRl ciBpbnRvIHRoZSBzZXJpZXMgd2hlbiB3ZSBhY3R1YWxseSBrbm93CmFib3V0IHRoZSBvdGhlciB2 aWV3cy4KCj4gIAlpZiAocmV0KQo+ICAJCWdvdG8gZXJyX3VucGluX2Rpc3BsYXk7Cj4gIAo+IEBA IC00MDIxLDkgKzQwMjQsMTEgQEAgZXJyX3VucGluX2Rpc3BsYXk6Cj4gIH0KPiAgCj4gIHZvaWQK PiAtaTkxNV9nZW1fb2JqZWN0X3VucGluX2Zyb21fZGlzcGxheV9wbGFuZShzdHJ1Y3QgZHJtX2k5 MTVfZ2VtX29iamVjdCAqb2JqKQo+ICtpOTE1X2dlbV9vYmplY3RfdW5waW5fZnJvbV9kaXNwbGF5 X3BsYW5lKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gKwkJCQkJIGNvbnN0IHN0 cnVjdCBpOTE1X2dndHRfdmlldyAqdmlldykKPiAgewo+IC0JaTkxNV9nZW1fb2JqZWN0X2dndHRf dW5waW4ob2JqKTsKPiArCWk5MTVfZ2VtX29iamVjdF9nZ3R0X3VucGluX3ZpZXcob2JqLCB2aWV3 KTsKPiArCj4gIAlvYmotPnBpbl9kaXNwbGF5ID0gaXNfcGluX2Rpc3BsYXkob2JqKTsKPiAgfQo+ ICAKPiBAQCAtNDI5NiwxNSArNDMwMSwxNiBAQCBpOTE1X2dlbV9vYmplY3RfZ2d0dF9waW4oc3Ry dWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiAgfQo+ICAKPiAgdm9pZAo+IC1pOTE1X2dl bV9vYmplY3RfZ2d0dF91bnBpbihzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQo+ICtp OTE1X2dlbV9vYmplY3RfZ2d0dF91bnBpbl92aWV3KHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0 ICpvYmosCj4gKwkJCQljb25zdCBzdHJ1Y3QgaTkxNV9nZ3R0X3ZpZXcgKnZpZXcpCj4gIHsKPiAt CXN0cnVjdCBpOTE1X3ZtYSAqdm1hID0gaTkxNV9nZW1fb2JqX3RvX2dndHQob2JqKTsKPiArCXN0 cnVjdCBpOTE1X3ZtYSAqdm1hID0gaTkxNV9nZW1fb2JqX3RvX2dndHRfdmlldyhvYmosIHZpZXcp Owo+ICAKPiAgCUJVR19PTighdm1hKTsKPiAgCUJVR19PTih2bWEtPnBpbl9jb3VudCA9PSAwKTsK PiAtCUJVR19PTighaTkxNV9nZW1fb2JqX2dndHRfYm91bmQob2JqKSk7Cj4gKwlCVUdfT04oIWk5 MTVfZ2VtX29ial9nZ3R0X2JvdW5kX3ZpZXcob2JqLCB2aWV3LT50eXBlKSk7Cj4gIAo+IC0JaWYg KC0tdm1hLT5waW5fY291bnQgPT0gMCkKPiArCWlmICgtLXZtYS0+cGluX2NvdW50ID09IDAgJiYg dmlldy0+dHlwZSA9PSBJOTE1X0dHVFRfVklFV19OT1JNQUwpCj4gIAkJb2JqLT5waW5fbWFwcGFi bGUgPSBmYWxzZTsKPiAgfQo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4g aW5kZXggYTMwNzk3OS4uMTZmMzQ0MyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMKPiBAQCAtMjMxMSw3ICsyMzExLDggQEAgaW50ZWxfcGluX2FuZF9mZW5jZV9mYl9vYmoo c3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIAlpbnRlbF9ydW50aW1lX3BtX2dldChkZXZfcHJp dik7Cj4gIAo+ICAJZGV2X3ByaXYtPm1tLmludGVycnVwdGlibGUgPSBmYWxzZTsKPiAtCXJldCA9 IGk5MTVfZ2VtX29iamVjdF9waW5fdG9fZGlzcGxheV9wbGFuZShvYmosIGFsaWdubWVudCwgcGlw ZWxpbmVkKTsKPiArCXJldCA9IGk5MTVfZ2VtX29iamVjdF9waW5fdG9fZGlzcGxheV9wbGFuZShv YmosIGFsaWdubWVudCwgcGlwZWxpbmVkLAo+ICsJCQkJCQkgICAmaTkxNV9nZ3R0X3ZpZXdfbm9y bWFsKTsKPiAgCWlmIChyZXQpCj4gIAkJZ290byBlcnJfaW50ZXJydXB0aWJsZTsKPiAgCj4gQEAg LTIzMzEsNyArMjMzMiw3IEBAIGludGVsX3Bpbl9hbmRfZmVuY2VfZmJfb2JqKHN0cnVjdCBkcm1f cGxhbmUgKnBsYW5lLAo+ICAJcmV0dXJuIDA7Cj4gIAo+ICBlcnJfdW5waW46Cj4gLQlpOTE1X2dl bV9vYmplY3RfdW5waW5fZnJvbV9kaXNwbGF5X3BsYW5lKG9iaik7Cj4gKwlpOTE1X2dlbV9vYmpl Y3RfdW5waW5fZnJvbV9kaXNwbGF5X3BsYW5lKG9iaiwgJmk5MTVfZ2d0dF92aWV3X25vcm1hbCk7 Cj4gIGVycl9pbnRlcnJ1cHRpYmxlOgo+ICAJZGV2X3ByaXYtPm1tLmludGVycnVwdGlibGUgPSB0 cnVlOwo+ICAJaW50ZWxfcnVudGltZV9wbV9wdXQoZGV2X3ByaXYpOwo+IEBAIC0yMzQzLDcgKzIz NDQsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF91bnBpbl9mYl9vYmooc3RydWN0IGRybV9pOTE1X2dl bV9vYmplY3QgKm9iaikKPiAgCVdBUk5fT04oIW11dGV4X2lzX2xvY2tlZCgmb2JqLT5iYXNlLmRl di0+c3RydWN0X211dGV4KSk7Cj4gIAo+ICAJaTkxNV9nZW1fb2JqZWN0X3VucGluX2ZlbmNlKG9i aik7Cj4gLQlpOTE1X2dlbV9vYmplY3RfdW5waW5fZnJvbV9kaXNwbGF5X3BsYW5lKG9iaik7Cj4g KwlpOTE1X2dlbV9vYmplY3RfdW5waW5fZnJvbV9kaXNwbGF5X3BsYW5lKG9iaiwgJmk5MTVfZ2d0 dF92aWV3X25vcm1hbCk7Cj4gIH0KPiAgCj4gIC8qIENvbXB1dGVzIHRoZSBsaW5lYXIgb2Zmc2V0 IHRvIHRoZSBiYXNlIHRpbGUgYW5kIGFkanVzdHMgeCwgeS4gYnl0ZXMgcGVyIHBpeGVsCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX292ZXJsYXkuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX292ZXJsYXkuYwo+IGluZGV4IDgyM2QxZDkuLmRkOTIxMjIgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfb3ZlcmxheS5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfb3ZlcmxheS5jCj4gQEAgLTcyMCw3ICs3MjAsOCBA QCBzdGF0aWMgaW50IGludGVsX292ZXJsYXlfZG9fcHV0X2ltYWdlKHN0cnVjdCBpbnRlbF9vdmVy bGF5ICpvdmVybGF5LAo+ICAJaWYgKHJldCAhPSAwKQo+ICAJCXJldHVybiByZXQ7Cj4gIAo+IC0J cmV0ID0gaTkxNV9nZW1fb2JqZWN0X3Bpbl90b19kaXNwbGF5X3BsYW5lKG5ld19ibywgMCwgTlVM TCk7Cj4gKwlyZXQgPSBpOTE1X2dlbV9vYmplY3RfcGluX3RvX2Rpc3BsYXlfcGxhbmUobmV3X2Jv LCAwLCBOVUxMLAo+ICsJCQkJCQkgICAmaTkxNV9nZ3R0X3ZpZXdfbm9ybWFsKTsKPiAgCWlmIChy ZXQgIT0gMCkKPiAgCQlyZXR1cm4gcmV0Owo+ICAKCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=