From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH 04/19] drm/i915: Allocate a crtc_state also when the crtc is being disabled Date: Thu, 19 Mar 2015 09:52:01 +0200 Message-ID: <1426751521.2824.42.camel@gmail.com> References: <1426240142-24538-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1426240142-24538-5-git-send-email-ander.conselvan.de.oliveira@intel.com> <76A9B330A4D78C4D99CB292C4CC06C0E36F7B41B@fmsmsx101.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com [209.85.192.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 9BDC3720D4 for ; Thu, 19 Mar 2015 00:52:06 -0700 (PDT) Received: by pdbop1 with SMTP id op1so68622826pdb.2 for ; Thu, 19 Mar 2015 00:52:06 -0700 (PDT) In-Reply-To: <76A9B330A4D78C4D99CB292C4CC06C0E36F7B41B@fmsmsx101.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Konduru, Chandra" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyMDE1LTAzLTE5IGF0IDAwOjEyICswMDAwLCBLb25kdXJ1LCBDaGFuZHJhIHdyb3Rl Ogo+IAo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IENvbnNlbHZhbiBE ZSBPbGl2ZWlyYSwgQW5kZXIKPiA+IFNlbnQ6IEZyaWRheSwgTWFyY2ggMTMsIDIwMTUgMjo0OSBB TQo+ID4gVG86IGludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IENjOiBLb25kdXJ1 LCBDaGFuZHJhOyBDb25zZWx2YW4gRGUgT2xpdmVpcmEsIEFuZGVyCj4gPiBTdWJqZWN0OiBbUEFU Q0ggMDQvMTldIGRybS9pOTE1OiBBbGxvY2F0ZSBhIGNydGNfc3RhdGUgYWxzbyB3aGVuIHRoZSBj cnRjIGlzCj4gPiBiZWluZyBkaXNhYmxlZAo+ID4gCj4gPiBGb3IgY29uc2lzdGVuY3ksIGFsbG9j YXRlIGEgbmV3IGNydGNfc3RhdGUgZm9yIGEgY3J0YyB0aGF0IGlzIGJlaW5nIGRpc2FibGVkLgo+ ID4gUHJldmlvdXNseSBvbmx5IHRoZSBlbmFibGVkIHZhbHVlIG9mIHRoZSBjdXJyZW50IHN0YXRl IHdvdWxkIGNoYW5nZS4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogQW5kZXIgQ29uc2VsdmFuIGRl IE9saXZlaXJhCj4gPiA8YW5kZXIuY29uc2VsdmFuLmRlLm9saXZlaXJhQGludGVsLmNvbT4KPiA+ IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDM2ICsrKysr KysrKysrKysrKysrKysrKysrKystLS0tLS0tLQo+ID4gLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQs IDI1IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gaW5kZXggYjYxZTNmNi4uNjJiOTAyMSAxMDA2NDQK PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBAQCAtMTExODgsMTQgKzEx MTg4LDIxIEBAIGludGVsX21vZGVzZXRfY29tcHV0ZV9jb25maWcoc3RydWN0IGRybV9jcnRjCj4g PiAqY3J0YywKPiA+ICAJCQkgICAgIHVuc2lnbmVkICpwcmVwYXJlX3BpcGVzLAo+ID4gIAkJCSAg ICAgdW5zaWduZWQgKmRpc2FibGVfcGlwZXMpCj4gPiAgewo+ID4gKwlzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2ID0gY3J0Yy0+ZGV2Owo+ID4gIAlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9j b25maWcgPSBOVUxMOwo+ID4gKwlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YzsKPiA+ICAJ aW50IHJldCA9IDA7Cj4gPiAKPiA+ICAJaW50ZWxfbW9kZXNldF9hZmZlY3RlZF9waXBlcyhjcnRj LCBtb2Rlc2V0X3BpcGVzLAo+ID4gIAkJCQkgICAgIHByZXBhcmVfcGlwZXMsIGRpc2FibGVfcGlw ZXMpOwo+ID4gCj4gPiAtCWlmICgoKm1vZGVzZXRfcGlwZXMpID09IDApCj4gPiAtCQlyZXR1cm4g TlVMTDsKPiA+ICsJZm9yX2VhY2hfaW50ZWxfY3J0Y19tYXNrZWQoZGV2LCAqZGlzYWJsZV9waXBl cywgaW50ZWxfY3J0Yykgewo+ID4gKwkJcGlwZV9jb25maWcgPSBpbnRlbF9hdG9taWNfZ2V0X2Ny dGNfc3RhdGUoc3RhdGUsIGludGVsX2NydGMpOwo+ID4gKwkJaWYgKElTX0VSUihwaXBlX2NvbmZp ZykpCj4gPiArCQkJcmV0dXJuIHBpcGVfY29uZmlnOwo+ID4gKwo+ID4gKwkJcGlwZV9jb25maWct PmJhc2UuZW5hYmxlID0gZmFsc2U7Cj4gPiArCX0KPiA+IAo+ID4gIAkvKgo+ID4gIAkgKiBOb3Rl IHRoaXMgbmVlZHMgY2hhbmdlcyB3aGVuIHdlIHN0YXJ0IHRyYWNraW5nIG11bHRpcGxlIG1vZGVz IEBAIC0KPiA+IDExMjAzLDE4ICsxMTIxMCwyNSBAQCBpbnRlbF9tb2Rlc2V0X2NvbXB1dGVfY29u ZmlnKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiA+ICAJICogKGkuZS4gb25lIHBpcGVfY29uZmln IGZvciBlYWNoIGNydGMpIHJhdGhlciB0aGFuIGp1c3QgdGhlIG9uZQo+ID4gIAkgKiBmb3IgdGhp cyBjcnRjLgo+ID4gIAkgKi8KPiA+IC0JcmV0ID0gaW50ZWxfbW9kZXNldF9waXBlX2NvbmZpZyhj cnRjLCBmYiwgbW9kZSwgc3RhdGUpOwo+ID4gLQlpZiAocmV0KQo+ID4gLQkJcmV0dXJuIEVSUl9Q VFIocmV0KTsKPiA+ICsJZm9yX2VhY2hfaW50ZWxfY3J0Y19tYXNrZWQoZGV2LCAqbW9kZXNldF9w aXBlcywgaW50ZWxfY3J0Yykgewo+ID4gKwkJLyogRklYTUU6IEZvciBub3cgd2Ugc3RpbGwgZXhw ZWN0IG1vZGVzZXRfcGlwZXMgaGFzIGF0IG1vc3QKPiA+ICsJCSAqIG9uZSBiaXQgc2V0LiAqLwo+ ID4gKwkJaWYgKFdBUk5fT04oJmludGVsX2NydGMtPmJhc2UgIT0gY3J0YykpCj4gPiArCQkJY29u dGludWU7Cj4gPiAKPiA+IC0JcGlwZV9jb25maWcgPSBpbnRlbF9hdG9taWNfZ2V0X2NydGNfc3Rh dGUoc3RhdGUsIHRvX2ludGVsX2NydGMoY3J0YykpOwo+ID4gLQlpZiAoSVNfRVJSKHBpcGVfY29u ZmlnKSkKPiA+IC0JCXJldHVybiBwaXBlX2NvbmZpZzsKPiA+ICsJCXJldCA9IGludGVsX21vZGVz ZXRfcGlwZV9jb25maWcoY3J0YywgZmIsIG1vZGUsIHN0YXRlKTsKPiA+ICsJCWlmIChyZXQpCj4g PiArCQkJcmV0dXJuIEVSUl9QVFIocmV0KTsKPiA+ICsKPiA+ICsJCXBpcGVfY29uZmlnID0gaW50 ZWxfYXRvbWljX2dldF9jcnRjX3N0YXRlKHN0YXRlLCBpbnRlbF9jcnRjKTsKPiA+ICsJCWlmIChJ U19FUlIocGlwZV9jb25maWcpKQo+ID4gKwkJCXJldHVybiBwaXBlX2NvbmZpZzsKPiA+IAo+ID4g LQlpbnRlbF9kdW1wX3BpcGVfY29uZmlnKHRvX2ludGVsX2NydGMoY3J0YyksIHBpcGVfY29uZmln LAo+ID4gLQkJCSAgICAgICAiW21vZGVzZXRdIik7Cj4gPiArCQlpbnRlbF9kdW1wX3BpcGVfY29u ZmlnKHRvX2ludGVsX2NydGMoY3J0YyksIHBpcGVfY29uZmlnLAo+ID4gKwkJCQkgICAgICAgIltt b2Rlc2V0XSIpOwo+ID4gKwl9Cj4gPiAKPiA+IC0JcmV0dXJuIHBpcGVfY29uZmlnOwo+ID4gKwly ZXR1cm4gaW50ZWxfYXRvbWljX2dldF9jcnRjX3N0YXRlKHN0YXRlLCB0b19pbnRlbF9jcnRjKGNy dGMpKTsKPiA+ICB9Cj4gCj4gSW5zdGVhZCBvZiBjYWxsaW5nIDMgc2VwYXJhdGUgaW50ZWxfYXRv bWljX2dldF9jcnRjX3N0YXRlKCkKPiBDYW4geW91IGhhdmUgc29tZXRoaW5nIGxpa2U6Cj4gaW50 ZWxfbW9kZXNldF9jb21wdXRlX2NvbmZpZygpCj4gewo+IAlwaXBlX2NvbmZpZyA9IGludGVsX2F0 b21pY19nZXRfY3J0Y19zdGF0ZShzdGF0ZSwgY3J0Yyk7Cj4gCj4gCWZvciBlYWNoIGRpc2FibGVk IHBpcGUgewo+IAkJdXNlIHBpcGVfY29uZmlnOwo+IAl9Cj4gCQo+IAlmb3IgZWFjaCBtb2RlX3Nl dCBwaXBlIHsKPiAJCXVzZSBwaXBlX2NvbmZpZzsKPiAJfQo+IAo+IAlyZXR1cm4gcGlwZV9jb25m aWc7Cj4gfQo+IAo+IAo+IE9yIHRoZSB3YXkgY3VycmVudGx5IGRvbmUgaXMgdG8gY292ZXIgd2hl cmUgZGlzYWJsZV9waXBlcyAhPSBtb2Rlc2V0X3BpcGVzPwo+IEJ5IHRoZSB3YXksIHdoZW4gY2Fu IGl0IGhhcHBlbj8KClllcCwgZGlzYWJsZV9waXBlcyBjYW4gYmUgZGlmZmVyZW50IHRoYW4gbW9k ZXNldF9waXBlcyBpZiB3ZSB0aGUgbW9kZQpzZXQgInN0ZWFscyIgYSBjb25uZWN0b3IuIEZvciBp bnN0YW5jZSwgd2UgY291bGQgaGF2ZSBwaXBlIEEgZHJpdmluZwpIRE1JLTEgYW5kIHRoZW4gbW9k ZSBzZXQgdG8gcGlwZSBCIHRvIGRyaXZlIEhETUktMS4gUGlwZSBCIHdpbGwgc3RlYWwKdGhlIGVu Y29kZXIgZnJvbSBwaXBlIEEsIGFuZCBjYXVzZSBpdCB0byBiZSBkaXNhYmxlLiBJbiB0aGF0IGNh c2UKZGlzYWJsZV9waXBlcyB3aWxsIGhhdmUgdGhlIGJpdCBmb3IgcGlwZSBBIHNldCwgd2hpbGUg bW9kZXNldF9waXBlcyB3aWxsCmhhdmUgdGhlIGJpdCBmb3IgcGlwZSBCIHNldC4KCgpBbmRlcgoK PiAKPiA+IAo+ID4gIHN0YXRpYyBpbnQgX19pbnRlbF9zZXRfbW9kZV9zZXR1cF9wbGxzKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsCj4gPiAtLQo+ID4gMi4xLjAKPiAKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=