Re: [PATCH i-g-t 02/10] tests/kms_psr_sink_crc: Make render visible to human eyes

Vivi, Rodrigo
2015-03-16T20:23:37Z

On Mon, 2015-03-16 at 09:59 +0100, Daniel Vetter wrote:
> On Fri, Mar 13, 2015 at 06:19:19PM -0400, Rodrigo Vivi wrote:
> > This will allow manual tests when crc isn't available.
> >
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> > tests/kms_psr_sink_crc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
> > index 0a56705..5085fb3 100644
> > --- a/tests/kms_psr_sink_crc.c
> > +++ b/tests/kms_psr_sink_crc.c
> > @@ -139,7 +139,7 @@ static void scratch_buf_init(struct igt_buf *buf, drm_intel_bo *bo)
> > buf->bo = bo;
> > buf->stride = 4096;
> > buf->tiling = I915_TILING_X;
> > - buf->size = 4096;
> > + buf->size = 4;
>
> 4 looks a bit small ...

agree, but as far as I can remember with 4 I can have visible changes
and with 4096 I couldn't see any thing on screen even with psr
disabled.

> -Daniel
>
> > }
> >
> > static void fill_render(data_t *data, uint32_t handle, unsigned char color)
> > @@ -167,7 +167,7 @@ static void fill_render(data_t *data, uint32_t handle, unsigned char color)
> > igt_assert(batch);
> >
> > rendercopy(batch, NULL,
> > - &src_buf, 0, 0, 1, 1,
> > + &src_buf, 0, 0, 0xff, 0xff,
> > &dst_buf, 0, 0);
> >
> > intel_batchbuffer_free(batch);
> > --
> > 1.9.3
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>