Re: [PATCH] tests/kms_psr_sink_crc: Make render visible to human eyes

Daniel Vetter
2015-03-20T09:53:01Z

On Thu, Mar 19, 2015 at 06:24:24PM -0700, Rodrigo Vivi wrote:
> This will allow manual tests when crc isn't available.
>
> v2: Remove unused and non-sense buf->size and decrease buf->stride a bit as suggested by Daniel.

buf->size isn't nonsense really, it does seem to match what we've
allocated. But it also seems unused in the rendercpy functions I've
checked. Imo you should keep that line.
-Daniel

>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> tests/kms_psr_sink_crc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
> index 0a56705..46e04c8 100644
> --- a/tests/kms_psr_sink_crc.c
> +++ b/tests/kms_psr_sink_crc.c
> @@ -137,9 +137,8 @@ static void fill_blt(data_t *data, uint32_t handle, unsigned char color)
> static void scratch_buf_init(struct igt_buf *buf, drm_intel_bo *bo)
> {
> buf->bo = bo;
> - buf->stride = 4096;
> + buf->stride = 1024;
> buf->tiling = I915_TILING_X;
> - buf->size = 4096;
> }
>
> static void fill_render(data_t *data, uint32_t handle, unsigned char color)
> @@ -167,7 +166,7 @@ static void fill_render(data_t *data, uint32_t handle, unsigned char color)
> igt_assert(batch);
>
> rendercopy(batch, NULL,
> - &src_buf, 0, 0, 1, 1,
> + &src_buf, 0, 0, 0xff, 0xff,
> &dst_buf, 0, 0);
>
> intel_batchbuffer_free(batch);
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation