Re: [PATCH 7/7] drm/i915: Enable PSR by default.

From: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
To: "chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 7/7] drm/i915: Enable PSR by default.
Date: Wed, 25 Mar 2015 19:27:35 +0000	[thread overview]
Message-ID: <1427311650.4663.158.camel@intel.com> (raw)
In-Reply-To: <20150324220503.GA9923@nuc-i3427.alporthouse.com>

On Tue, 2015-03-24 at 22:05 +0000, chris@chris-wilson.co.uk wrote:
> On Tue, Mar 24, 2015 at 08:55:04PM +0000, Vivi, Rodrigo wrote:
> > On Tue, 2015-03-24 at 10:08 +0000, Chris Wilson wrote:
> > > On Tue, Mar 24, 2015 at 11:03:30AM +0100, Daniel Vetter wrote:
> > > > On Mon, Mar 23, 2015 at 01:20:07PM -0700, Rodrigo Vivi wrote:
> > > > > Hi Daniel,
> > > > > 
> > > > > Is something missing to enable it by default?
> > > > 
> > > > Patch 1 has a small comment from me and latest version of patch 2 lacks an
> > > > r-b afaict. Hence why I didn't pull in the series yet. But it's also a
> > > > longer discussion, so ca you please resend the entire series with r-b tags
> > > > added to make sure I don't pick up the wrong versions?
> > > 
> > > Do I yet have a method to tell when PSR is active on an output?
> > 
> > Is that pre computed pipe_config->psr_enabled enough or you mean the
> > immediate psr.active also exposed there on pipe_config?
> 
> I want a property exposed to userspace. Having a tristate that says
> unsupported, disabled, active would be most useful.

I got your patch that added that and rebased on currently intel_psr.c
changing transition and other small things and put here:

http://cgit.freedesktop.org/~vivijim/drm-intel/commit/?h=intel_psr&id=b99147c4849668a04e794003746fa22708406f56

But even with PSR transitioning well from idle to active, xrandr prop
always shows me as idle:

Every 1.0s: cat /sys/kernel/debug/dri/0/i915_edp_psr_status
Wed Mar 25 12:26:13 2015

Sink_Support: yes
Source_OK: yes
Enabled: yes
Active: yes
Busy frontbuffer bits: 0x000
Re-enable work scheduled: no
HW Enabled & Active bit: yes

vivijim rdvivi-talin ~$ xrandr --prop | grep PSR
	PSR: Idle 
vivijim rdvivi-talin ~$ xrandr --prop | grep PSR
	PSR: Idle 
vivijim rdvivi-talin ~$ xrandr --prop | grep PSR
	PSR: Idle 
vivijim rdvivi-talin ~$ xrandr --prop | grep PSR
	PSR: Idle 
vivijim rdvivi-talin ~$ xrandr --prop | grep PSR
	PSR: Idle 

So, I'm not sure this is a proper way of checking this quickly
transitions as active/exit...

> -Chris
> 

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx