From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH v2 4/8] drm/i915/skl: Assert the requirements to enter or exit DC5. Date: Mon, 13 Apr 2015 15:46:41 +0300 Message-ID: <1428929201.29827.72.camel@intel.com> References: <1428005850.8235.54.camel@ideak-mobl> <1428678698-11394-1-git-send-email-animesh.manna@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 3AB086E13E for ; Mon, 13 Apr 2015 05:46:44 -0700 (PDT) In-Reply-To: <1428678698-11394-1-git-send-email-animesh.manna@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Animesh Manna Cc: Suketu Shah , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gcGUsIDIwMTUtMDQtMTAgYXQgMjA6NDEgKzA1MzAsIEFuaW1lc2ggTWFubmEgd3JvdGU6Cj4g RnJvbTogU3VrZXR1IFNoYWggPHN1a2V0dS5qLnNoYWhAaW50ZWwuY29tPgo+IAo+IFdhcm4gaWYg dGhlIGNvbmRpdGlvbnMgdG8gZW50ZXIgb3IgZXhpdCBEQzUgYXJlIG5vdCBzYXRpc2ZpZWQgc3Vj aAo+IGFzIHN1cHBvcnQgZm9yIHJ1bnRpbWUgUE0sIHN0YXRlIG9mIHBvd2VyIHdlbGwsIENTUiBs b2FkaW5nIGV0Yy4KPiAKPiB2MjogUmVtb3ZlZCBjYW1lbGNhc2UgaW4gZnVuY3Rpb25zIGFuZCB2 YXJpYWJsZXMuCj4gCj4gdjM6IERvIHNvbWUgbWluaW1hbCBjaGVjayB0byBhc3NlcnQgaWYgQ1NS IHByb2dyYW0gaXMgbm90IGxvYWRlZC4KPiAKPiB2NDoKPiAxXSBVc2VkIGFuIGFwcHJvcHJpYXRl IGZ1bmN0aW9uIGxvb2t1cF9wb3dlcl93ZWxsKCkgdG8gaWRlbnRpZnkgcG93ZXIgd2VsbCwKPiBp bnN0ZWFkIG9mIHVzaW5nIGEgbWFnaWMgbnVtYmVyIHdoaWNoIGNhbiBjaGFuZ2UgaW4gZnV0dXJl Lgo+IDJdIFNwbGl0IHRoZSBjb25kaXRpb25zIGZ1cnRoZXIgaW4gYXNzZXJ0X2Nhbl9lbmFibGVf REM1KCkgYW5kIGFkZGVkIG1vcmUgY2hlY2tzLgo+IDNdIFJlbW92ZWQgYWxsIFdBUk5zIGZyb20g YXNzZXJ0X2Nhbl9kaXNhYmxlX0RDNSBhcyB0aGV5IHdlcmUgdW5uZWNlc3NhcnkgYW5kIGFkZGVk IHR3bwo+ICAgIG5ldyBvbmVzLgo+IDRdIENoYW5nZWQgdmFyaWFibGUgbmFtZXMgYXMgdXBkYXRl ZCBpbiBlYXJsaWVyIHBhdGNoZXMuCj4gCj4gdjU6Cj4gMV0gQ2hhbmdlIGxvb2t1cF9wb3dlcl93 ZWxsIGZ1bmN0aW9uIHRvIHRha2UgYW4gaW50IHBvd2VyIHdlbGwgaWQuCj4gMl0gRGVmaW5lIGEg bmV3IGludGVsX2Rpc3BsYXlfcG93ZXJfd2VsbF9pc19lbmFibGVkIGhlbHBlciBmdW5jdGlvbiB0 byBjaGVjayB3aGV0aGVyIGEKPiAgICBwYXJ0aWN1bGFyIHBvd2VyIHdlbGwgaXMgZW5hYmxlZC4K PiAzXSBVc2UgQ1NSLXJlbGF0ZWQgbXV0ZXggaW4gYXNzZXJ0X2Nzcl9sb2FkZWQgZnVuY3Rpb24u Cj4gCj4gdjY6IFJlbW92ZSB1c2Ugb2YgZGM1X2VuYWJsZWQgdmFyaWFibGUgYXMgaXQncyBubyBs b25nZXIgbmVlZGVkLgo+IAo+IHY3Ogo+IDFdIFJlYmFzZSB0byBsYXRlc3QuCj4gMl0gTW92ZSBh bGwgREM1LXJlbGF0ZWQgZnVuY3Rpb25zIGZyb20gaW50ZWxfZGlzcGxheS5jIHRvIGludGVsX3J1 bnRpbWVfcG0uYy4KPiAKPiB2ODogQWZ0ZXIgYWRkaW5nIGRtYyB2ZXIgMS4wIHN1cHBvcnQgcmVi YXNlZCBvbiB0b3Agb2YgbmlnaHRseS4gKEFuaW1lc2gpCj4gCj4gdjk6IE1vZGlmaWVkIGJlbG93 IGNobmFnZXMgYmFzZWQgb24gcmV2aWV3IGNvbW1lbnRzIGZyb20gSW1yZS4KPiAtIE1vdmVkIGlu dGVsX2Rpc3BsYXlfcG93ZXJfd2VsbF9pc19lbmFibGVkKCkgdG8gaW50ZWxfcnVudGltZV9wbS5j Lgo+IC0gUmVtb3ZlZCBtdXRleCBsb2NrIGZyb20gYXNzZXJ0X2Nzcl9sb2FkZWQoKS4gKEFuaW1l c2gpCj4gCj4gSXNzdWU6IFZJWi0yODE5Cj4gU2lnbmVkLW9mZi1ieTogQS5TdW5pbCBLYW1hdGgg PHN1bmlsLmthbWF0aEBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogU3VrZXR1IFNoYWggPHN1 a2V0dS5qLnNoYWhAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IERhbWllbiBMZXNwaWF1IDxk YW1pZW4ubGVzcGlhdUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogQW5pbWVzaCBNYW5uYSA8 YW5pbWVzaC5tYW5uYUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3J1bnRpbWVfcG0uYyB8IDYxICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLQo+ ICAxIGZpbGUgY2hhbmdlZCwgNTYgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jCj4gaW5kZXggMDc1MDE5MS4uZGIy NWViNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3Bt LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiBAQCAt MzEsNiArMzEsNyBAQAo+ICAKPiAgI2luY2x1ZGUgImk5MTVfZHJ2LmgiCj4gICNpbmNsdWRlICJp bnRlbF9kcnYuaCIKPiArI2luY2x1ZGUgImludGVsX2Nzci5oIgo+ICAKPiAgLyoqCj4gICAqIERP QzogcnVudGltZSBwbQo+IEBAIC02NCw2ICs2NSw5IEBACj4gIAkgICAgIGktLSkJCQkJCQkJIFwK PiAgCQlpZiAoKHBvd2VyX3dlbGwpLT5kb21haW5zICYgKGRvbWFpbl9tYXNrKSkKPiAgCj4gK2Jv b2wgaW50ZWxfZGlzcGxheV9wb3dlcl93ZWxsX2lzX2VuYWJsZWQoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LAo+ICsJCQkJICAgIGludCBwb3dlcl93ZWxsX2lkKTsKPiArCj4gIC8q Cj4gICAqIFdlIHNob3VsZCBvbmx5IHVzZSB0aGUgcG93ZXIgd2VsbCBpZiB3ZSBleHBsaWNpdGx5 IGFza2VkIHRoZSBoYXJkd2FyZSB0bwo+ICAgKiBlbmFibGUgaXQsIHNvIGNoZWNrIGlmIGl0J3Mg ZW5hYmxlZCBhbmQgYWxzbyBjaGVjayBpZiB3ZSd2ZSByZXF1ZXN0ZWQgaXQgdG8KPiBAQCAtMzM1 LDEyICszMzksNDggQEAgc3RhdGljIHZvaWQgZ2VuOV9zZXRfZGNfc3RhdGVfZGVidWdtYXNrX21l bW9yeV91cCgKPiAgCX0KPiAgfQo+ICAKPiAtc3RhdGljIHZvaWQgZ2VuOV9lbmFibGVfZGM1KHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArc3RhdGljIHZvaWQgYXNzZXJ0X2Nz cl9sb2FkZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICt7Cj4gKwlXQVJO KCFkZXZfcHJpdi0+Y3NyLnN0YXRlcywgIkNTUiBpcyBub3QgbG9hZGVkLlxuIik7CgpUaGlzIGlz IG5vdyB0aGUgd3JvbmcgY29uZGl0aW9uLCBzaG91bGQgYmUgc29tZXRoaW5nIGxpa2UKaW50ZWxf Y3NyX3N0YXRlKGRldl9wcml2KSAhPSBGV19MT0FERUQuCgo+ICsJV0FSTighSTkxNV9SRUFEKENT Ul9QUk9HUkFNX0JBU0UpLAo+ICsJCQkJIkNTUiBwcm9ncmFtIHN0b3JhZ2Ugc3RhcnQgaXMgTlVM TFxuIik7Cj4gKwlXQVJOKCFJOTE1X1JFQUQoQ1NSX1NTUF9CQVNFKSwgIkNTUiBTU1AgQmFzZSBO b3QgZmluZVxuIik7Cj4gKwlXQVJOKCFJOTE1X1JFQUQoQ1NSX0hUUF9TS0wpLCAiQ1NSIEhUUCBO b3QgZmluZVxuIik7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIGFzc2VydF9jYW5fZW5hYmxlX2Rj NShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHsKPiAgCXN0cnVjdCBkcm1f ZGV2aWNlICpkZXYgPSBkZXZfcHJpdi0+ZGV2Owo+ICsJYm9vbCBwZzJfZW5hYmxlZCA9IGludGVs X2Rpc3BsYXlfcG93ZXJfd2VsbF9pc19lbmFibGVkKGRldl9wcml2LAo+ICsJCQkJCVNLTF9ESVNQ X1BXXzIpOwo+ICsKPiArCVdBUk4oIUlTX1NLWUxBS0UoZGV2KSwgIlBsYXRmb3JtIGRvZXNuJ3Qg c3VwcG9ydCBEQzUuXG4iKTsKPiArCVdBUk4oIUhBU19SVU5USU1FX1BNKGRldiksICJSdW50aW1l IFBNIG5vdCBlbmFibGVkLlxuIik7Cj4gKwlXQVJOKHBnMl9lbmFibGVkLCAiUEcyIG5vdCBkaXNh YmxlZCB0byBlbmFibGUgREM1LlxuIik7Cj4gKwo+ICsJV0FSTigoSTkxNV9SRUFEKERDX1NUQVRF X0VOKSAmIERDX1NUQVRFX0VOX1VQVE9fREM1KSwKPiArCQkJCSJEQzUgYWxyZWFkeSBwcm9ncmFt bWVkIHRvIGJlIGVuYWJsZWQuXG4iKTsKPiArCVdBUk4oZGV2X3ByaXYtPnBtLnN1c3BlbmRlZCwK PiArCQkiREM1IGNhbm5vdCBiZSBlbmFibGVkLCBpZiBwbGF0Zm9ybSBpcyBydW50aW1lLXN1c3Bl bmRlZC5cbiIpOwo+ICsKPiArCWFzc2VydF9jc3JfbG9hZGVkKGRldl9wcml2KTsKPiArfQo+ICsK PiArc3RhdGljIHZvaWQgYXNzZXJ0X2Nhbl9kaXNhYmxlX2RjNShzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYpCj4gK3sKPiArCWJvb2wgcGcyX2VuYWJsZWQgPSBpbnRlbF9kaXNwbGF5 X3Bvd2VyX3dlbGxfaXNfZW5hYmxlZChkZXZfcHJpdiwKPiArCQkJCQlTS0xfRElTUF9QV18yKTsK PiArCj4gKwlXQVJOKCFwZzJfZW5hYmxlZCwgIlBHMiBub3QgZW5hYmxlZCB0byBkaXNhYmxlIERD NS5cbiIpOwo+ICsJV0FSTihkZXZfcHJpdi0+cG0uc3VzcGVuZGVkLAo+ICsJCSJEaXNhYmxpbmcg b2YgREM1IHdoaWxlIHBsYXRmb3JtIGlzIHJ1bnRpbWUtc3VzcGVuZGVkIHNob3VsZCBuZXZlciBo YXBwZW4uXG4iKTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgZ2VuOV9lbmFibGVfZGM1KHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArewo+ICAJdWludDMyX3QgdmFsOwo+ICAK PiAtCVdBUk5fT04oIUlTX0dFTjkoZGV2KSk7Cj4gKwlhc3NlcnRfY2FuX2VuYWJsZV9kYzUoZGV2 X3ByaXYpOwo+ICAKPiAgCURSTV9ERUJVR19LTVMoIkVuYWJsaW5nIERDNVxuIik7Cj4gIAo+IEBA IC0zNTUsMTAgKzM5NSw5IEBAIHN0YXRpYyB2b2lkIGdlbjlfZW5hYmxlX2RjNShzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAo+ICBzdGF0aWMgdm9pZCBnZW45X2Rpc2FibGVf ZGM1KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+IC0Jc3RydWN0IGRy bV9kZXZpY2UgKmRldiA9IGRldl9wcml2LT5kZXY7Cj4gIAl1aW50MzJfdCB2YWw7Cj4gIAo+IC0J V0FSTl9PTighSVNfR0VOOShkZXYpKTsKPiArCWFzc2VydF9jYW5fZGlzYWJsZV9kYzUoZGV2X3By aXYpOwo+ICAKPiAgCURSTV9ERUJVR19LTVMoIkRpc2FibGluZyBEQzVcbiIpOwo+ICAKPiBAQCAt MTMyNCw3ICsxMzYzLDcgQEAgc3RhdGljIHN0cnVjdCBpOTE1X3Bvd2VyX3dlbGwgY2h2X3Bvd2Vy X3dlbGxzW10gPSB7Cj4gIH07Cj4gIAo+ICBzdGF0aWMgc3RydWN0IGk5MTVfcG93ZXJfd2VsbCAq bG9va3VwX3Bvd2VyX3dlbGwoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+IC0J CQkJCQkgZW51bSBwdW5pdF9wb3dlcl93ZWxsIHBvd2VyX3dlbGxfaWQpCj4gKwkJCQkJCSBpbnQg cG93ZXJfd2VsbF9pZCkKPiAgewo+ICAJc3RydWN0IGk5MTVfcG93ZXJfZG9tYWlucyAqcG93ZXJf ZG9tYWlucyA9ICZkZXZfcHJpdi0+cG93ZXJfZG9tYWluczsKPiAgCXN0cnVjdCBpOTE1X3Bvd2Vy X3dlbGwgKnBvd2VyX3dlbGw7Cj4gQEAgLTEzMzgsNiArMTM3NywxOCBAQCBzdGF0aWMgc3RydWN0 IGk5MTVfcG93ZXJfd2VsbCAqbG9va3VwX3Bvd2VyX3dlbGwoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcgo+ICAJcmV0dXJuIE5VTEw7Cj4gIH0KPiAgCj4gK2Jvb2wgaW50ZWxfZGlzcGxh eV9wb3dlcl93ZWxsX2lzX2VuYWJsZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LAo+ICsJCQkJICAgIGludCBwb3dlcl93ZWxsX2lkKQo+ICt7Cj4gKwlzdHJ1Y3QgaTkxNV9wb3dl cl93ZWxsICpwb3dlcl93ZWxsOwo+ICsJYm9vbCByZXQ7Cj4gKwo+ICsJcG93ZXJfd2VsbCA9IGxv b2t1cF9wb3dlcl93ZWxsKGRldl9wcml2LCBwb3dlcl93ZWxsX2lkKTsKPiArCXJldCA9IHBvd2Vy X3dlbGwtPm9wcy0+aXNfZW5hYmxlZChkZXZfcHJpdiwgcG93ZXJfd2VsbCk7Cj4gKwo+ICsJcmV0 dXJuIHJldDsKPiArfQo+ICsKPiAgc3RhdGljIHN0cnVjdCBpOTE1X3Bvd2VyX3dlbGwgc2tsX3Bv d2VyX3dlbGxzW10gPSB7Cj4gIAl7Cj4gIAkJLm5hbWUgPSAiYWx3YXlzLW9uIiwKCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=