From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t 1/7] kms_rotation_crc: Local framebuffers do not need to be global
Date: Wed, 22 Apr 2015 16:46:42 +0100 [thread overview]
Message-ID: <1429717608-359-2-git-send-email-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <1429717608-359-1-git-send-email-tvrtko.ursulin@linux.intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Sonika Jindal <sonika.jindal@intel.com>
---
tests/kms_rotation_crc.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index eda66de..22bc554 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -36,8 +36,6 @@ typedef struct {
struct igt_fb fb;
struct igt_fb fb_cursor;
struct igt_fb fb_full;
- struct igt_fb fb_565;
- struct igt_fb fb_tiling;
igt_crc_t ref_crc;
igt_pipe_crc_t *pipe_crc;
igt_rotation_t rotation;
@@ -247,6 +245,7 @@ static void test_unsupported_tiling_pixel_format(data_t *data, enum igt_plane pl
enum pipe pipe;
int valid_tests = 0;
int fb_tiling_id, fb_565_id;
+ struct igt_fb fb_565, fb_tiling;
for_each_connected_output(display, output) {
for_each_pipe(display, pipe) {
@@ -262,10 +261,10 @@ static void test_unsupported_tiling_pixel_format(data_t *data, enum igt_plane pl
mode->hdisplay, mode->vdisplay,
DRM_FORMAT_XRGB8888,
LOCAL_DRM_FORMAT_MOD_NONE,
- &data->fb_tiling);
+ &fb_tiling);
igt_assert(fb_tiling_id);
- paint_squares(data, &data->fb_tiling, mode, IGT_ROTATION_0, plane);
- igt_plane_set_fb(plane, &data->fb_tiling);
+ paint_squares(data, &fb_tiling, mode, IGT_ROTATION_0, plane);
+ igt_plane_set_fb(plane, &fb_tiling);
/* For the first modeset with legacy commit */
igt_display_commit(display);
igt_plane_set_rotation(plane, data->rotation);
@@ -276,10 +275,10 @@ static void test_unsupported_tiling_pixel_format(data_t *data, enum igt_plane pl
mode->hdisplay, mode->vdisplay,
DRM_FORMAT_RGB565,
LOCAL_I915_FORMAT_MOD_Y_TILED,
- &data->fb_565);
+ &fb_565);
igt_assert(fb_565_id);
- paint_squares(data, &data->fb_565, mode, IGT_ROTATION_0, plane);
- igt_plane_set_fb(plane, &data->fb_565);
+ paint_squares(data, &fb_565, mode, IGT_ROTATION_0, plane);
+ igt_plane_set_fb(plane, &fb_565);
igt_plane_set_rotation(plane, data->rotation);
/* Shud fail because 90/270 is not supported with RGB565 */
igt_assert(igt_display_try_commit2(display, COMMIT_UNIVERSAL) == -EINVAL);
@@ -294,8 +293,8 @@ static void test_unsupported_tiling_pixel_format(data_t *data, enum igt_plane pl
valid_tests++;
- igt_remove_fb(data->gfx_fd, &data->fb_tiling);
- igt_remove_fb(data->gfx_fd, &data->fb_565);
+ igt_remove_fb(data->gfx_fd, &fb_tiling);
+ igt_remove_fb(data->gfx_fd, &fb_565);
cleanup_crtc(data, output, plane);
igt_display_commit(display);
--
2.3.5
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-04-22 15:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 15:46 [PATCH i-g-t 0/7] kms_rotation_crc cleanups Tvrtko Ursulin
2015-04-22 15:46 ` Tvrtko Ursulin [this message]
2015-04-22 15:46 ` [PATCH i-g-t 2/7] kms_rotation_crc: Framebuffer used for initial modeset does not need to be painted Tvrtko Ursulin
2015-04-22 15:46 ` [PATCH i-g-t 3/7] kms_rotation_crc: Remove unused variable in negative test Tvrtko Ursulin
2015-04-22 15:46 ` [PATCH i-g-t 4/7] kms_rotation_crc: Negative test does not need to render anything Tvrtko Ursulin
2015-04-22 15:46 ` [PATCH i-g-t 5/7] kms_rotation_crc: Consolidate plane and cursor code paths Tvrtko Ursulin
2015-04-22 15:46 ` [PATCH i-g-t 6/7] kms_rotation_crc: No need to square the buffer in paint Tvrtko Ursulin
2015-04-22 15:46 ` [PATCH i-g-t 7/7] kms_rotation_crc: Use main test for negative cases Tvrtko Ursulin
2015-04-23 9:41 ` Jindal, Sonika
2015-04-27 17:30 ` Thomas Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429717608-359-2-git-send-email-tvrtko.ursulin@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox