public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t 6/7] kms_rotation_crc: No need to square the buffer in paint
Date: Wed, 22 Apr 2015 16:46:47 +0100	[thread overview]
Message-ID: <1429717608-359-7-git-send-email-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <1429717608-359-1-git-send-email-tvrtko.ursulin@linux.intel.com>

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Now that size is calculated in a single place and correct geometry passed in,
paint squares does not need to concern itself with it.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Sonika Jindal <sonika.jindal@intel.com>
---
 tests/kms_rotation_crc.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 60819b3..45a9284 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -58,15 +58,9 @@ paint_squares(data_t *data, drmModeModeInfo *mode, igt_rotation_t rotation,
 		cairo_rotate(cr, M_PI);
 	}
 
-	/*
-	 * "rotation" is used for creating ref rotated fb and
-	 * "data->rotation" is used to determine the required size
-	 * while creating unrotated fb.
-	 */
 	if (rotation == IGT_ROTATION_90) {
 		/* Paint 4 squares with width == height in Blue, Red,
 		Green, White Clockwise order to look like 90 degree rotated*/
-		w = h = mode->vdisplay;
 		igt_paint_color(cr, 0, 0, w / 2, h / 2, 0.0, 0.0, 1.0);
 		igt_paint_color(cr, w / 2, 0, w / 2, h / 2, 1.0, 0.0, 0.0);
 		igt_paint_color(cr, 0, h / 2, w / 2, h / 2, 1.0, 1.0, 1.0);
@@ -75,16 +69,12 @@ paint_squares(data_t *data, drmModeModeInfo *mode, igt_rotation_t rotation,
 	} else if (rotation == IGT_ROTATION_270) {
 		/* Paint 4 squares with width == height in Green, White,
 		Blue, Red Clockwise order to look like 270 degree rotated*/
-		w = h = mode->vdisplay;
 		igt_paint_color(cr, 0, 0, w / 2, h / 2, 0.0, 1.0, 0.0);
 		igt_paint_color(cr, w / 2, 0, w / 2, h / 2, 1.0, 1.0, 1.0);
 		igt_paint_color(cr, 0, h / 2, w / 2, h / 2, 1.0, 0.0, 0.0);
 		igt_paint_color(cr, w / 2, h / 2, w / 2, h / 2, 0.0, 0.0, 1.0);
 
 	} else {
-		if (data->rotation == IGT_ROTATION_90 ||
-			data->rotation == IGT_ROTATION_270)
-			w = h = mode->vdisplay;
 		/* Paint with 4 squares of Red, Green, White, Blue Clockwise */
 		igt_paint_color(cr, 0, 0, w / 2, h / 2, 1.0, 0.0, 0.0);
 		igt_paint_color(cr, w / 2, 0, w / 2, h / 2, 0.0, 1.0, 0.0);
-- 
2.3.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-04-22 15:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-22 15:46 [PATCH i-g-t 0/7] kms_rotation_crc cleanups Tvrtko Ursulin
2015-04-22 15:46 ` [PATCH i-g-t 1/7] kms_rotation_crc: Local framebuffers do not need to be global Tvrtko Ursulin
2015-04-22 15:46 ` [PATCH i-g-t 2/7] kms_rotation_crc: Framebuffer used for initial modeset does not need to be painted Tvrtko Ursulin
2015-04-22 15:46 ` [PATCH i-g-t 3/7] kms_rotation_crc: Remove unused variable in negative test Tvrtko Ursulin
2015-04-22 15:46 ` [PATCH i-g-t 4/7] kms_rotation_crc: Negative test does not need to render anything Tvrtko Ursulin
2015-04-22 15:46 ` [PATCH i-g-t 5/7] kms_rotation_crc: Consolidate plane and cursor code paths Tvrtko Ursulin
2015-04-22 15:46 ` Tvrtko Ursulin [this message]
2015-04-22 15:46 ` [PATCH i-g-t 7/7] kms_rotation_crc: Use main test for negative cases Tvrtko Ursulin
2015-04-23  9:41   ` Jindal, Sonika
2015-04-27 17:30     ` Thomas Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429717608-359-7-git-send-email-tvrtko.ursulin@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox