From: Mika Kahola <mika.kahola@intel.com>
To: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 2/2] drm/i915: DP link training optimization
Date: Tue, 28 Apr 2015 11:14:46 +0300 [thread overview]
Message-ID: <1430208886.4504.4.camel@sorvi> (raw)
In-Reply-To: <553F3B9C.6040100@intel.com>
On Tue, 2015-04-28 at 13:19 +0530, Sivakumar Thulasimani wrote:
>
> On 4/28/2015 12:13 PM, Mika Kahola wrote:
> > This patch adds DP link training optimization by reusing the
> > previously trained values.
> >
> > v2:
> > - rebase
> >
> > V3:
> > - rebase
> >
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_dp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> > index 15adafc..bb1a8d0 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -3794,7 +3794,7 @@ intel_dp_complete_link_train(struct intel_dp *intel_dp)
> > intel_dp->DP = DP;
> >
> > if (channel_eq) {
> > - intel_dp->train_set_valid = is_edp(intel_dp);
> > + intel_dp->train_set_valid = true;
> > DRM_DEBUG_KMS("Channel EQ done. DP Training successful\n");
> > }
> > }
> any reason why this is split into a separate patch ?
I discussed this with Jani and we agreed that one option would be to
apply this optimization only for the eDP case. This second patch is for
the possibility to cover the general DP.
-Mika-
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-04-28 8:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 6:43 [PATCH v3] drm/i915: DP link training optimization Mika Kahola
2015-04-28 6:43 ` [PATCH v3 1/2] " Mika Kahola
2015-04-28 6:43 ` [PATCH v3 2/2] " Mika Kahola
2015-04-28 7:49 ` Sivakumar Thulasimani
2015-04-28 8:14 ` Mika Kahola [this message]
2015-04-28 8:21 ` Sivakumar Thulasimani
2015-04-28 9:42 ` Mika Kahola
2015-04-28 9:48 ` Sivakumar Thulasimani
2015-04-28 10:10 ` Mika Kahola
2015-04-28 12:15 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430208886.4504.4.camel@sorvi \
--to=mika.kahola@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sivakumar.thulasimani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox