Re: [PATCH v3 2/2] drm/i915: DP link training optimization

[Mika Kahola <mika.kahola@intel.com>]

On Tue, 2015-04-28 at 13:51 +0530, Sivakumar Thulasimani wrote:
> 
> 
> On 4/28/2015 1:44 PM, Mika Kahola wrote:
> > On Tue, 2015-04-28 at 13:19 +0530, Sivakumar Thulasimani wrote:
> >> On 4/28/2015 12:13 PM, Mika Kahola wrote:
> >>> This patch adds DP link training optimization by reusing the
> >>> previously trained values.
> >>>
> >>> v2:
> >>> - rebase
> >>>
> >>> V3:
> >>> - rebase
> >>>
> >>> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> >>> ---
> >>>    drivers/gpu/drm/i915/intel_dp.c | 2 +-
> >>>    1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> >>> index 15adafc..bb1a8d0 100644
> >>> --- a/drivers/gpu/drm/i915/intel_dp.c
> >>> +++ b/drivers/gpu/drm/i915/intel_dp.c
> >>> @@ -3794,7 +3794,7 @@ intel_dp_complete_link_train(struct intel_dp *intel_dp)
> >>>    	intel_dp->DP = DP;
> >>>    
> >>>    	if (channel_eq) {
> >>> -		intel_dp->train_set_valid = is_edp(intel_dp);
> >>> +		intel_dp->train_set_valid = true;
> >>>    		DRM_DEBUG_KMS("Channel EQ done. DP Training successful\n");
> >>>    	}
> >>>    }
> >> any reason why this is split into a separate patch ?
> > I discussed this with Jani and we agreed that one option would be to
> > apply this optimization only for the eDP case. This second patch is for
> > the possibility to cover the general DP.
> >
> > -Mika-
> >
> >
> might be a nit pick so up to you to consider this or not :). since DP is 
> part of the second patch, better to reset "train_set_valid" for long 
> pulse HPD in the second patch as well. HPD is not enabled for eDP as of now.
> 
So, you mean that the second patch could be written as independent of
the first patch? In that way you could choose which patch you apply and
you wouldn't have to apply the both patches to get the DP case covered.


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx