public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Chandra Konduru <chandra.konduru@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: daniel.vetter@intel.com, ville.syrjala@intel.com
Subject: [PATCH 05/11] drm/i915: Upscale scaler max scale for NV12.
Date: Thu, 30 Apr 2015 20:43:09 -0700	[thread overview]
Message-ID: <1430451795-9657-6-git-send-email-chandra.konduru@intel.com> (raw)
In-Reply-To: <1430451795-9657-1-git-send-email-chandra.konduru@intel.com>

This patch updates max supported scaler limits for NV12.

Signed-off-by: Chandra Konduru <chandra.konduru@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c |   12 ++++++++----
 drivers/gpu/drm/i915/intel_drv.h     |    3 ++-
 drivers/gpu/drm/i915/intel_sprite.c  |    2 +-
 3 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 9d413a6..c235a66 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -12893,7 +12893,8 @@ intel_cleanup_plane_fb(struct drm_plane *plane,
 }
 
 int
-skl_max_scale(struct intel_crtc *intel_crtc, struct intel_crtc_state *crtc_state)
+skl_max_scale(struct intel_crtc *intel_crtc, struct intel_crtc_state *crtc_state,
+	uint32_t pixel_format)
 {
 	int max_scale;
 	struct drm_device *dev;
@@ -12913,11 +12914,13 @@ skl_max_scale(struct intel_crtc *intel_crtc, struct intel_crtc_state *crtc_state
 
 	/*
 	 * skl max scale is lower of:
-	 *    close to 3 but not 3, -1 is for that purpose
+	 *    close to 2 or 3 (NV12: 2, other formats: 3) but not equal,
+	 *          -1 is for that purpose
 	 *            or
 	 *    cdclk/crtc_clock
 	 */
-	max_scale = min((1 << 16) * 3 - 1, (1 << 8) * ((cdclk << 8) / crtc_clock));
+	max_scale = min((1 << 16) * (pixel_format == DRM_FORMAT_NV12 ? 2 : 3) - 1,
+		(1 << 8) * ((cdclk << 8) / crtc_clock));
 
 	return max_scale;
 }
@@ -12947,7 +12950,8 @@ intel_check_primary_plane(struct drm_plane *plane,
 
 	if (INTEL_INFO(dev)->gen >= 9) {
 		min_scale = 1;
-		max_scale = skl_max_scale(intel_crtc, crtc_state);
+		max_scale = skl_max_scale(intel_crtc, crtc_state,
+			fb ? fb->pixel_format :0);
 		can_position = true;
 	}
 
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index ccf89f8..fdd667d 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -1139,7 +1139,8 @@ void skl_detach_scalers(struct intel_crtc *intel_crtc);
 int skl_update_scaler_users(struct intel_crtc *intel_crtc,
 	struct intel_crtc_state *crtc_state, struct intel_plane *intel_plane,
 	struct intel_plane_state *plane_state, int force_detach);
-int skl_max_scale(struct intel_crtc *crtc, struct intel_crtc_state *crtc_state);
+int skl_max_scale(struct intel_crtc *crtc, struct intel_crtc_state *crtc_state,
+	uint32_t pixel_format);
 
 unsigned long intel_plane_obj_offset(struct intel_plane *intel_plane,
 				     struct drm_i915_gem_object *obj);
diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
index 5698a07..59846f8 100644
--- a/drivers/gpu/drm/i915/intel_sprite.c
+++ b/drivers/gpu/drm/i915/intel_sprite.c
@@ -901,7 +901,7 @@ intel_check_sprite_plane(struct drm_plane *plane,
 
 	if (INTEL_INFO(dev)->gen >= 9) {
 		min_scale = 1;
-		max_scale = skl_max_scale(intel_crtc, crtc_state);
+		max_scale = skl_max_scale(intel_crtc, crtc_state, fb->pixel_format);
 	}
 
 	drm_rect_rotate(src, fb->width << 16, fb->height << 16,
-- 
1.7.9.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-05-01  3:44 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01  3:43 [PATCH 00/11] Skylake display NV12 feature addition Chandra Konduru
2015-05-01  3:43 ` [PATCH 01/11] drm/i915: Add register definitions for NV12 support Chandra Konduru
2015-05-01  3:43 ` [PATCH 02/11] drm/i915: Set scaler mode for NV12 Chandra Konduru
2015-05-01  3:43 ` [PATCH 03/11] drm/i915: Stage scaler request for NV12 as src format Chandra Konduru
2015-05-01  3:43 ` [PATCH 04/11] drm/i915: Update format_is_yuv() to include NV12 Chandra Konduru
2015-05-01  3:43 ` Chandra Konduru [this message]
2015-05-01  3:43 ` [PATCH 06/11] drm/i915: Add NV12 as supported format for primary plane Chandra Konduru
2015-05-07  6:56   ` Daniel Vetter
2015-05-08  2:29     ` Konduru, Chandra
2015-05-08  7:13       ` Daniel Vetter
2015-05-01  3:43 ` [PATCH 07/11] drm/i915: Add NV12 as supported format for sprite plane Chandra Konduru
2015-05-01  3:43 ` [PATCH 08/11] drm/i915: Add NV12 support to intel_framebuffer_init Chandra Konduru
2015-05-11 10:54   ` Tvrtko Ursulin
2015-05-11 11:08     ` Ville Syrjälä
2015-05-01  3:43 ` [PATCH 09/11] drm/i915: Update compute_baseline_bpp for NV12 Chandra Konduru
2015-05-07  6:59   ` Daniel Vetter
2015-05-07 16:01     ` Konduru, Chandra
2015-05-01  3:43 ` [PATCH 10/11] drm/i915: Add NV12 to primary plane programming Chandra Konduru
2015-05-08 20:40   ` Chandra Konduru
2015-05-11 10:24     ` Tvrtko Ursulin
2015-05-01  3:43 ` [PATCH 11/11] drm/i915: Add NV12 to sprite " Chandra Konduru
2015-05-14  5:13 ` [PATCH 00/11] Skylake display NV12 feature addition Konduru, Chandra
2015-05-14 12:46   ` Tvrtko Ursulin
2015-05-18  5:24     ` Konduru, Chandra
2015-05-18 10:42       ` Tvrtko Ursulin
2015-05-19 23:21         ` Konduru, Chandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430451795-9657-6-git-send-email-chandra.konduru@intel.com \
    --to=chandra.konduru@intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox