From: Imre Deak <imre.deak@intel.com>
To: Nick Hoath <nicholas.hoath@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i195/bxt: Add A1 stepping for Broxton
Date: Tue, 05 May 2015 19:18:31 +0300 [thread overview]
Message-ID: <1430842711.21211.76.camel@intel.com> (raw)
In-Reply-To: <5548D1C6.5030703@intel.com>
On ti, 2015-05-05 at 15:20 +0100, Nick Hoath wrote:
> On 29/04/2015 15:35, Deak, Imre wrote:
> > On pe, 2015-03-20 at 09:29 +0000, Nick Hoath wrote:
> >> This stepping isn't listed separately in the specs, so needs confirmation.
> >>
> >> Signed-off-by: Nick Hoath <nicholas.hoath@intel.com>
> >> ---
> >> drivers/gpu/drm/i915/i915_drv.h | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> >> index eec271a..68fb41a 100644
> >> --- a/drivers/gpu/drm/i915/i915_drv.h
> >> +++ b/drivers/gpu/drm/i915/i915_drv.h
> >> @@ -2329,6 +2329,7 @@ struct drm_i915_cmd_table {
> >> #define SKL_REVID_E0 (0x4)
> >>
> >> #define BXT_REVID_A0 (0x0)
> >> +#define BXT_REVID_A1 (0x1)
> >
> > The above mapping is for the SOC RevID, but I think for all our purposes
> > (WAs) we should check the GT/Display RevID. The A1 GT/Display RevID
> > doesn't seem to exist, only A0 is defined with all of 0,1,2 RevIDs
> > mapping to A0.
>
> We use the GT Device2 Revision ID for these comparisons, which does
> change on each SoC revision. This may map to A0 GT stepping for all the
> Ax SoCs, according to the specs. However, as this is a naming convention
> that doesn't affect the code, I suggest we stick to what I have in this
> patch even if it doesn't 100% reflect what's in the specs.
Not sure about this, as I understand all the workarounds are marked with
the GT stepping not the SOC stepping, even though the latter is more
fine-grained. Is there any workarounds for A1? If not I'd suggest adding
this macro only when we need it.
--Imre
> >> #define BXT_REVID_B0 (0x3)
> >> #define BXT_REVID_C0 (0x6)
> >>
> >
> >
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-05-05 16:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 9:29 [PATCH] drm/i195/bxt: Add A1 stepping for Broxton Nick Hoath
2015-03-20 17:14 ` shuang.he
2015-03-20 19:17 ` Jesse Barnes
2015-03-21 1:20 ` He, Shuang
2015-04-29 14:35 ` Imre Deak
2015-05-05 14:20 ` Nick Hoath
2015-05-05 16:18 ` Imre Deak [this message]
2015-05-06 16:00 ` Nick Hoath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430842711.21211.76.camel@intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nicholas.hoath@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox