From: Ander Conselvan De Oliveira <conselvan2@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Disable 12bpc hdmi for now
Date: Thu, 28 May 2015 11:58:30 +0300 [thread overview]
Message-ID: <1432803510.8896.1.camel@gmail.com> (raw)
In-Reply-To: <1432798905-26906-1-git-send-email-daniel.vetter@ffwll.ch>
On Thu, 2015-05-28 at 09:41 +0200, Daniel Vetter wrote:
> It's totally broken, and since
>
> commit d328c9d78d64ca11e744fe227096990430a88477
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Fri Apr 10 16:22:37 2015 +0200
>
> drm/i915: Select starting pipe bpp irrespective or the primary plane
>
> the kernel will try to use it even for the common rgb888 framebuffers.
> Ville has patches to fix it all up properly, but unfortunately they're
> stuck in review limbo. And since the 4.2 feature cutoff has passed we
> need to somehow handle this regression.
You might want to add
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90460
Ander
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Paulo Zanoni <przanoni@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/i915/intel_hdmi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 4117092ab2e3..e97731aab6dc 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -1036,7 +1036,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,
> */
> if (pipe_config->pipe_bpp > 8*3 && pipe_config->has_hdmi_sink &&
> clock_12bpc <= portclock_limit &&
> - hdmi_12bpc_possible(pipe_config)) {
> + hdmi_12bpc_possible(pipe_config) &&
> + 0 /* FIXME 12bpc support totally broken */) {
> DRM_DEBUG_KMS("picking bpc to 12 for HDMI output\n");
> desired_bpp = 12*3;
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-05-28 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 7:41 [PATCH] drm/i915: Disable 12bpc hdmi for now Daniel Vetter
2015-05-28 8:58 ` Ander Conselvan De Oliveira [this message]
2015-05-28 12:22 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432803510.8896.1.camel@gmail.com \
--to=conselvan2@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox