[PATCH] drm/i915: Disable 12bpc hdmi for now

[PATCH] drm/i915: Disable 12bpc hdmi for now

[Daniel Vetter]

It's totally broken, and since

commit d328c9d78d64ca11e744fe227096990430a88477
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Fri Apr 10 16:22:37 2015 +0200

    drm/i915: Select starting pipe bpp irrespective or the primary plane

the kernel will try to use it even for the common rgb888 framebuffers.
Ville has patches to fix it all up properly, but unfortunately they're
stuck in review limbo. And since the 4.2 feature cutoff has passed we
need to somehow  handle this regression.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Paulo Zanoni <przanoni@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/i915/intel_hdmi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index 4117092ab2e3..e97731aab6dc 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -1036,7 +1036,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,
 	 */
 	if (pipe_config->pipe_bpp > 8*3 && pipe_config->has_hdmi_sink &&
 	    clock_12bpc <= portclock_limit &&
-	    hdmi_12bpc_possible(pipe_config)) {
+	    hdmi_12bpc_possible(pipe_config) &&
+	    0 /* FIXME 12bpc support totally broken */) {
 		DRM_DEBUG_KMS("picking bpc to 12 for HDMI output\n");
 		desired_bpp = 12*3;
 
-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Disable 12bpc hdmi for now

[Ander Conselvan De Oliveira]

On Thu, 2015-05-28 at 09:41 +0200, Daniel Vetter wrote:
> It's totally broken, and since
> 
> commit d328c9d78d64ca11e744fe227096990430a88477
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Fri Apr 10 16:22:37 2015 +0200
> 
>     drm/i915: Select starting pipe bpp irrespective or the primary plane
> 
> the kernel will try to use it even for the common rgb888 framebuffers.
> Ville has patches to fix it all up properly, but unfortunately they're
> stuck in review limbo. And since the 4.2 feature cutoff has passed we
> need to somehow  handle this regression.

You might want to add

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90460


Ander

> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Paulo Zanoni <przanoni@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_hdmi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 4117092ab2e3..e97731aab6dc 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -1036,7 +1036,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,
>  	 */
>  	if (pipe_config->pipe_bpp > 8*3 && pipe_config->has_hdmi_sink &&
>  	    clock_12bpc <= portclock_limit &&
> -	    hdmi_12bpc_possible(pipe_config)) {
> +	    hdmi_12bpc_possible(pipe_config) &&
> +	    0 /* FIXME 12bpc support totally broken */) {
>  		DRM_DEBUG_KMS("picking bpc to 12 for HDMI output\n");
>  		desired_bpp = 12*3;
>  


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Disable 12bpc hdmi for now

[Daniel Vetter]

On Thu, May 28, 2015 at 11:58:30AM +0300, Ander Conselvan De Oliveira wrote:
> On Thu, 2015-05-28 at 09:41 +0200, Daniel Vetter wrote:
> > It's totally broken, and since
> > 
> > commit d328c9d78d64ca11e744fe227096990430a88477
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date:   Fri Apr 10 16:22:37 2015 +0200
> > 
> >     drm/i915: Select starting pipe bpp irrespective or the primary plane
> > 
> > the kernel will try to use it even for the common rgb888 framebuffers.
> > Ville has patches to fix it all up properly, but unfortunately they're
> > stuck in review limbo. And since the 4.2 feature cutoff has passed we
> > need to somehow  handle this regression.
> 
> You might want to add
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90460

Done, thanks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx