From: Ander Conselvan De Oliveira <conselvan2@gmail.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't check modeset state in the hw state force restore path
Date: Tue, 02 Jun 2015 10:30:51 +0300 [thread overview]
Message-ID: <1433230251.2401.3.camel@gmail.com> (raw)
In-Reply-To: <556D5AC9.206@linux.intel.com>
On Tue, 2015-06-02 at 09:27 +0200, Maarten Lankhorst wrote:
> Op 02-06-15 om 09:12 schreef Jani Nikula:
> > On Mon, 01 Jun 2015, Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> wrote:
> >> Since the force restore logic will restore the CRTCs state one at a
> >> time, it is possible that the state will be inconsistent until the whole
> >> operation finishes. A call to intel_modeset_check_state() is done once
> >> it's over, so don't check the state multiple times in between. This
> >> regression was introduced in:
> >>
> >> commit 7f27126ea3db6ade886f18fd39caf0ff0cd1d37f
> >> Author: Jesse Barnes <jbarnes@virtuousgeek.org>
> >> Date: Wed Nov 5 14:26:06 2014 -0800
> >>
> >> drm/i915: factor out compute_config from __intel_set_mode v3
> >>
> >> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=94431
> >> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> >> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> >> ---
> >>
> >> Hi,
> >>
> >> This patch applies on top of nightly, but it is only relevant without
> >> Maarten's "drm/i915: Convert to atomic, part 2" series, because of the
> >> changes to the hw state read out and force restore logic.
> >>
> >> The regression exists since 3.19.
> > Sooo, I think this should be applied to fixes, with cc: stable v3.19+,
> > and IIUC Maarten's series makes this obsolete in dinq?
> >
> > Now we just need review... Maarten?
> >
> > BR,
> > Jani.
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> Looks good to me, but it will conflict with my own patch series. :(
I think it's fine to skip this for dinq, since we move to a single
modeset in the force restore path with your patch series. I just got
confused with what branch to base this on. Thanks for reviewing.
Ander
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-02 7:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 12:41 [PATCH] drm/i915: Don't check modeset state in the hw state force restore path Ander Conselvan de Oliveira
2015-06-01 12:45 ` Conselvan De Oliveira, Ander
2015-06-01 23:47 ` shuang.he
2015-06-02 7:12 ` Jani Nikula
2015-06-02 7:27 ` Maarten Lankhorst
2015-06-02 7:30 ` Ander Conselvan De Oliveira [this message]
2015-06-04 11:13 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433230251.2401.3.camel@gmail.com \
--to=conselvan2@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox