Re: [PATCH v2] tests/gem_storedw_batches_loop: add subtest for cached mappings

[Imre Deak <imre.deak@intel.com>]

On ma, 2015-06-08 at 18:09 +0100, Chris Wilson wrote:
> On Mon, Jun 08, 2015 at 08:07:29PM +0300, Imre Deak wrote:
> > v2:
> > - add a subtest for uncached mappings too for LLC platforms where the
> >   default is cached mapping (Chris)
> > 
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > ---
> >  tests/gem_storedw_batches_loop.c | 21 +++++++++++++++++++++
> >  1 file changed, 21 insertions(+)
> > 
> > diff --git a/tests/gem_storedw_batches_loop.c b/tests/gem_storedw_batches_loop.c
> > index dcc11a5..348f7e2 100644
> > --- a/tests/gem_storedw_batches_loop.c
> > +++ b/tests/gem_storedw_batches_loop.c
> > @@ -169,6 +169,27 @@ igt_main
> >  		store_dword_loop(5, SECURE_DISPATCH);
> >  	}
> >  
> > +	igt_subtest("cached-mapping") {
> > +		gem_set_caching(fd, target_bo->handle, 1);
> > +		store_dword_loop(1, 0);
> > +		store_dword_loop(2, 0);
> > +		store_dword_loop(3, 0);
> > +		store_dword_loop(5, 0);
> > +	}
> > +
> > +	igt_subtest("uncached-mapping") {
> > +		/*
> > +		 * On non-LLC platforms the default is non-cached, so on those
> > +		 * "normal" has covered already this case.
> > +		 */
> > +		igt_require(gem_has_llc(fd));
> 
> I wouldn't bother with the SKIP. Since there is a nice bit of interplay
> here with multiple calls to gem_set_caching() that may uncover a bug.

Ok, I'll remove the skip.

--Imre

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx