From: Todd Previte <tprevite@gmail.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/3] drm/i915: Displayport compliance test 4.2.2.9 support
Date: Tue, 9 Jun 2015 17:22:18 -0700 [thread overview]
Message-ID: <1433895740-13698-2-git-send-email-tprevite@gmail.com> (raw)
In-Reply-To: <1433895740-13698-1-git-send-email-tprevite@gmail.com>
Implement the fix for test 4.2.2.9. This test is a 4-block E-DDC
read over the AUX channel. For test purposes, the normal 1-block
EDID read is required to write the checksum of that block to the
sink device via the AUX channel. For 4.2.2.9, that checksum must
be the checksum of the last block read. The DRM EDID read code
already does the 4-block read, so the checksum just needs to be
adjusted to the one that we need based on the number of extensions
detected in the block.
Signed-off-by: Todd Previte <tprevite@gmail.com>
---
drivers/gpu/drm/i915/intel_dp.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index c7cbb67..14147d0 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4020,9 +4020,17 @@ static uint8_t intel_dp_autotest_edid(struct intel_dp *intel_dp)
intel_dp->aux.i2c_defer_count);
intel_dp->compliance_test_data = INTEL_DP_RESOLUTION_FAILSAFE;
} else {
+ /* Checksum write for EDID reads (DP CTS 1.2 Core r1.1)
+ * 4.2.2.3: checksum of EDID block 0
+ * 4.2.2.9: checksum of the last 128-byte block read
+ */
+ int checksum = *(&intel_connector->detect_edid->checksum +
+ (intel_connector->detect_edid->extensions *
+ EDID_LENGTH));
+
if (!drm_dp_dpcd_write(&intel_dp->aux,
DP_TEST_EDID_CHECKSUM,
- &intel_connector->detect_edid->checksum,
+ &checksum,
1))
DRM_DEBUG_KMS("Failed to write EDID checksum\n");
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-10 0:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 0:22 Add support for Displayport CTS 4.2.2.7, 4.2.2.8 and 4.2.2.9 Todd Previte
2015-06-10 0:22 ` Todd Previte [this message]
2015-06-15 15:37 ` [PATCH 1/3] drm/i915: Displayport compliance test 4.2.2.9 support Daniel Vetter
2015-06-15 15:50 ` Chris Wilson
2015-06-10 0:22 ` [PATCH 2/3] drm/i915: Displayport compliance test 4.2.2.7 support Todd Previte
2015-06-15 15:39 ` Daniel Vetter
2015-06-10 0:22 ` [PATCH 3/3] drm/i915: Displayport compliance test 4.2.2.8 support Todd Previte
2015-06-15 15:42 ` Daniel Vetter
2015-06-28 17:15 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433895740-13698-2-git-send-email-tprevite@gmail.com \
--to=tprevite@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox