From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 2/4] drm/i915: add FBC_ROTATION to enum no_fbc_reason
Date: Thu, 11 Jun 2015 16:02:25 -0300 [thread overview]
Message-ID: <1434049347-2100-3-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1434049347-2100-1-git-send-email-przanoni@gmail.com>
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
Because we're currently using FBC_UNSUPPORTED_MODE for two different
cases.
This commit will also allow us to write the next one without hiding
information from the user.
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 3 +++
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/intel_fbc.c | 2 +-
3 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 7358f6d..405022b 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -1632,6 +1632,9 @@ static int i915_fbc_status(struct seq_file *m, void *unused)
case FBC_CHIP_DEFAULT:
seq_puts(m, "disabled per chip default");
break;
+ case FBC_ROTATION:
+ seq_puts(m, "rotation not supported");
+ break;
default:
seq_puts(m, "unknown reason");
}
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 611fbd8..f9ff452 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -926,6 +926,7 @@ struct i915_fbc {
FBC_MULTIPLE_PIPES, /* more than one pipe active */
FBC_MODULE_PARAM,
FBC_CHIP_DEFAULT, /* disabled by default on this chip */
+ FBC_ROTATION, /* rotation is not supported */
} no_fbc_reason;
};
diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index 6abb834..43704a4 100644
--- a/drivers/gpu/drm/i915/intel_fbc.c
+++ b/drivers/gpu/drm/i915/intel_fbc.c
@@ -587,7 +587,7 @@ void intel_fbc_update(struct drm_device *dev)
}
if (INTEL_INFO(dev)->gen <= 4 && !IS_G4X(dev) &&
crtc->primary->state->rotation != BIT(DRM_ROTATE_0)) {
- if (set_no_fbc_reason(dev_priv, FBC_UNSUPPORTED_MODE))
+ if (set_no_fbc_reason(dev_priv, FBC_ROTATION))
DRM_DEBUG_KMS("Rotation unsupported, disabling\n");
goto out_disable;
}
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-11 19:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 19:02 [PATCH 0/4] FBC trivial patches Paulo Zanoni
2015-06-11 19:02 ` [PATCH 1/4] drm/i915: print FBC compression status on debugfs Paulo Zanoni
2015-06-12 12:01 ` Ville Syrjälä
2015-06-11 19:02 ` Paulo Zanoni [this message]
2015-06-11 19:02 ` [PATCH 3/4] drm/i915: unify no_fbc_reason message printing Paulo Zanoni
2015-06-12 9:02 ` Chris Wilson
2015-06-12 12:17 ` Damien Lespiau
2015-06-11 19:02 ` [PATCH 4/4] drm/i915: don't set the FBC plane select bits on HSW+ Paulo Zanoni
2015-06-12 9:00 ` Chris Wilson
2015-06-15 6:16 ` shuang.he
2015-06-12 9:03 ` [PATCH 0/4] FBC trivial patches Chris Wilson
2015-06-12 17:36 ` [PATCH 0/4] FBC trivial patches, V2 Paulo Zanoni
2015-06-12 17:36 ` [PATCH 1/4] drm/i915: print FBC compression status on debugfs Paulo Zanoni
2015-06-12 17:36 ` [PATCH 2/4] drm/i915: add FBC_ROTATION to enum no_fbc_reason Paulo Zanoni
2015-06-12 17:36 ` [PATCH 3/4] drm/i915: unify no_fbc_reason message printing Paulo Zanoni
2015-06-12 17:36 ` [PATCH 4/4] drm/i915: don't set the FBC plane select bits on HSW+ Paulo Zanoni
2015-06-12 17:42 ` [PATCH 0/4] FBC trivial patches, V2 Chris Wilson
2015-06-15 16:36 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434049347-2100-3-git-send-email-przanoni@gmail.com \
--to=przanoni@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox