From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 4/4] drm/i915: don't set the FBC plane select bits on HSW+
Date: Fri, 12 Jun 2015 14:36:21 -0300 [thread overview]
Message-ID: <1434130581-3864-5-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1434130581-3864-1-git-send-email-przanoni@gmail.com>
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
This commit is just to make the intentions explicit: on HSW+ these
bits are MBZ, but since we only support plane A and the macro
evaluates to zero when plane A is the parameter, we're not fixing any
bug.
v2:
- Remove useless extra blank like (Chris).
- Init dpfc_ctl in another place (Chris).
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
drivers/gpu/drm/i915/intel_fbc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index 1ff288c..50ed333 100644
--- a/drivers/gpu/drm/i915/intel_fbc.c
+++ b/drivers/gpu/drm/i915/intel_fbc.c
@@ -262,7 +262,10 @@ static void gen7_fbc_enable(struct drm_crtc *crtc)
dev_priv->fbc.enabled = true;
- dpfc_ctl = IVB_DPFC_CTL_PLANE(intel_crtc->plane);
+ dpfc_ctl = 0;
+ if (IS_IVYBRIDGE(dev))
+ dpfc_ctl |= IVB_DPFC_CTL_PLANE(intel_crtc->plane);
+
if (drm_format_plane_cpp(fb->pixel_format, 0) == 2)
dev_priv->fbc.threshold++;
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-12 17:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 19:02 [PATCH 0/4] FBC trivial patches Paulo Zanoni
2015-06-11 19:02 ` [PATCH 1/4] drm/i915: print FBC compression status on debugfs Paulo Zanoni
2015-06-12 12:01 ` Ville Syrjälä
2015-06-11 19:02 ` [PATCH 2/4] drm/i915: add FBC_ROTATION to enum no_fbc_reason Paulo Zanoni
2015-06-11 19:02 ` [PATCH 3/4] drm/i915: unify no_fbc_reason message printing Paulo Zanoni
2015-06-12 9:02 ` Chris Wilson
2015-06-12 12:17 ` Damien Lespiau
2015-06-11 19:02 ` [PATCH 4/4] drm/i915: don't set the FBC plane select bits on HSW+ Paulo Zanoni
2015-06-12 9:00 ` Chris Wilson
2015-06-15 6:16 ` shuang.he
2015-06-12 9:03 ` [PATCH 0/4] FBC trivial patches Chris Wilson
2015-06-12 17:36 ` [PATCH 0/4] FBC trivial patches, V2 Paulo Zanoni
2015-06-12 17:36 ` [PATCH 1/4] drm/i915: print FBC compression status on debugfs Paulo Zanoni
2015-06-12 17:36 ` [PATCH 2/4] drm/i915: add FBC_ROTATION to enum no_fbc_reason Paulo Zanoni
2015-06-12 17:36 ` [PATCH 3/4] drm/i915: unify no_fbc_reason message printing Paulo Zanoni
2015-06-12 17:36 ` Paulo Zanoni [this message]
2015-06-12 17:42 ` [PATCH 0/4] FBC trivial patches, V2 Chris Wilson
2015-06-15 16:36 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434130581-3864-5-git-send-email-przanoni@gmail.com \
--to=przanoni@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox