From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH 1/3] drm/i915: Don't check modeset state in the hw state force restore path Date: Tue, 16 Jun 2015 11:54:01 +0300 Message-ID: <1434444841.9250.2.camel@gmail.com> References: <1434093582-5824-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1434093582-5824-2-git-send-email-ander.conselvan.de.oliveira@intel.com> <20150616020046.GK13852@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pd0-f177.google.com (mail-pd0-f177.google.com [209.85.192.177]) by gabe.freedesktop.org (Postfix) with ESMTP id B52A688A56 for ; Tue, 16 Jun 2015 01:54:05 -0700 (PDT) Received: by pdbnf5 with SMTP id nf5so9873077pdb.2 for ; Tue, 16 Jun 2015 01:54:05 -0700 (PDT) In-Reply-To: <20150616020046.GK13852@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMDE1LTA2LTE1IGF0IDE5OjAwIC0wNzAwLCBNYXR0IFJvcGVyIHdyb3RlOgo+IE9u IEZyaSwgSnVuIDEyLCAyMDE1IGF0IDEwOjE5OjQwQU0gKzAzMDAsIEFuZGVyIENvbnNlbHZhbiBk ZSBPbGl2ZWlyYSB3cm90ZToKPiA+IFNpbmNlIHRoZSBmb3JjZSByZXN0b3JlIGxvZ2ljIHdpbGwg cmVzdG9yZSB0aGUgQ1JUQ3Mgc3RhdGUgb25lIGF0IGEKPiA+IHRpbWUsIGl0IGlzIHBvc3NpYmxl IHRoYXQgdGhlIHN0YXRlIHdpbGwgYmUgaW5jb25zaXN0ZW50IHVudGlsIHRoZSB3aG9sZQo+ID4g b3BlcmF0aW9uIGZpbmlzaGVzLiBBIGNhbGwgdG8gaW50ZWxfbW9kZXNldF9jaGVja19zdGF0ZSgp IGlzIGRvbmUgb25jZQo+ID4gaXQncyBvdmVyLCBzbyBkb24ndCBjaGVjayB0aGUgc3RhdGUgbXVs dGlwbGUgdGltZXMgaW4gYmV0d2Vlbi4gVGhpcwo+ID4gcmVncmVzc2lvbiB3YXMgaW50cm9kdWNl ZCBpbjoKPiA+IAo+ID4gY29tbWl0IDdmMjcxMjZlYTNkYjZhZGU4ODZmMThmZDM5Y2FmMGZmMGNk MWQzN2YKPiA+IEF1dGhvcjogSmVzc2UgQmFybmVzIDxqYmFybmVzQHZpcnR1b3VzZ2Vlay5vcmc+ Cj4gPiBEYXRlOiAgIFdlZCBOb3YgNSAxNDoyNjowNiAyMDE0IC0wODAwCj4gPiAKPiA+ICAgICBk cm0vaTkxNTogZmFjdG9yIG91dCBjb21wdXRlX2NvbmZpZyBmcm9tIF9faW50ZWxfc2V0X21vZGUg djMKPiA+IAo+ID4gQnVnemlsbGE6IGh0dHBzOi8vYnVnemlsbGEua2VybmVsLm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTQ0MzEKPiA+IENjOiBKZXNzZSBCYXJuZXMgPGpiYXJuZXNAdmlydHVvdXNnZWVr Lm9yZz4KPiA+IFNpZ25lZC1vZmYtYnk6IEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2ZWlyYSA8YW5k ZXIuY29uc2VsdmFuLmRlLm9saXZlaXJhQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDIxICsrKysrKysrKysrKy0tLS0tLS0tLQo+ ID4gIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+ID4g Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBpbmRleCA0ZTNmMzAyLi42 ZWY1N2U2IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IEBA IC04Nyw3ICs4Nyw4IEBAIHN0YXRpYyB2b2lkIGlyb25sYWtlX3BjaF9jbG9ja19nZXQoc3RydWN0 IGludGVsX2NydGMgKmNydGMsCj4gPiAgCQkJCSAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpw aXBlX2NvbmZpZyk7Cj4gPiAgCj4gPiAgc3RhdGljIGludCBpbnRlbF9zZXRfbW9kZShzdHJ1Y3Qg ZHJtX2NydGMgKmNydGMsCj4gPiAtCQkJICBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUp Owo+ID4gKwkJCSAgc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ID4gKwkJCSAgYm9v bCBjaGVjayk7Cj4gPiAgc3RhdGljIGludCBpbnRlbF9mcmFtZWJ1ZmZlcl9pbml0KHN0cnVjdCBk cm1fZGV2aWNlICpkZXYsCj4gPiAgCQkJCSAgc3RydWN0IGludGVsX2ZyYW1lYnVmZmVyICppZmIs Cj4gPiAgCQkJCSAgc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgKm1vZGVfY21kLAo+ID4gQEAgLTEw MDk2LDcgKzEwMDk3LDcgQEAgcmV0cnk6Cj4gPiAgCj4gPiAgCWRybV9tb2RlX2NvcHkoJmNydGNf c3RhdGUtPmJhc2UubW9kZSwgbW9kZSk7Cj4gPiAgCj4gPiAtCWlmIChpbnRlbF9zZXRfbW9kZShj cnRjLCBzdGF0ZSkpIHsKPiA+ICsJaWYgKGludGVsX3NldF9tb2RlKGNydGMsIHN0YXRlLCB0cnVl KSkgewo+ID4gIAkJRFJNX0RFQlVHX0tNUygiZmFpbGVkIHRvIHNldCBtb2RlIG9uIGxvYWQtZGV0 ZWN0IHBpcGVcbiIpOwo+ID4gIAkJaWYgKG9sZC0+cmVsZWFzZV9mYikKPiA+ICAJCQlvbGQtPnJl bGVhc2VfZmItPmZ1bmNzLT5kZXN0cm95KG9sZC0+cmVsZWFzZV9mYik7Cj4gPiBAQCAtMTAxNzAs NyArMTAxNzEsNyBAQCB2b2lkIGludGVsX3JlbGVhc2VfbG9hZF9kZXRlY3RfcGlwZShzdHJ1Y3Qg ZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ID4gIAkJaWYgKHJldCkKPiA+ICAJCQlnb3RvIGZh aWw7Cj4gPiAgCj4gPiAtCQlyZXQgPSBpbnRlbF9zZXRfbW9kZShjcnRjLCBzdGF0ZSk7Cj4gPiAr CQlyZXQgPSBpbnRlbF9zZXRfbW9kZShjcnRjLCBzdGF0ZSwgdHJ1ZSk7Cj4gPiAgCQlpZiAocmV0 KQo+ID4gIAkJCWdvdG8gZmFpbDsKPiA+ICAKPiA+IEBAIC0xMjY0NiwyMCArMTI2NDcsMjIgQEAg c3RhdGljIGludCBfX2ludGVsX3NldF9tb2RlKHN0cnVjdCBkcm1fY3J0YyAqbW9kZXNldF9jcnRj LAo+ID4gIH0KPiA+ICAKPiA+ICBzdGF0aWMgaW50IGludGVsX3NldF9tb2RlX3dpdGhfY29uZmln KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiA+IC0JCQkJICAgICAgc3RydWN0IGludGVsX2NydGNf c3RhdGUgKnBpcGVfY29uZmlnKQo+ID4gKwkJCQkgICAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0 ZSAqcGlwZV9jb25maWcsCj4gPiArCQkJCSAgICAgIGJvb2wgY2hlY2spCj4gCj4gVGhpcyBwYXJh bWV0ZXIganVzdCBjb250cm9scyB3aGV0aGVyIHlvdSBjaGVjayB0aGUgc3RhdGUgb3Igbm90IGlu IHRoaXMKPiBwYXRjaCwgYnV0IGluIHBhdGNoICMyIGl0IGFsc28gc3RhcnRzIGhhdmluZyBtb3Jl IG9mIGEgYmVoYXZpb3JhbCBpbXBhY3QKPiAoaS5lLiwgImRvbid0IHVwZGF0ZWQgc3RhZ2VkIG91 dHB1dCBjb25maWd1cmF0aW9uIikuICBJIHdvbmRlciBpZgo+IHBpY2tpbmcgYSBkaWZmZXJlbnQg bmFtZSBmb3IgdGhpcyBwYXJhbWV0ZXIgd291bGQgaGVscCBhdm9pZCBhbnkKPiBjb25mdXNpb24/ CgpUaGFua3MgZm9yIHJldmlld2luZyEgSSBqdXN0IHNlbnQgYSB2MiB3aXRoIHRoZSBwYXJhbWV0 ZXIgbmFtZSBjaGFuZ2VkCnRvIGZvcmNlX3Jlc3RvcmUgYW5kIHRoZSBtZW1vcnkgbGVhayBmaXhl ZC4KCj4gT3RoZXJ3aXNlLCB0aGlzIHBhdGNoIGxvb2tzIGdvb2Q6Cj4gICAgUmV2aWV3ZWQtYnk6 IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gCj4gT2ZmLXRvcGljLCBi dXQgc3BlYWtpbmcgb2YgJ2NoZWNrJyBJIHdvbmRlciB3aGV0aGVyIHdlIHNob3VsZCBhbHNvCj4g cmVuYW1lIHRoZSBpbnRlbF9tb2Rlc2V0X2NoZWNrX3N0YXRlIGZ1bmN0aW9uIGFuZCByZWxhdGVk IGZ1bmN0aW9ucyBhdAo+IHNvbWUgcG9pbnQgaW4gdGhlIGZ1dHVyZS4gIEV2ZXJ5IHRpbWUgSSBz ZWUgdGhhdCBuYW1lIGluIHRoZSBjb2RlIGl0Cj4gYm90aGVycyBtZSBiZWNhdXNlIEkgZXhwZWN0 IGl0IHRvIGJlIHJlbGF0ZWQgdG8gYXRvbWljIGNoZWNrIChpLmUuLAo+IHNvbWV0aGluZyB0aGF0 IHJ1bnMgYmVmb3JlIHdlIHRvdWNoIGhhcmR3YXJlKSByYXRoZXIgdGhhbiBjb25maXJtaW5nCj4g dGhhdCBoYXJkd2FyZSBwcm9ncmFtbWluZyB3YXMgc3VjY2Vzc2Z1bC4gIEl0IGZlZWxzIG1vcmUg bGlrZSBhbgo+IGFzc2VydC9jb25maXJtL3ZlcmlmeSBmdW5jdGlvbiB0byBtZS4KCkknbSBub3Qg c3VyZSB3aGF0IHdvdWxkIGJlIGEgYmV0dGVyIG5hbWUsIGJ1dCBJIGFncmVlIHRoZSBjdXJyZW50 IG9uZSBpcwpjb25mdXNpbmcuCgpBbmRlcgoKPiAKPiBNYXR0Cj4gCj4gPiAgewo+ID4gIAlpbnQg cmV0Owo+ID4gIAo+ID4gIAlyZXQgPSBfX2ludGVsX3NldF9tb2RlKGNydGMsIHBpcGVfY29uZmln KTsKPiA+ICAKPiA+IC0JaWYgKHJldCA9PSAwKQo+ID4gKwlpZiAocmV0ID09IDAgJiYgY2hlY2sp Cj4gPiAgCQlpbnRlbF9tb2Rlc2V0X2NoZWNrX3N0YXRlKGNydGMtPmRldik7Cj4gPiAgCj4gPiAg CXJldHVybiByZXQ7Cj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyBpbnQgaW50ZWxfc2V0X21vZGUo c3RydWN0IGRybV9jcnRjICpjcnRjLAo+ID4gLQkJCSAgc3RydWN0IGRybV9hdG9taWNfc3RhdGUg KnN0YXRlKQo+ID4gKwkJCSAgc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ID4gKwkJ CSAgYm9vbCBjaGVjaykKPiA+ICB7Cj4gPiAgCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBl X2NvbmZpZzsKPiA+ICAJaW50IHJldCA9IDA7Cj4gPiBAQCAtMTI2NzAsNyArMTI2NzMsNyBAQCBz dGF0aWMgaW50IGludGVsX3NldF9tb2RlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiA+ICAJCWdv dG8gb3V0Owo+ID4gIAl9Cj4gPiAgCj4gPiAtCXJldCA9IGludGVsX3NldF9tb2RlX3dpdGhfY29u ZmlnKGNydGMsIHBpcGVfY29uZmlnKTsKPiA+ICsJcmV0ID0gaW50ZWxfc2V0X21vZGVfd2l0aF9j b25maWcoY3J0YywgcGlwZV9jb25maWcsIGNoZWNrKTsKPiA+ICAJaWYgKHJldCkKPiA+ICAJCWdv dG8gb3V0Owo+ID4gIAo+ID4gQEAgLTEyNzQ3LDcgKzEyNzUwLDcgQEAgdm9pZCBpbnRlbF9jcnRj X3Jlc3RvcmVfbW9kZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gPiAgCWludGVsX21vZGVzZXRf c2V0dXBfcGxhbmVfc3RhdGUoc3RhdGUsIGNydGMsICZjcnRjLT5tb2RlLAo+ID4gIAkJCQkJY3J0 Yy0+cHJpbWFyeS0+ZmIsIGNydGMtPngsIGNydGMtPnkpOwo+ID4gIAo+ID4gLQlyZXQgPSBpbnRl bF9zZXRfbW9kZShjcnRjLCBzdGF0ZSk7Cj4gPiArCXJldCA9IGludGVsX3NldF9tb2RlKGNydGMs IHN0YXRlLCBmYWxzZSk7Cj4gPiAgCWlmIChyZXQpCj4gPiAgCQlkcm1fYXRvbWljX3N0YXRlX2Zy ZWUoc3RhdGUpOwo+ID4gIH0KPiA+IEBAIC0xMjk0Nyw3ICsxMjk1MCw3IEBAIHN0YXRpYyBpbnQg aW50ZWxfY3J0Y19zZXRfY29uZmlnKHN0cnVjdCBkcm1fbW9kZV9zZXQgKnNldCkKPiA+ICAKPiA+ ICAJcHJpbWFyeV9wbGFuZV93YXNfdmlzaWJsZSA9IHByaW1hcnlfcGxhbmVfdmlzaWJsZShzZXQt PmNydGMpOwo+ID4gIAo+ID4gLQlyZXQgPSBpbnRlbF9zZXRfbW9kZV93aXRoX2NvbmZpZyhzZXQt PmNydGMsIHBpcGVfY29uZmlnKTsKPiA+ICsJcmV0ID0gaW50ZWxfc2V0X21vZGVfd2l0aF9jb25m aWcoc2V0LT5jcnRjLCBwaXBlX2NvbmZpZywgdHJ1ZSk7Cj4gPiAgCj4gPiAgCWlmIChyZXQgPT0g MCAmJgo+ID4gIAkgICAgcGlwZV9jb25maWctPmJhc2UuZW5hYmxlICYmCj4gPiAtLSAKPiA+IDIu MS4wCj4gPiAKPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK