Re: [PATCH 2/4] i915: add support for GPU side of MST audio

Chris Wilson
2015-06-17T08:07:36Z

On Wed, Jun 17, 2015 at 02:01:57PM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> This just adds enables for the codecs and debugfs
> support for mst connectors to print the audio info.
>
> This relies on patches to the audio code to do anything
> more useful.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> ---
> @@ -231,6 +231,7 @@ static void hsw_audio_codec_enable(struct drm_connector *connector,
> /* Reset ELD write address */
> tmp = I915_READ(HSW_AUD_DIP_ELD_CTRL(pipe));
> tmp &= ~IBX_ELD_ADDRESS_MASK;
> + tmp |= ((pipe + 1) << 29);
> I915_WRITE(HSW_AUD_DIP_ELD_CTRL(pipe), tmp);

This is not MST specific. Is this a bug fix we want ASAP?
-Chris

--
Chris Wilson, Intel Open Source Technology Centre