From: Dave Airlie <airlied@gmail.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 4/4] snd/hdmi: hack out haswell codec workaround
Date: Wed, 17 Jun 2015 14:01:59 +1000 [thread overview]
Message-ID: <1434513719-3580-5-git-send-email-airlied@gmail.com> (raw)
In-Reply-To: <1434513719-3580-1-git-send-email-airlied@gmail.com>
From: Dave Airlie <airlied@redhat.com>
This breaks MST audio, as it appears the hw doesn't
operate like the code believes.
What seems to happen if we have 3 pins, 5, 6, 7
and 6 is connected to 3 devices and 5/7 are connected
to 0 devices, then devices 5/7 act always as if they
are equivalent to pin 6 device 0.
So I connected pin 6 device 0 to channel 1, then
this code goes and connects pin 5/7 to channel 0
but this actually reprograms pin 6 device 0 to channel
0 at the same time and breaks audio.
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
sound/pci/hda/patch_hdmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 8272656..7a4aeac 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -1411,6 +1411,7 @@ static void intel_not_share_assigned_cvt(struct hda_codec *codec,
int cvt_idx, curr;
struct hdmi_spec_per_cvt *per_cvt;
+ return;
/* configure all pins, including "no physical connection" ones */
for_each_hda_codec_node(nid, codec) {
unsigned int wid_caps = get_wcaps(codec, nid);
--
2.4.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-06-17 4:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 4:01 haswell displayport MST audio support Dave Airlie
2015-06-17 4:01 ` [PATCH 1/4] dp/mst: add SDP stream support Dave Airlie
2015-06-17 4:01 ` [PATCH 2/4] i915: add support for GPU side of MST audio Dave Airlie
2015-06-17 8:07 ` Chris Wilson
2015-06-17 11:54 ` Jani Nikula
2015-06-17 11:56 ` Jani Nikula
2015-06-19 6:27 ` Lin, Mengdong
2015-06-17 11:27 ` Daniel Vetter
2015-06-17 4:01 ` [PATCH 3/4] snd: add support for displayport multi-stream to hda codec Dave Airlie
2015-06-19 9:54 ` Lin, Mengdong
2015-06-19 10:33 ` Dave Airlie
2015-06-19 11:15 ` Takashi Iwai
2015-06-22 12:54 ` Daniel Vetter
2015-06-22 13:23 ` Takashi Iwai
2015-06-22 13:29 ` Liam Girdwood
2015-06-22 15:21 ` Kaskinen, Tanu
2015-06-22 15:44 ` Takashi Iwai
2015-06-23 7:51 ` [Intel-gfx] " Kaskinen, Tanu
2015-06-23 8:06 ` Takashi Iwai
2015-06-24 12:41 ` [Intel-gfx] " Kaskinen, Tanu
2015-06-24 13:06 ` [alsa-devel] " Liam Girdwood
2015-06-24 20:47 ` Kaskinen, Tanu
2015-06-25 9:44 ` [alsa-devel] " Liam Girdwood
2015-06-26 10:14 ` [alsa-devel] [Intel-gfx] " Kaskinen, Tanu
2015-06-26 10:50 ` Kaskinen, Tanu
2015-06-26 18:45 ` Liam Girdwood
2015-06-26 16:27 ` [Intel-gfx] " Kaskinen, Tanu
2015-06-27 6:09 ` [alsa-devel] " Raymond Yau
2015-06-29 8:00 ` Jani Nikula
2015-07-03 3:45 ` Raymond Yau
2015-07-03 8:54 ` Jani Nikula
2015-06-25 8:22 ` Raymond Yau
2015-06-25 12:52 ` David Weinehall
2015-06-17 4:01 ` Dave Airlie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434513719-3580-5-git-send-email-airlied@gmail.com \
--to=airlied@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox