public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Liu, Hong" <hong.liu@intel.com>
To: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"maarten.lankhorst@linux.intel.com"
	<maarten.lankhorst@linux.intel.com>
Subject: Re: [PATCH] drm/atomic: free state in atomic ioctl if atomic commit failed
Date: Fri, 26 Jun 2015 00:27:52 +0000	[thread overview]
Message-ID: <1435278497.1454.1.camel@intel.com> (raw)
In-Reply-To: <558BD067.7020304@linux.intel.com>

On Thu, 2015-06-25 at 11:56 +0200, Maarten Lankhorst wrote:
> Hey,
> 
> Op 25-06-15 om 11:25 schreef Liu, Hong:
> > atomic commit only frees the state if no error met, caller needs to
> > free the allocated state if atomic commit failed.
> > 
> > Signed-off-by: Hong Liu <hong.liu@intel.com>
> > ---
> >  drivers/gpu/drm/drm_atomic.c |    3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_atomic.c 
> > b/drivers/gpu/drm/drm_atomic.c
> > index 6e3b78e..aa8ad4c 100644
> > --- a/drivers/gpu/drm/drm_atomic.c
> > +++ b/drivers/gpu/drm/drm_atomic.c
> > @@ -1344,6 +1344,9 @@ retry:
> >  		}
> >  	}
> >  
> > +	if (ret && !(arg->flags & DRM_MODE_ATOMIC_TEST_ONLY))
> > +		goto fail;
> > +
> >  	drm_modeset_drop_locks(&ctx);
> >  	drm_modeset_acquire_fini(&ctx);
> "[PATCH 2/2] drm/atomic: Cleanup on error properly in the atomic 
> ioctl." fixes it too.

I didn't notice the patch, thanks for the reminder.

Thanks,
Hong

> 
> ~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2015-06-26  0:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25  9:25 [PATCH] drm/atomic: free state in atomic ioctl if atomic commit failed Liu, Hong
2015-06-25  9:56 ` Maarten Lankhorst
2015-06-26  0:27   ` Liu, Hong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435278497.1454.1.camel@intel.com \
    --to=hong.liu@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox