From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 0/8] FBC locking v3
Date: Tue, 30 Jun 2015 10:53:04 -0300 [thread overview]
Message-ID: <1435672392-7329-1-git-send-email-przanoni@gmail.com> (raw)
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
Hi
So this is a new take on the FBC locking improvements. This time I continue with
the "introduce fbc.lock first, then reduce struct_mutex later" strategy in order
to minimize the risks and facilitate review.
I also fixed a "lack of struct_mutex lock" regression I introduced when I first
moved FBC to the frontbuffer tracking infrastructure.
Right now the only places where we should be holding the struct_mutex lock for
FBC is on the 2 intel_fbc_update() calls: one at intel_post_plane_update() and
another at intel_unpin_work_fn(). Notice that we'll probably remove the
intel_fbc_update() call that's inside intel_unpin_work_fn() later, so we'll only
required struct_mutex locking once. We can't get rid of the single struct_mutex
lock requirement since we need to deal with the CFB allocation. Of course we can
always rework that code a little bit more, but let's do it on later patches.
Thanks,
Paulo
Paulo Zanoni (8):
drm/i915: don't increment the FBC threshold at fbc_enable
drm/i915: add the FBC mutex
drm/i915: remove unneded locks on debugs FBC functions
drm/i915: remove struct_mutex lock from the FBC work function
drm/i915: simplify FBC start/stop at invalidate/flush
drm/i915: add struct_mutex WARNs to i915_gem_stolen.c
drm/i915: reduce struct_mutex coverage at intel_crtc_page_flip()
drm/i915: remove struct_mutex lock from intel_modeset_cleanup()
drivers/gpu/drm/i915/i915_debugfs.c | 8 +--
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_gem_stolen.c | 20 ++++++
drivers/gpu/drm/i915/intel_display.c | 16 +----
drivers/gpu/drm/i915/intel_drv.h | 1 +
drivers/gpu/drm/i915/intel_fbc.c | 110 +++++++++++++++++++++++++++------
6 files changed, 120 insertions(+), 36 deletions(-)
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2015-06-30 13:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 13:53 Paulo Zanoni [this message]
2015-06-30 13:53 ` [PATCH 1/8] drm/i915: don't increment the FBC threshold at fbc_enable Paulo Zanoni
2015-06-30 14:22 ` Chris Wilson
2015-07-01 13:52 ` Daniel Vetter
2015-06-30 13:53 ` [PATCH 2/8] drm/i915: add the FBC mutex Paulo Zanoni
2015-06-30 14:10 ` Chris Wilson
2015-06-30 14:12 ` Chris Wilson
2015-06-30 14:25 ` Chris Wilson
2015-06-30 14:34 ` Paulo Zanoni
2015-06-30 13:53 ` [PATCH 3/8] drm/i915: remove unneded locks on debugs FBC functions Paulo Zanoni
2015-06-30 13:53 ` [PATCH 4/8] drm/i915: remove struct_mutex lock from the FBC work function Paulo Zanoni
2015-06-30 13:53 ` [PATCH 5/8] drm/i915: simplify FBC start/stop at invalidate/flush Paulo Zanoni
2015-06-30 14:34 ` Chris Wilson
2015-06-30 21:12 ` Paulo Zanoni
2015-07-01 14:04 ` Chris Wilson
2015-06-30 13:53 ` [PATCH 6/8] drm/i915: add struct_mutex WARNs to i915_gem_stolen.c Paulo Zanoni
2015-06-30 14:15 ` Chris Wilson
2015-06-30 14:26 ` Paulo Zanoni
2015-06-30 14:36 ` Chris Wilson
2015-06-30 20:30 ` Jesse Barnes
2015-06-30 21:00 ` Chris Wilson
2015-07-01 13:56 ` Daniel Vetter
2015-07-01 15:17 ` Jesse Barnes
2015-07-01 15:43 ` Daniel Vetter
2015-06-30 14:34 ` Chris Wilson
2015-07-01 14:00 ` Daniel Vetter
2015-07-01 14:02 ` Chris Wilson
2015-07-01 14:03 ` Paulo Zanoni
2015-06-30 13:53 ` [PATCH 7/8] drm/i915: reduce struct_mutex coverage at intel_crtc_page_flip() Paulo Zanoni
2015-06-30 13:53 ` [PATCH 8/8] drm/i915: remove struct_mutex lock from intel_modeset_cleanup() Paulo Zanoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435672392-7329-1-git-send-email-przanoni@gmail.com \
--to=przanoni@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox