Re: [PATCH 2/7] drm/i915: move FBC code out of i915_gem_stolen.c

Chris Wilson
2015-07-01T20:44:37Z

On Wed, Jul 01, 2015 at 05:15:21PM -0300, Paulo Zanoni wrote:

Looks much cleaner with the split.

> +void intel_fbc_cleanup_cfb(struct drm_device *dev)
> +{
> + struct drm_i915_private *dev_priv = dev->dev_private;
> +
> + if (dev_priv->fbc.uncompressed_size == 0)
> + return;
> +
> + i915_gem_stolen_remove_node(&dev_priv->fbc.compressed_fb);
> +
> + if (dev_priv->fbc.compressed_llb) {
> + i915_gem_stolen_remove_node(dev_priv->fbc.compressed_llb);
> + kfree(dev_priv->fbc.compressed_llb);
> + }

Any reason why one node is embedded and the other allocated? Just feels
a little inconsistent, so lacks an explanation. Just that one is always
used, and the other on rare gen would probably suffice.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre