From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Stone Subject: Re: [PATCH] drm/crtc-helper: Fixup error handling in drm_helper_crtc_mode_set Date: Thu, 02 Jul 2015 10:01:31 +0100 Message-ID: <1435827691.5668.1.camel@collabora.com> References: <1435821829-11107-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1435821829-11107-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , DRI Development Cc: Daniel Vetter , Intel Graphics Development , John Hunter List-Id: intel-gfx@lists.freedesktop.org SGksCgpPbiBUaHUsIDIwMTUtMDctMDIgYXQgMDk6MjMgKzAyMDAsIERhbmllbCBWZXR0ZXIgd3Jv dGU6Cj4gSW4KPiAKPiBjb21taXQgOWY2NThiN2I2MmU3YWVmYzFlZTA2NzEzNjEyNmVjYTNmNThj YWJmZAo+IEF1dGhvcjogRGFuaWVsIFN0b25lIDxkYW5pZWxzQGNvbGxhYm9yYS5jb20+Cj4gRGF0 ZTogICBGcmkgTWF5IDIyIDEzOjM0OjQ1IDIwMTUgKzAxMDAKPiAKPiAgICAgZHJtL2NydGNfaGVs cGVyOiBSZXBsYWNlIG9wZW4tY29kZWQgQ1JUQyBzdGF0ZSBoZWxwZXJzCj4gCj4gZXJyb3IgaGFu ZGxpbmcgY29kZSB3YXMgYnJva2VuLCByZXN1bHRpbmcgaW4gdGhlIGZpcnN0IHBhdGggbm90IGJl aW5nCj4gY2hlY2tlZCBjb3JyZWN0bHkuIEZpeCB0aGlzIGJ5IHVzaW5nIHRoZSBzYW1lIHBhdHRl cm4gYXMgaW4gdGhlCj4gdHJhbnNpdGlvbmFsIHBsYW5lIGhlbHBlciBmdW5jdGlvbiBkcm1fcGxh bmVfaGVscGVyX3VwZGF0ZS4KPiAKPiBAQCAtOTI3LDE1ICs5MjcsMTMgQEAgaW50IGRybV9oZWxw ZXJfY3J0Y19tb2RlX3NldChzdHJ1Y3QgZHJtX2NydGMKPiAqY3J0Yywgc3RydWN0IGRybV9kaXNw bGF5X21vZGUgKm1vZAo+ICAKPiAgCWlmIChjcnRjLT5mdW5jcy0+YXRvbWljX2R1cGxpY2F0ZV9z dGF0ZSkKPiAgCQljcnRjX3N0YXRlID0gY3J0Yy0+ZnVuY3MKPiAtPmF0b21pY19kdXBsaWNhdGVf c3RhdGUoY3J0Yyk7Cj4gLQllbHNlIHsKPiArCWVsc2UgaWYgKGNydGMtPnN0YXRlKQo+ICsJCWNy dGNfc3RhdGUgPSAKPiBkcm1fYXRvbWljX2hlbHBlcl9jcnRjX2R1cGxpY2F0ZV9zdGF0ZShjcnRj KTsKPiArCWVsc2UKPiAgCQljcnRjX3N0YXRlID0ga3phbGxvYyhzaXplb2YoKmNydGNfc3RhdGUp LCAKPiBHRlBfS0VSTkVMKTsKPiAtCQlpZiAoIWNydGNfc3RhdGUpCj4gLQkJCXJldHVybiAtRU5P TUVNOwo+IC0JCWlmIChjcnRjLT5zdGF0ZSkKPiAtCQkJX19kcm1fYXRvbWljX2hlbHBlcl9jcnRj X2R1cGxpY2F0ZV9zdGF0ZShjcnQKPiBjLCBjcnRjX3N0YXRlKTsKPiAtCQllbHNlCj4gLQkJCWNy dGNfc3RhdGUtPmNydGMgPSBjcnRjOwoKSXNuJ3QgdGhpcyBsaW5lICh0aGUgY3J0Y19zdGF0ZS0+ Y3J0YykgYXNzaWdubWVudCBub3cgbWlzc2luZyBmcm9tIHRoZQpremFsbG9jIGJyYW5jaD8KCldp dGggdGhhdCBmaXhlZDoKUmV2aWV3ZWQtYnk6IERhbmllbCBTdG9uZSA8ZGFuaWVsc0Bjb2xsYWJv cmEuY29tPgoKQ2hlZXJzLApEYW5pZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK