* linux-4.2-rc1/drivers/gpu/drm/i915/intel_csr.c:353: bad if statement ?
@ 2015-07-07 10:51 David Binderman
2015-07-07 14:33 ` Imre Deak
0 siblings, 1 reply; 3+ messages in thread
From: David Binderman @ 2015-07-07 10:51 UTC (permalink / raw)
To: Daniel Vetter, Jani Nikula, intel-gfx@lists.freedesktop.org
Hello there,
[linux-4.2-rc1/drivers/gpu/drm/i915/intel_csr.c:353]: (warning) Logical conjunction always evaluates to false: EXPR < 524288 && EXPR> 589823.
Source code is
if (dmc_header->mmioaddr[i] < CSR_MMIO_START_RANGE &&
dmc_header->mmioaddr[i]> CSR_MMIO_END_RANGE) {
Maybe better code
if (dmc_header->mmioaddr[i] < CSR_MMIO_START_RANGE ||
dmc_header->mmioaddr[i]> CSR_MMIO_END_RANGE) {
Regards
David Binderman
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: linux-4.2-rc1/drivers/gpu/drm/i915/intel_csr.c:353: bad if statement ? 2015-07-07 10:51 linux-4.2-rc1/drivers/gpu/drm/i915/intel_csr.c:353: bad if statement ? David Binderman @ 2015-07-07 14:33 ` Imre Deak 2015-07-08 5:32 ` Manna, Animesh 0 siblings, 1 reply; 3+ messages in thread From: Imre Deak @ 2015-07-07 14:33 UTC (permalink / raw) To: David Binderman, Animesh Manna Cc: Daniel Vetter, intel-gfx@lists.freedesktop.org On ti, 2015-07-07 at 10:51 +0000, David Binderman wrote: > Hello there, > > [linux-4.2-rc1/drivers/gpu/drm/i915/intel_csr.c:353]: (warning) Logical conjunction always evaluates to false: EXPR < 524288 && EXPR> 589823. > > Source code is > > if (dmc_header->mmioaddr[i] < CSR_MMIO_START_RANGE && > dmc_header->mmioaddr[i]> CSR_MMIO_END_RANGE) { > > Maybe better code > > if (dmc_header->mmioaddr[i] < CSR_MMIO_START_RANGE || > dmc_header->mmioaddr[i]> CSR_MMIO_END_RANGE) { > > Regards > > David Binderman Thanks for reporting it, review fail on my side. Animesh could you send a patch to fix this up? Thanks, Imre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-4.2-rc1/drivers/gpu/drm/i915/intel_csr.c:353: bad if statement ? 2015-07-07 14:33 ` Imre Deak @ 2015-07-08 5:32 ` Manna, Animesh 0 siblings, 0 replies; 3+ messages in thread From: Manna, Animesh @ 2015-07-08 5:32 UTC (permalink / raw) To: Deak, Imre, David Binderman Cc: Vetter, Daniel, intel-gfx@lists.freedesktop.org Sure I will send a patch correcting the condition. Regards, Animesh -----Original Message----- From: Deak, Imre Sent: Tuesday, July 7, 2015 8:03 PM To: David Binderman; Manna, Animesh Cc: Vetter, Daniel; Jani Nikula; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] linux-4.2-rc1/drivers/gpu/drm/i915/intel_csr.c:353: bad if statement ? On ti, 2015-07-07 at 10:51 +0000, David Binderman wrote: > Hello there, > > [linux-4.2-rc1/drivers/gpu/drm/i915/intel_csr.c:353]: (warning) Logical conjunction always evaluates to false: EXPR < 524288 && EXPR> 589823. > > Source code is > > if (dmc_header->mmioaddr[i] < CSR_MMIO_START_RANGE && > dmc_header->mmioaddr[i]> CSR_MMIO_END_RANGE) { > > Maybe better code > > if (dmc_header->mmioaddr[i] < CSR_MMIO_START_RANGE || > dmc_header->mmioaddr[i]> CSR_MMIO_END_RANGE) { > > Regards > > David Binderman Thanks for reporting it, review fail on my side. Animesh could you send a patch to fix this up? Thanks, Imre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-08 5:32 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-07-07 10:51 linux-4.2-rc1/drivers/gpu/drm/i915/intel_csr.c:353: bad if statement ? David Binderman 2015-07-07 14:33 ` Imre Deak 2015-07-08 5:32 ` Manna, Animesh
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox