From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 4/6] drm/i915: set ILK_DPFC_FENCE_YOFF to 0 on SNB
Date: Wed, 8 Jul 2015 17:58:57 -0300 [thread overview]
Message-ID: <1436389139-16282-5-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1436389139-16282-1-git-send-email-przanoni@gmail.com>
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
The doc is pretty clear that this register should be set to 0 on SNB.
We already write y_offset to DPFC_CPU_FENCE_OFFSET a few lines below.
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
drivers/gpu/drm/i915/intel_fbc.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index 0373cbc..0a24e96 100644
--- a/drivers/gpu/drm/i915/intel_fbc.c
+++ b/drivers/gpu/drm/i915/intel_fbc.c
@@ -216,7 +216,12 @@ static void ilk_fbc_enable(struct intel_crtc *crtc)
dpfc_ctl |= obj->fence_reg;
y_offset = get_crtc_fence_y_offset(crtc);
- I915_WRITE(ILK_DPFC_FENCE_YOFF, y_offset);
+
+ if (IS_GEN5(dev_priv))
+ I915_WRITE(ILK_DPFC_FENCE_YOFF, y_offset);
+ else
+ I915_WRITE(ILK_DPFC_FENCE_YOFF, 0);
+
I915_WRITE(ILK_FBC_RT_BASE, i915_gem_obj_ggtt_offset(obj) | ILK_FBC_RT_VALID);
/* enable it... */
I915_WRITE(ILK_DPFC_CONTROL, dpfc_ctl | DPFC_CTL_EN);
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-08 20:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 20:58 [PATCH 0/6] More small FBC fixes Paulo Zanoni
2015-07-08 20:58 ` [PATCH 1/6] drm/i915: make sure we're not changing the FBC CFB with FBC enabled Paulo Zanoni
2015-07-08 20:58 ` [PATCH 2/6] drm/i915: fix the FBC work allocation failure path Paulo Zanoni
2015-07-08 22:05 ` Chris Wilson
2015-07-09 19:27 ` Paulo Zanoni
2015-07-08 20:58 ` [PATCH 3/6] drm/i915: fix FBC for cases where crtc->base.y is non-zero Paulo Zanoni
2015-07-08 20:58 ` Paulo Zanoni [this message]
2015-07-09 17:10 ` [PATCH 4/6] drm/i915: set ILK_DPFC_FENCE_YOFF to 0 on SNB Daniel Vetter
2015-07-09 17:15 ` Paulo Zanoni
2015-07-09 17:18 ` Paulo Zanoni
2015-07-09 17:22 ` Ville Syrjälä
2015-07-09 17:31 ` Paulo Zanoni
2015-07-09 17:39 ` Ville Syrjälä
2015-07-14 19:01 ` Paulo Zanoni
2015-07-08 20:58 ` [PATCH 5/6] drm/i915: check for the supported strides on HSW+ FBC Paulo Zanoni
2015-07-09 17:15 ` Daniel Vetter
2015-07-09 17:28 ` Paulo Zanoni
2015-07-09 19:29 ` Paulo Zanoni
2015-07-14 18:55 ` Paulo Zanoni
2015-07-08 20:58 ` [PATCH 6/6] drm/i915: try a little harder to find an FBC CRTC Paulo Zanoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436389139-16282-5-git-send-email-przanoni@gmail.com \
--to=przanoni@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox