public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 6/6] drm/i915: try a little harder to find an FBC CRTC
Date: Wed,  8 Jul 2015 17:58:59 -0300	[thread overview]
Message-ID: <1436389139-16282-7-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1436389139-16282-1-git-send-email-przanoni@gmail.com>

From: Paulo Zanoni <paulo.r.zanoni@intel.com>

Keep searching in case the candidate has a NULL primary fb. This is
only relevant for the platforms that don't have the pipe_a_only
restriction.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/i915/intel_fbc.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index 7b65b00..594b62d 100644
--- a/drivers/gpu/drm/i915/intel_fbc.c
+++ b/drivers/gpu/drm/i915/intel_fbc.c
@@ -532,16 +532,14 @@ static struct drm_crtc *intel_fbc_find_crtc(struct drm_i915_private *dev_priv)
 		tmp_crtc = dev_priv->pipe_to_crtc_mapping[pipe];
 
 		if (intel_crtc_active(tmp_crtc) &&
-		    to_intel_plane_state(tmp_crtc->primary->state)->visible)
+		    to_intel_plane_state(tmp_crtc->primary->state)->visible &&
+		    tmp_crtc->primary->fb != NULL)
 			crtc = tmp_crtc;
 
 		if (pipe_a_only)
 			break;
 	}
 
-	if (!crtc || crtc->primary->fb == NULL)
-		return NULL;
-
 	return crtc;
 }
 
-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2015-07-08 20:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 20:58 [PATCH 0/6] More small FBC fixes Paulo Zanoni
2015-07-08 20:58 ` [PATCH 1/6] drm/i915: make sure we're not changing the FBC CFB with FBC enabled Paulo Zanoni
2015-07-08 20:58 ` [PATCH 2/6] drm/i915: fix the FBC work allocation failure path Paulo Zanoni
2015-07-08 22:05   ` Chris Wilson
2015-07-09 19:27     ` Paulo Zanoni
2015-07-08 20:58 ` [PATCH 3/6] drm/i915: fix FBC for cases where crtc->base.y is non-zero Paulo Zanoni
2015-07-08 20:58 ` [PATCH 4/6] drm/i915: set ILK_DPFC_FENCE_YOFF to 0 on SNB Paulo Zanoni
2015-07-09 17:10   ` Daniel Vetter
2015-07-09 17:15     ` Paulo Zanoni
2015-07-09 17:18       ` Paulo Zanoni
2015-07-09 17:22     ` Ville Syrjälä
2015-07-09 17:31       ` Paulo Zanoni
2015-07-09 17:39         ` Ville Syrjälä
2015-07-14 19:01           ` Paulo Zanoni
2015-07-08 20:58 ` [PATCH 5/6] drm/i915: check for the supported strides on HSW+ FBC Paulo Zanoni
2015-07-09 17:15   ` Daniel Vetter
2015-07-09 17:28     ` Paulo Zanoni
2015-07-09 19:29       ` Paulo Zanoni
2015-07-14 18:55       ` Paulo Zanoni
2015-07-08 20:58 ` Paulo Zanoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436389139-16282-7-git-send-email-przanoni@gmail.com \
    --to=przanoni@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox