Re: [PATCH 03/13 v4] drm/i915: Add GuC-related header files

O'Rourke, Tom
2015-07-24T22:12:21Z

On Tue, Jul 21, 2015 at 08:38:35AM +0200, Daniel Vetter wrote:
> On Fri, Jul 17, 2015 at 05:38:05PM -0700, O'Rourke, Tom wrote:
> > On Thu, Jul 09, 2015 at 07:29:04PM +0100, Dave Gordon wrote:
> > > intel_guc_fwif.h contains the subset of the GuC interface that we
> > > will need for submission of commands through the GuC. These MUST
> > > be kept in sync with the definitions used by the GuC firmware, and
> > > updates to this file will (or should) be autogenerated from the
> > > source files used to build the firmware. Editing this file is
> > > therefore not recommended.
> > >
> > > i915_guc_reg.h contains definitions of GuC-related hardware:
> > > registers, bitmasks, etc. These should match the BSpec.
> > >
> > > v2:
> > > Files renamed & resliced per review comments by Chris Wilson
> > >
> > > v4:
> > > Added DON'T-EDIT-ME warning [Tom O'Rourke]
> > >
> > > Issue: VIZ-4884
> > > Signed-off-by: Alex Dai <yu.dai@intel.com>
> > > Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
> > > ---
> > Reviewed-by: Tom O'Rourke <Tom.O'Rourke@intel.com>
>
> Merged up to this patch, thanks.
> -Daniel
>
[TOR:] Thank you. Please hold merging remaining patches in
this series until guc firmware v3 is available on 01.org.
Tom