Re: [PATCH 02/13 v4] drm/i915: Add GuC-related module parameters

O'Rourke, Tom
2015-07-18T00:40:49Z

On Thu, Jul 09, 2015 at 07:29:03PM +0100, Dave Gordon wrote:
> From: Alex Dai <yu.dai@intel.com>
>
> Two new module parameters: "enable_guc_submission" which will turn
> on submission of batchbuffers via the GuC (when implemented), and
> "guc_log_level" which controls the level of debugging logged by the
> GuC and captured by the host.
>
> Signed-off-by: Alex Dai <yu.dai@intel.com>
>
> v4:
> Mark "enable_guc_submission" unsafe [Daniel Vetter]
>
> Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
> ---
Reviewed-by: Tom O'Rourke <Tom.O'Rourke@intel.com>

> drivers/gpu/drm/i915/i915_drv.h | 2 ++
> drivers/gpu/drm/i915/i915_params.c | 9 +++++++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 3c91507..4a512da 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2606,6 +2606,8 @@ struct i915_params {
> bool reset;
> bool disable_display;
> bool disable_vtd_wa;
> + bool enable_guc_submission;
> + int guc_log_level;
> int use_mmio_flip;
> int mmio_debug;
> bool verbose_state_checks;
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 7983fe4..2791b5a 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -53,6 +53,8 @@ struct i915_params i915 __read_mostly = {
> .verbose_state_checks = 1,
> .nuclear_pageflip = 0,
> .edp_vswing = 0,
> + .enable_guc_submission = false,
> + .guc_log_level = -1,
> };
>
> module_param_named(modeset, i915.modeset, int, 0400);
> @@ -186,3 +188,10 @@ MODULE_PARM_DESC(edp_vswing,
> "Ignore/Override vswing pre-emph table selection from VBT "
> "(0=use value from vbt [default], 1=low power swing(200mV),"
> "2=default swing(400mV))");
> +
> +module_param_named_unsafe(enable_guc_submission, i915.enable_guc_submission, bool, 0400);
> +MODULE_PARM_DESC(enable_guc_submission, "Enable GuC submission (default:false)");
> +
> +module_param_named(guc_log_level, i915.guc_log_level, int, 0400);
> +MODULE_PARM_DESC(guc_log_level,
> + "GuC firmware logging level (-1:disabled (default), 0-3:enabled)");
> --
> 1.9.1